d8cf36fbb1
Or current render target cache setting is to key on the binding table index, meaning the HW associates a number in the range [0, 7] to a RENDER_SURFACE_STATE description. If you want change the render target 0 between 2 draw calls, you need to insert a PIPE_CONTROL in between the 2 draw calls with pb-stall + rt-flush in order to flush an writes to a previous RENDER_SURFACE_STATE that has now becomed disassociated with the [0, 7] number. This PIPE_CONTROL taking care of the flush is dealt with in cmd_buffer_maybe_flush_rt_writes(). This function diffs the current BTI setup for render targets (first 0 to 7 BTIs) with what the next fragment shader wants. The issue here is we might have a render pass with 0 color attachments and yet in98cdb9349awe added one pointing to the render target 0, but in the emit_binding_table() when we finally program the BTI, we check the render pass color count and program a null surface state instead of an actual surface state. And this leads to hangs because the render target cache will end up with inconsistent state data. Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Fixes:98cdb9349a("anv: ensure null-rt bit in compiler isn't used when there is ds attachment") Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/12955 Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34603> (cherry picked from commit 63f633557ff53726b7bc8e2292f330ace8624be0)
`Mesa <https://mesa3d.org>`_ - The 3D Graphics Library ====================================================== Source ------ This repository lives at https://gitlab.freedesktop.org/mesa/mesa. Other repositories are likely forks, and code found there is not supported. Build & install --------------- You can find more information in our documentation (`docs/install.rst <https://docs.mesa3d.org/install.html>`_), but the recommended way is to use Meson (`docs/meson.rst <https://docs.mesa3d.org/meson.html>`_): .. code-block:: sh $ meson setup build $ ninja -C build/ $ sudo ninja -C build/ install Support ------- Many Mesa devs hang on IRC; if you're not sure which channel is appropriate, you should ask your question on `OFTC's #dri-devel <irc://irc.oftc.net/dri-devel>`_, someone will redirect you if necessary. Remember that not everyone is in the same timezone as you, so it might take a while before someone qualified sees your question. To figure out who you're talking to, or which nick to ping for your question, check out `Who's Who on IRC <https://dri.freedesktop.org/wiki/WhosWho/>`_. The next best option is to ask your question in an email to the mailing lists: `mesa-dev\@lists.freedesktop.org <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>`_ Bug reports ----------- If you think something isn't working properly, please file a bug report (`docs/bugs.rst <https://docs.mesa3d.org/bugs.html>`_). Contributing ------------ Contributions are welcome, and step-by-step instructions can be found in our documentation (`docs/submittingpatches.rst <https://docs.mesa3d.org/submittingpatches.html>`_). Note that Mesa uses gitlab for patches submission, review and discussions.