d34ac0a70b
Previously, custom buffer descriptors were owned by a descriptor set. Now, custom buffer descriptors are owned by the buffer. Additionally, we respect the app-provided sizes when they're smaller than the buffer size, even if robustness is not enabled, so that size queries work correctly. This new design fixes several issues: * Descriptor set copies were broken when they involved custom descriptors, because the original descriptor set owned the lifetime of the custom descriptor, the new one was just borrowing it. If those lifetimes didn't line up, problems would arise. * A single buffer with the same sub-view placed in multiplel descriptor sets would allocate multiple slots, when it only really needed one. * Custom buffer descriptors now lower the base offset to 0 to allow merging multiple overlapping (ending at the same upper bound) descriptors. Since the shader is already doing an offset add, making it nonzero is free. * Dynamic buffer descriptors were incorrect before. The size passed into the descriptor set is supposed to be the size from the *dynamic* offset, not the size from the static offset. By allocating/populating the descriptor when placed into the set, it prevented larger offsets from working correctly. This buffer-owned design prevents cmdbufs from having to own lifetime of custom descriptors. Fixes dEQP-VK.ssbo.unsized_array_length.float_offset_explicit_size Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22639>
`Mesa <https://mesa3d.org>`_ - The 3D Graphics Library ====================================================== Source ------ This repository lives at https://gitlab.freedesktop.org/mesa/mesa. Other repositories are likely forks, and code found there is not supported. Build & install --------------- You can find more information in our documentation (`docs/install.rst <https://mesa3d.org/install.html>`_), but the recommended way is to use Meson (`docs/meson.rst <https://mesa3d.org/meson.html>`_): .. code-block:: sh $ mkdir build $ cd build $ meson .. $ sudo ninja install Support ------- Many Mesa devs hang on IRC; if you're not sure which channel is appropriate, you should ask your question on `OFTC's #dri-devel <irc://irc.oftc.net/dri-devel>`_, someone will redirect you if necessary. Remember that not everyone is in the same timezone as you, so it might take a while before someone qualified sees your question. To figure out who you're talking to, or which nick to ping for your question, check out `Who's Who on IRC <https://dri.freedesktop.org/wiki/WhosWho/>`_. The next best option is to ask your question in an email to the mailing lists: `mesa-dev\@lists.freedesktop.org <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>`_ Bug reports ----------- If you think something isn't working properly, please file a bug report (`docs/bugs.rst <https://mesa3d.org/bugs.html>`_). Contributing ------------ Contributions are welcome, and step-by-step instructions can be found in our documentation (`docs/submittingpatches.rst <https://mesa3d.org/submittingpatches.html>`_). Note that Mesa uses gitlab for patches submission, review and discussions.