c601e730b2
When PIPE_CAP_ALPHA_TEST is zero, the driver does not support alpha testing, so alpha shouldn't be set. In particular, alpha.enable should be zero, since logically alpha testing is not used in the ZSA CSO when it's lowered in the fragment shader key. Fixes failing asserts in kicad, rvgl, etc with Panfrost since6afd4ad. (We could remove the assert in panfrost instead, but logically setting alpha.enabled on top of lowering the shader seems wrong?) As Erik pointed out, this should improve CSO cache behaviour. Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Reported-by: Icecream95 <ixn@keemail.me> Tested-by: Urja Rannikko <urjaman@gmail.com> Tested-by: Robin Murphy <robin.murphy@arm.com> Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com> Fixes:6afd4addef("panfrost: Simplify depth/stencil/alpha") Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6523>
`Mesa <https://mesa3d.org>`_ - The 3D Graphics Library ====================================================== Source ------ This repository lives at https://gitlab.freedesktop.org/mesa/mesa. Other repositories are likely forks, and code found there is not supported. Build & install --------------- You can find more information in our documentation (`docs/install.rst <https://mesa3d.org/install.html>`_), but the recommended way is to use Meson (`docs/meson.rst <https://mesa3d.org/meson.html>`_): .. code-block:: sh $ mkdir build $ cd build $ meson .. $ sudo ninja install Support ------- Many Mesa devs hang on IRC; if you're not sure which channel is appropriate, you should ask your question on `Freenode's #dri-devel <irc://chat.freenode.net#dri-devel>`_, someone will redirect you if necessary. Remember that not everyone is in the same timezone as you, so it might take a while before someone qualified sees your question. To figure out who you're talking to, or which nick to ping for your question, check out `Who's Who on IRC <https://dri.freedesktop.org/wiki/WhosWho/>`_. The next best option is to ask your question in an email to the mailing lists: `mesa-dev\@lists.freedesktop.org <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>`_ Bug reports ----------- If you think something isn't working properly, please file a bug report (`docs/bugs.rst <https://mesa3d.org/bugs.html>`_). Contributing ------------ Contributions are welcome, and step-by-step instructions can be found in our documentation (`docs/submittingpatches.rst <https://mesa3d.org/submittingpatches.html>`_). Note that Mesa uses gitlab for patches submission, review and discussions.