8992cf5ab8
This commit makes `kernel+rootfs_arm64` job build and install skqp on ARM64 devices rootfs. Skia repository has a tool to prepare skqp models located at `tools/skqp/cut-release`, which get files from [Skia Gold](https://skia.org/docs/dev/testing/skiagold/), generate files.checksum, rendertests.txt and unittests.txt. One gives a range of commits to let `cut-release` find the right resources to prepare skqp for the user. However, it is failing, since it fails when trying to get image packages from a range of commits via HTTPS from the host https://public-gold.skia.org but it responds with error 404 every time. I tried a range a thousand of commits, yet it still does not give results. The workaround employed was to recover the most recent `files.checksum` and `rendertests.txt` files from the git history and generate `unittests.txt` from `list_gpu_unit_tests` binary. `skqp` runs two lists of tests, `rendertests.txt` and `unittests.txt`. Both must be located inside the `skqp` assets folder. The first list uses GL and GLES to test rendering scenarios. The second runs some unit tests that do not render an image per se. In order to make the first `a630_skqp` to be green, the crashing tests were removed from the test lists and the expectations of the failing ones were updated. It is worth noting that `rendertests.txt` can bring some detail about each test expectation, so each test can have a max pixel error count, to tell `skqp` that it is OK to have at most that number of errors for that test. See also: https://github.com/google/skia/blob/main/tools/skqp/README_ALGORITHM.md As each render backend has a different error count, two different `rendertests.txt` files were created, `src/freedreno/ci/freedreno-a630-skqp-gl_rendertests.txt`, `src/freedreno/ci/freedreno-a630-skqp-gles_rendertests.txt` and , which one refers to GL and GLES tests respectfully. The unit tests file for a630 is located at `src/freedreno/ci/freedreno-a630-skqp_unittests.txt` ``` aaclip domain formats highcontrastfilter rectangle_texture yuv_make_color_space ``` ``` ProcessorOptimizationValidationTest VkProtectedContext_CreateNonprotectedContext VkYCbcrSampler_DrawImageWithYcbcrSampler VkYCbcrSampler_NoYcbcrSurface ``` Each test was updated with the max_error count equal to the first run result. ``` analytic_antialias_inverse async_rescale_and_read_dog_down async_rescale_and_read_dog_up async_rescale_and_read_rose async_rescale_and_read_text_down async_rescale_and_read_text_up async_rescale_and_read_text_up_large async_rescale_and_read_yuv420_rose complexclip2_path_bw encode-platform imageblur_large lcdtextsize onebadarc onefailarc scale-pixels surfaceprops textfilter_color textfilter_image ``` Considering all the following tests results as wrong. ``` async_rescale_and_read_no_bleed backdrop_imagefilter_croprect_persp complexclip2 imageblurrepeatmode mixerCF overdrawcolorfilter patch_alpha patch_primitive rrect_clip_bw scaledemoji_rendering yuv_splitter ``` v2: a) add link to HTML report on job log b) remove extraneous spaces diff c) remove unnecessary conditions from build-skqp.sh d) use fixed skqp source commit SHA v3: a) Use only main skia repository to fetch models and build skqp b) Use list_gpu_unit_tests binary to create a base unittests.txt file c) Remove crashing tests d) Set failing tests expectations for the first skqp run v4: a) Remove clang dependency b) Separate each skqp backend result into its folder c) Regroup a630_skqp in one job v5: a) Separate tests files per driver Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/5580 Signed-off-by: Guilherme Gallo <guilherme.gallo@collabora.com> Reviewed-by: Emma Anholt <emma@anholt.net> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14146>
83 lines
2.5 KiB
Bash
Executable File
83 lines
2.5 KiB
Bash
Executable File
#!/bin/bash
|
|
|
|
create_gn_args() {
|
|
cp "${BASE_ARGS_GN_FILE}" "${SKQP_OUT_DIR}"/args.gn
|
|
echo "target_cpu = \"${SKQP_ARCH}\"" >> "${SKQP_OUT_DIR}"/args.gn
|
|
}
|
|
|
|
download_skqp_models() (
|
|
# The download_model.py script needs a checksum file to know what models
|
|
# version to download.
|
|
|
|
# This is the most recent commit available in the skia repository with a
|
|
# valid files.checksum
|
|
SKIA_LAST_SKQP_CUT_COMMIT_SHA=ccf5f0d75b6a6b54756f2c62d57e3730eed8aa45
|
|
git fetch origin "${SKIA_LAST_SKQP_CUT_COMMIT_SHA}:refs/remotes/origin/${SKIA_LAST_SKQP_CUT_COMMIT_SHA}"
|
|
git checkout "${SKIA_LAST_SKQP_CUT_COMMIT_SHA}" -- \
|
|
platform_tools/android/apps/skqp/src/main/assets/files.checksum
|
|
|
|
# The following patch transforms download_model.py from python2 to python3.
|
|
git apply "${DOWNLOAD_MODEL_PATCH_FILE}"
|
|
python3 tools/skqp/download_model.py
|
|
|
|
# Copy resources from skia to skqp directory
|
|
python3 tools/skqp/setup_resources
|
|
)
|
|
|
|
set -ex
|
|
|
|
SCRIPT_DIR=$(realpath "$(dirname "$0")")
|
|
FETCH_GN_PATCH_FILE="${SCRIPT_DIR}/build-skqp_fetch-gn.patch"
|
|
BASE_ARGS_GN_FILE="${SCRIPT_DIR}/build-skqp_base.gn"
|
|
DOWNLOAD_MODEL_PATCH_FILE="${SCRIPT_DIR}/build-skqp_download_model.patch"
|
|
|
|
SKQP_ARCH=${SKQP_ARCH:-x64}
|
|
SKIA_DIR=${SKIA_DIR:-$(mktemp -d)}
|
|
SKQP_DIR=${SKQP_DIR:-$(mktemp -d)}
|
|
SKQP_OUT_DIR=${SKIA_DIR}/out/${SKQP_ARCH}
|
|
SKQP_INSTALL_DIR=/skqp
|
|
SKQP_ASSETS_DIR="${SKQP_INSTALL_DIR}/assets"
|
|
# Build list_gpu_unit_tests to update the unittests.txt file properly to the
|
|
# target hardware.
|
|
SKQP_BINARIES=(skqp list_gpu_unit_tests)
|
|
|
|
# Using a recent release version to mitigate instability during test phase
|
|
SKIA_COMMIT_SHA="canvaskit/0.32.0"
|
|
|
|
git clone 'https://skia.googlesource.com/skia/' \
|
|
--single-branch \
|
|
-b "${SKIA_COMMIT_SHA}" \
|
|
"${SKIA_DIR}"
|
|
|
|
pushd "${SKIA_DIR}"
|
|
|
|
git apply "${FETCH_GN_PATCH_FILE}"
|
|
# Fetch some needed build tools needed to build skia/skqp
|
|
# Basically, it clones repositories with commits SHAs from
|
|
# ${SKIA_DIR}/DEPS directory
|
|
python3 tools/git-sync-deps
|
|
|
|
mkdir -p "${SKQP_OUT_DIR}"
|
|
mkdir -p "${SKQP_INSTALL_DIR}"
|
|
|
|
create_gn_args
|
|
|
|
# Build and install skqp binaries
|
|
bin/gn gen "${SKQP_OUT_DIR}"
|
|
|
|
for BINARY in "${SKQP_BINARIES[@]}"
|
|
do
|
|
/usr/bin/ninja -C "${SKQP_OUT_DIR}" "${BINARY}"
|
|
install -m 0755 "${SKQP_OUT_DIR}/${BINARY}" "${SKQP_INSTALL_DIR}"
|
|
done
|
|
|
|
# Acquire assets and move them to the target directory.
|
|
download_skqp_models
|
|
mv platform_tools/android/apps/skqp/src/main/assets/ "${SKQP_ASSETS_DIR}"
|
|
|
|
popd
|
|
rm -Rf "${SKQP_DIR}"
|
|
rm -Rf "${SKIA_DIR}"
|
|
|
|
set +ex
|