Files
third_party_mesa3d/src/freedreno/fdl/fd6_layout_test.c
Eric Anholt 81f21ff4ef freedreno/a6xx: Fix UBWC mipmap sizing.
The HW requires a log2 width/height of the level 0 meta_* size in the
descriptors, making it pretty clear that UBWC mipmapping is all
power-of-two sized.  Fixes a bunch of failures in the upcoming unit UBWC
layout unit tests.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4931>
2020-05-13 19:18:16 +00:00

567 lines
16 KiB
C

/*
* Copyright © 2020 Google LLC
*
* Permission is hereby granted, free of charge, to any person obtaining a
* copy of this software and associated documentation files (the "Software"),
* to deal in the Software without restriction, including without limitation
* the rights to use, copy, modify, merge, publish, distribute, sublicense,
* and/or sell copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following conditions:
*
* The above copyright notice and this permission notice (including the next
* paragraph) shall be included in all copies or substantial portions of the
* Software.
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
* IN THE SOFTWARE.
*/
#include "freedreno_layout.h"
#include "adreno_common.xml.h"
#include "a6xx.xml.h"
#include <stdio.h>
struct testcase {
enum pipe_format format;
int array_size; /* Size for array textures, or 0 otherwise. */
bool is_3d;
/* Partially filled layout of input parameters and expected results. */
struct fdl_layout layout;
};
static const struct testcase testcases[] = {
/* A straightforward first testcase, linear, with an obvious format. */
{
.format = PIPE_FORMAT_R8G8B8A8_UNORM,
.layout = {
.width0 = 32, .height0 = 32,
.slices = {
{ .offset = 0, .pitch = 256 },
{ .offset = 8192, .pitch = 256 },
{ .offset = 12288, .pitch = 256 },
{ .offset = 14336, .pitch = 256 },
{ .offset = 15360, .pitch = 256 },
{ .offset = 15872, .pitch = 256 },
},
},
},
/* A tiled/ubwc layout from the blob driver, at a size where the a630 blob
* driver does something interesting for linear.
*/
{
.format = PIPE_FORMAT_R8G8B8A8_UNORM,
.layout = {
.tile_mode = TILE6_3,
.ubwc = true,
.width0 = 1024, .height0 = 1,
.slices = {
{ .offset = 0, .pitch = 4096 },
{ .offset = 65536, .pitch = 2048 },
{ .offset = 98304, .pitch = 1024 },
{ .offset = 114688, .pitch = 512 },
{ .offset = 122880, .pitch = 256 },
{ .offset = 126976, .pitch = 256 },
{ .offset = 131072, .pitch = 256 },
{ .offset = 135168, .pitch = 256 },
{ .offset = 139264, .pitch = 256 },
{ .offset = 143360, .pitch = 256 },
{ .offset = 147456, .pitch = 256 },
},
.ubwc_slices = {
{ .offset = 0, .pitch = 64 },
{ .offset = 4096, .pitch = 64 },
{ .offset = 8192, .pitch = 64 },
{ .offset = 12288, .pitch = 64 },
{ .offset = 16384, .pitch = 64 },
{ .offset = 20480, .pitch = 64 },
{ .offset = 24576, .pitch = 64 },
{ .offset = 28672, .pitch = 64 },
{ .offset = 32768, .pitch = 64 },
{ .offset = 36864, .pitch = 64 },
{ .offset = 40960, .pitch = 64 },
},
},
},
/* An interesting layout from the blob driver on a630, showing that
* per-level pitch must be derived from level 0's pitch, not width0. We
* don't do this level 0 pitch disalignment (we pick 4096), so disabled
* this test for now.
*/
#if 0
{
.format = PIPE_FORMAT_R8G8B8A8_UNORM,
.layout = {
.width0 = 1024, .height0 = 1,
.slices = {
{ .offset = 0, .pitch = 5120 },
{ .offset = 5120, .pitch = 2560 },
{ .offset = 7680, .pitch = 1280 },
{ .offset = 8960, .pitch = 768 },
{ .offset = 9728, .pitch = 512 },
{ .offset = 10240, .pitch = 256 },
{ .offset = 10496, .pitch = 256 },
{ .offset = 10752, .pitch = 256 },
{ .offset = 11008, .pitch = 256 },
{ .offset = 11264, .pitch = 256 },
{ .offset = 11520, .pitch = 256 },
},
},
},
#endif
/* A layout that we failed on (129 wide has a surprise level 1 pitch
* increase), and the sizes bracketing it.
*/
{
.format = PIPE_FORMAT_R8G8B8A8_UNORM,
.layout = {
.width0 = 128, .height0 = 1,
.slices = {
{ .offset = 0, .pitch = 512 },
{ .offset = 512, .pitch = 256 },
{ .offset = 768, .pitch = 256 },
{ .offset = 1024, .pitch = 256 },
{ .offset = 1280, .pitch = 256 },
{ .offset = 1536, .pitch = 256 },
{ .offset = 1792, .pitch = 256 },
{ .offset = 2048, .pitch = 256 },
},
},
},
{
.format = PIPE_FORMAT_R8G8B8A8_UNORM,
.layout = {
.width0 = 129, .height0 = 1,
.slices = {
{ .offset = 0, .pitch = 768 },
{ .offset = 768, .pitch = 512 },
{ .offset = 1280, .pitch = 256 },
{ .offset = 1536, .pitch = 256 },
{ .offset = 1792, .pitch = 256 },
{ .offset = 2048, .pitch = 256 },
{ .offset = 2304, .pitch = 256 },
{ .offset = 2560, .pitch = 256 },
},
},
},
{
.format = PIPE_FORMAT_R8G8B8A8_UNORM,
.layout = {
.width0 = 130, .height0 = 1,
.slices = {
{ .offset = 0, .pitch = 768 },
{ .offset = 768, .pitch = 512 },
{ .offset = 1280, .pitch = 256 },
{ .offset = 1536, .pitch = 256 },
{ .offset = 1792, .pitch = 256 },
{ .offset = 2048, .pitch = 256 },
{ .offset = 2304, .pitch = 256 },
{ .offset = 2560, .pitch = 256 },
},
},
},
/* The 129 failure seems to be across formats, let's test some cpps */
{
.format = PIPE_FORMAT_R8_UNORM,
.layout = {
.width0 = 129, .height0 = 1,
.slices = {
{ .offset = 0, .pitch = 192 },
{ .offset = 192, .pitch = 128 },
{ .offset = 320, .pitch = 64 },
{ .offset = 384, .pitch = 64 },
{ .offset = 448, .pitch = 64 },
{ .offset = 512, .pitch = 64 },
{ .offset = 576, .pitch = 64 },
{ .offset = 640, .pitch = 64 },
},
},
},
{
.format = PIPE_FORMAT_R16_UINT,
.layout = {
.width0 = 129, .height0 = 1,
.slices = {
{ .offset = 0, .pitch = 384 },
{ .offset = 384, .pitch = 256 },
{ .offset = 640, .pitch = 128 },
{ .offset = 768, .pitch = 128 },
{ .offset = 896, .pitch = 128 },
{ .offset = 1024, .pitch = 128 },
{ .offset = 1152, .pitch = 128 },
{ .offset = 1280, .pitch = 128 },
},
},
},
{
.format = PIPE_FORMAT_R32G32B32A32_FLOAT,
.layout = {
.width0 = 129, .height0 = 1,
.slices = {
{ .offset = 0, .pitch = 3072 },
{ .offset = 3072, .pitch = 2048 },
{ .offset = 5120, .pitch = 1024 },
{ .offset = 6144, .pitch = 1024 },
{ .offset = 7168, .pitch = 1024 },
{ .offset = 8192, .pitch = 1024 },
{ .offset = 9216, .pitch = 1024 },
{ .offset = 10240, .pitch = 1024 },
},
},
},
/* The 129 failure replicated at every +256 pixels wide. Pick one of
* them, and this time increase the height as a new variable as well.
*/
{
.format = PIPE_FORMAT_R8G8B8A8_UNORM,
.layout = {
.width0 = 385, .height0 = 128,
.slices = {
{ .offset = 0, .pitch = 1792 },
{ .offset = 229376, .pitch = 1024 },
{ .offset = 294912, .pitch = 512 },
{ .offset = 311296, .pitch = 256 },
{ .offset = 315392, .pitch = 256 },
{ .offset = 317440, .pitch = 256 },
{ .offset = 318464, .pitch = 256 },
{ .offset = 318976, .pitch = 256 },
{ .offset = 319232, .pitch = 256 },
},
},
},
/* At 257-259 (and replicated every +256 pixels) we had another failure. */
{
.format = PIPE_FORMAT_R8G8B8A8_UNORM,
.layout = {
.width0 = 257, .height0 = 1,
.slices = {
{ .offset = 0, .pitch = 1280 },
{ .offset = 1280, .pitch = 768 },
{ .offset = 2048, .pitch = 512 },
{ .offset = 2560, .pitch = 256 },
{ .offset = 2816, .pitch = 256 },
{ .offset = 3072, .pitch = 256 },
{ .offset = 3328, .pitch = 256 },
{ .offset = 3584, .pitch = 256 },
{ .offset = 3840, .pitch = 256 },
},
},
},
{
.format = PIPE_FORMAT_R8G8B8A8_UNORM,
.layout = {
.width0 = 258, .height0 = 1,
.slices = {
{ .offset = 0, .pitch = 1280 },
{ .offset = 1280, .pitch = 768 },
{ .offset = 2048, .pitch = 512 },
{ .offset = 2560, .pitch = 256 },
{ .offset = 2816, .pitch = 256 },
{ .offset = 3072, .pitch = 256 },
{ .offset = 3328, .pitch = 256 },
{ .offset = 3584, .pitch = 256 },
{ .offset = 3840, .pitch = 256 },
},
},
},
{
.format = PIPE_FORMAT_R8G8B8A8_UNORM,
.layout = {
.width0 = 259, .height0 = 1,
.slices = {
{ .offset = 0, .pitch = 1280 },
{ .offset = 1280, .pitch = 768 },
{ .offset = 2048, .pitch = 512 },
{ .offset = 2560, .pitch = 256 },
{ .offset = 2816, .pitch = 256 },
{ .offset = 3072, .pitch = 256 },
{ .offset = 3328, .pitch = 256 },
{ .offset = 3584, .pitch = 256 },
{ .offset = 3840, .pitch = 256 },
},
},
},
{
.format = PIPE_FORMAT_R8G8B8A8_UNORM,
.layout = {
.width0 = 260, .height0 = 1,
.slices = {
{ .offset = 0, .pitch = 1280 },
{ .offset = 1280, .pitch = 768 },
{ .offset = 2048, .pitch = 512 },
{ .offset = 2560, .pitch = 256 },
{ .offset = 2816, .pitch = 256 },
{ .offset = 3072, .pitch = 256 },
{ .offset = 3328, .pitch = 256 },
{ .offset = 3584, .pitch = 256 },
{ .offset = 3840, .pitch = 256 },
},
},
},
/* And, again for the 257-9 failure, test a replica with a larger size*/
{
.format = PIPE_FORMAT_R8G8B8A8_UNORM,
.layout = {
.width0 = 513, .height0 = 32,
.slices = {
{ .offset = 0, .pitch = 2304 },
{ .offset = 73728, .pitch = 1280 },
{ .offset = 94208, .pitch = 768 },
{ .offset = 100352, .pitch = 512 },
{ .offset = 102400, .pitch = 256 },
{ .offset = 102912, .pitch = 256 },
{ .offset = 103168, .pitch = 256 },
{ .offset = 103424, .pitch = 256 },
{ .offset = 103680, .pitch = 256 },
{ .offset = 103936, .pitch = 256 },
},
},
},
/* Oh, look. The 513-517 failure extends up to 518 at the next texture
* level!
*/
{
.format = PIPE_FORMAT_R8G8B8A8_UNORM,
.layout = {
.width0 = 518, .height0 = 1,
.slices = {
{ .offset = 0, .pitch = 2304 },
{ .offset = 2304, .pitch = 1280 },
{ .offset = 3584, .pitch = 768 },
{ .offset = 4352, .pitch = 512 },
{ .offset = 4864, .pitch = 256 },
{ .offset = 5120, .pitch = 256 },
{ .offset = 5376, .pitch = 256 },
{ .offset = 5632, .pitch = 256 },
{ .offset = 5888, .pitch = 256 },
{ .offset = 6144, .pitch = 256 },
},
},
},
/* Tiled mode testing of the unusual 1/2-bytes-per-pixel pitch alignment */
{
.format = PIPE_FORMAT_R8_UNORM,
.layout = {
.tile_mode = TILE6_3,
.width0 = 129, .height0 = 1,
.slices = {
{ .offset = 0, .pitch = 256 },
{ .offset = 8192, .pitch = 128 },
{ .offset = 12288, .pitch = 128 },
{ .offset = 16384, .pitch = 128 },
{ .offset = 20480, .pitch = 64 },
{ .offset = 20544, .pitch = 64 },
{ .offset = 20608, .pitch = 64 },
{ .offset = 20672, .pitch = 64 },
},
},
},
/* Single-level RGBA8888 UBWC following UBWC alignment rules laid out in
* msm_media_info.h to verify that we don't break buffer sharing.
*/
{
.format = PIPE_FORMAT_R8G8B8A8_UNORM,
.layout = {
.tile_mode = TILE6_3,
.ubwc = true,
.width0 = 16384, .height0 = 129,
.slices = {
{ .offset = 1024 * 48, .pitch = 16384 * 4 },
},
.ubwc_slices = {
{ .offset = 0, .pitch = 1024 },
},
},
},
/* UBWC: Pitch comes from POT-aligned level 0. */
/* Pitch fixed in this commit, but offsets broken. Will be fixed in
* following commits.
*/
#if 0
{
.format = PIPE_FORMAT_R8G8B8A8_UNORM,
.layout = {
.tile_mode = TILE6_3,
.ubwc = true,
.width0 = 2049, .height0 = 128,
.slices = {
{ .offset = 0, .pitch = 8448 },
{ .offset = 1081344, .pitch = 4352 },
{ .offset = 1359872, .pitch = 2304 },
{ .offset = 1433600, .pitch = 1280 },
{ .offset = 1454080, .pitch = 768 },
{ .offset = 1466368, .pitch = 512 },
{ .offset = 1474560, .pitch = 256 },
{ .offset = 1478656, .pitch = 256 },
{ .offset = 1482752, .pitch = 256 },
{ .offset = 1486848, .pitch = 256 },
{ .offset = 1490944, .pitch = 256 },
{ .offset = 1495040, .pitch = 256 },
},
.ubwc_slices = {
{ .offset = 0, .pitch = 256 },
{ .offset = 16384, .pitch = 128 },
{ .offset = 24576, .pitch = 64 },
{ .offset = 28672, .pitch = 64 },
{ .offset = 32768, .pitch = 64 },
{ .offset = 36864, .pitch = 64 },
{ .offset = 40960, .pitch = 64 },
{ .offset = 45056, .pitch = 64 },
{ .offset = 49152, .pitch = 64 },
{ .offset = 53248, .pitch = 64 },
{ .offset = 57344, .pitch = 64 },
{ .offset = 61440, .pitch = 64 },
},
},
},
#endif
/* UBWC: Height comes from POT-aligned level 0. */
{
.format = PIPE_FORMAT_R8G8B8A8_UNORM,
.layout = {
.tile_mode = TILE6_3,
.ubwc = true,
.width0 = 1024, .height0 = 1025,
.slices = {
{ .offset = 0, .pitch = 4096 },
{ .offset = 4259840, .pitch = 2048 },
{ .offset = 5308416, .pitch = 1024 },
{ .offset = 5570560, .pitch = 512 },
{ .offset = 5636096, .pitch = 256 },
{ .offset = 5652480, .pitch = 256 },
{ .offset = 5660672, .pitch = 256 },
{ .offset = 5664768, .pitch = 256 },
{ .offset = 5668864, .pitch = 256 },
{ .offset = 5672960, .pitch = 256 },
{ .offset = 5677056, .pitch = 256 },
},
.ubwc_slices = {
{ .offset = 0, .pitch = 64 },
{ .offset = 32768, .pitch = 64 },
{ .offset = 49152, .pitch = 64 },
{ .offset = 57344, .pitch = 64 },
{ .offset = 61440, .pitch = 64 },
{ .offset = 65536, .pitch = 64 },
{ .offset = 69632, .pitch = 64 },
{ .offset = 73728, .pitch = 64 },
{ .offset = 77824, .pitch = 64 },
{ .offset = 81920, .pitch = 64 },
{ .offset = 86016, .pitch = 64 },
},
},
},
};
static bool test_layout(const struct testcase *testcase)
{
struct fdl_layout layout = {
.ubwc = testcase->layout.ubwc,
.tile_mode = testcase->layout.tile_mode,
};
bool ok = true;
int max_size = MAX2(testcase->layout.width0, testcase->layout.height0);
int mip_levels = 1;
while (max_size > 1 && testcase->layout.slices[mip_levels].pitch) {
mip_levels++;
max_size = u_minify(max_size, 1);
}
fdl6_layout(&layout,
testcase->format,
MAX2(testcase->layout.nr_samples, 1),
testcase->layout.width0,
MAX2(testcase->layout.height0, 1),
MAX2(testcase->layout.depth0, 1),
mip_levels,
MAX2(testcase->array_size, 1),
testcase->is_3d);
/* fdl lays out UBWC data before the color data, while all we have
* recorded in this testcase are the color offsets (other than the UBWC
* buffer sharing test). Shift the fdl layout down so we can compare
* color offsets.
*/
if (layout.ubwc && !testcase->layout.slices[0].offset) {
for (int l = 1; l < mip_levels; l++)
layout.slices[l].offset -= layout.slices[0].offset;
layout.slices[0].offset = 0;
}
for (int l = 0; l < mip_levels; l++) {
if (layout.slices[l].offset != testcase->layout.slices[l].offset) {
fprintf(stderr, "%s %dx%dx%d@%dx lvl%d: offset 0x%x != 0x%x\n",
util_format_short_name(testcase->format),
layout.width0, layout.height0, layout.depth0,
layout.nr_samples, l,
layout.slices[l].offset,
testcase->layout.slices[l].offset);
ok = false;
}
if (layout.slices[l].pitch != testcase->layout.slices[l].pitch) {
fprintf(stderr, "%s %dx%dx%d@%dx lvl%d: pitch %d != %d\n",
util_format_short_name(testcase->format),
layout.width0, layout.height0, layout.depth0,
layout.nr_samples, l,
layout.slices[l].pitch,
testcase->layout.slices[l].pitch);
ok = false;
}
if (layout.ubwc_slices[l].offset != testcase->layout.ubwc_slices[l].offset) {
fprintf(stderr, "%s %dx%dx%d@%dx lvl%d: UBWC offset 0x%x != 0x%x\n",
util_format_short_name(testcase->format),
layout.width0, layout.height0, layout.depth0,
layout.nr_samples, l,
layout.ubwc_slices[l].offset,
testcase->layout.ubwc_slices[l].offset);
ok = false;
}
if (layout.ubwc_slices[l].pitch != testcase->layout.ubwc_slices[l].pitch) {
fprintf(stderr, "%s %dx%dx%d@%dx lvl%d: UBWC pitch %d != %d\n",
util_format_short_name(testcase->format),
layout.width0, layout.height0, layout.depth0,
layout.nr_samples, l,
layout.ubwc_slices[l].pitch,
testcase->layout.ubwc_slices[l].pitch);
ok = false;
}
}
if (!ok)
fprintf(stderr, "\n");
return ok;
}
int
main(int argc, char **argv)
{
int ret = 0;
for (int i = 0; i < ARRAY_SIZE(testcases); i++) {
if (!test_layout(&testcases[i]))
ret = 1;
}
return ret;
}