OpenHarmony/third_party_mesa3d
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
5ffbee84a4b9ccfb9ba1cb7d054590cf4030353d
third_party_mesa3d/src/intel/compiler
History
Ian Romanick 5ffbee84a4 intel/compiler: Add id parameter to shader_perf_log callback 
There are two problems with the current architecture.

In OpenGL, the id is supposed to be a unique identifier for a particular
log source.  This is done so that applications can (theoretically)
filter particular log messages.  The debug callback infrastructure in
Mesa assigns a uniqe value when a value of 0 is passed in.  This causes
the id to get set once to a unique value for each message.

By passing a stack variable that is initialized to 0 on every call,
every time the same message is logged, it will have a different id.
This isn't great, but it's also not catastrophic.

When threaded shader compiles are used, the id *pointer* is saved and
dereferenced at a possibly much later time on a possibly different
thread.  This causes one thread to access the stack from a different
thread... and that stack frame might not be valid any more. :(

I have not observed any crashes related to this particular issue.

Reviewed-by: Matt Turner <mattst88@gmail.com>
Reviewed-by: Anuj Phogat <anuj.phogat@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12136>
2021-08-01 23:58:08 +00:00
..
brw_cfg.cpp
intel/compiler: Add the ability to defer IP updates in backend_instruction::remove
2021-07-14 09:56:46 -07:00
brw_cfg.h
intel/compiler: Add cfg_t::adjust_block_ips() method
2021-07-14 09:56:59 -07:00
brw_clip_line.c
intel: Rename gen_device prefix to intel_device
2021-04-20 20:06:33 +00:00
brw_clip_point.c
…
brw_clip_tri.c
intel: Rename gen_device prefix to intel_device
2021-04-20 20:06:33 +00:00
brw_clip_unfilled.c
…
brw_clip_util.c
intel: Rename gen field in gen_device_info struct to ver
2021-04-02 18:33:07 +00:00
brw_clip.h
…
brw_compile_clip.c
intel: Rename files with gen_debug prefix
2021-04-20 20:06:33 +00:00
brw_compile_ff_gs.c
intel/compiler: add support for compiling fixed function gs
2021-05-04 03:39:45 +00:00
brw_compile_sf.c
intel: Rename files with gen_debug prefix
2021-04-20 20:06:33 +00:00
brw_compiler.c
intel/compiler: Enable has_iadd3 option on XeHP
2021-07-16 15:59:56 +00:00
brw_compiler.h
intel/compiler: Add id parameter to shader_perf_log callback
2021-08-01 23:58:08 +00:00
brw_dead_control_flow.cpp
intel/compiler: Pass detailed dependency classes to invalidate_analysis()
2020-03-06 10:20:39 -08:00
brw_dead_control_flow.h
…
brw_debug_recompile.c
intel/compiler: Add id parameter to shader_perf_log callback
2021-08-01 23:58:08 +00:00
brw_disasm_info.c
intel: Rename gen_device prefix to intel_device
2021-04-20 20:06:33 +00:00
brw_disasm_info.h
intel: Rename gen_device prefix to intel_device
2021-04-20 20:06:33 +00:00
brw_disasm.c
intel/disasm: Disassemble LSC message extended descriptors
2021-06-30 16:17:18 +00:00
brw_eu_compact.c
intel: Fix alignment and line wrapping due to gen_device renaming
2021-04-20 20:06:33 +00:00
brw_eu_defines.h
intel/compiler: Add support for ternary add instruction on XeHP
2021-07-16 15:59:56 +00:00
brw_eu_emit.c
intel/compiler: Add support for ternary add instruction on XeHP
2021-07-16 15:59:56 +00:00
brw_eu_util.c
intel: Rename genx keyword to gfxx in source files
2021-04-02 18:33:07 +00:00
brw_eu_validate.c
intel/eu: Don't validate LSC transpose on ops that don't have it
2021-07-22 21:06:33 +00:00
brw_eu.cpp
intel/compiler: Add support for ternary add instruction on XeHP
2021-07-16 15:59:56 +00:00
brw_eu.h
intel/eu: Don't validate LSC transpose on ops that don't have it
2021-07-22 21:06:33 +00:00
brw_fs_bank_conflicts.cpp
intel: Fix alignment and line wrapping due to gen_device renaming
2021-04-20 20:06:33 +00:00
brw_fs_builder.h
intel/compiler: Add support for ternary add instruction on XeHP
2021-07-16 15:59:56 +00:00
brw_fs_cmod_propagation.cpp
intel/compiler: Update block IPs once in opt_cmod_propagation
2021-07-14 09:57:06 -07:00
brw_fs_combine_constants.cpp
intel/compiler: Fix missing break in switch
2021-07-22 23:38:04 +00:00
brw_fs_copy_propagation.cpp
intel: Rename gen_device prefix to intel_device
2021-04-20 20:06:33 +00:00
brw_fs_cse.cpp
intel/fs: Use BRW_OPCODE_HALT for discards
2020-12-01 16:19:08 -06:00
brw_fs_dead_code_eliminate.cpp
intel/compiler: Update block IPs once in dead_code_eliminate
2021-07-14 09:57:01 -07:00
brw_fs_generator.cpp
intel/compiler: Add id parameter to shader_debug_log callback
2021-08-01 23:58:08 +00:00
brw_fs_live_variables.cpp
intel/compiler: Silence unused parameter warning in fs_live_variables::setup_one_read
2020-04-17 08:21:40 -07:00
brw_fs_live_variables.h
intel: Rename gen_device prefix to intel_device
2021-04-20 20:06:33 +00:00
brw_fs_lower_pack.cpp
intel/compiler: Pass detailed dependency classes to invalidate_analysis()
2020-03-06 10:20:39 -08:00
brw_fs_lower_regioning.cpp
intel/fs: make sure shuffle is lowered to supported types
2021-05-22 21:55:33 +00:00
brw_fs_nir.cpp
nir: Suffix all the MCS texture stuff _intel
2021-07-23 15:53:57 +00:00
brw_fs_reg_allocate.cpp
intel/fs: Implement spilling on XeHP
2021-06-25 00:18:29 +00:00
brw_fs_register_coalesce.cpp
intel/compiler: Update block IPs once in register_coalesce
2021-07-14 09:57:04 -07:00
brw_fs_saturate_propagation.cpp
intel/compiler/fs: Switch liveness analysis to IR analysis framework
2020-03-06 10:20:57 -08:00
brw_fs_scoreboard.cpp
intel/fs: Add SWSB dependency annotations for cross-pipeline WaR data hazards on XeHP+.
2021-06-23 07:34:22 +00:00
brw_fs_sel_peephole.cpp
intel/compiler: Don't create 64-bit src1 immediates in opt_peephole_sel
2020-04-23 00:53:14 +00:00
brw_fs_validate.cpp
intel: disable FS IR validation in release mode.
2018-10-15 18:10:27 -07:00
brw_fs_visitor.cpp
intel/fs: Handle non-perspective-correct interpolation on gen4-5
2021-06-03 02:36:17 +00:00
brw_fs.cpp
intel/compiler: Add id parameter to shader_perf_log callback
2021-08-01 23:58:08 +00:00
brw_fs.h
intel/fs: use stack for temporary array
2021-06-28 09:44:40 +00:00
brw_gfx_ver_enum.h
intel: Rename gen enum to gfx_ver
2021-04-20 20:06:34 +00:00
brw_inst.h
intel: Fix alignment and line wrapping due to gen_device renaming
2021-04-20 20:06:33 +00:00
brw_interpolation_map.c
intel: Rename genx keyword to gfxx in source files
2021-04-02 18:33:07 +00:00
brw_ir_allocator.h
intel/ir: Don't allow allocating zero registers
2018-12-11 21:26:23 -06:00
brw_ir_analysis.h
intel/compiler: use C++ template instead of preprocessor
2020-11-03 10:42:29 +00:00
brw_ir_fs.h
intel/fs: use the final destination type for regioning restrictions
2021-05-12 21:19:11 +00:00
brw_ir_performance.cpp
intel/compiler: Add support for ternary add instruction on XeHP
2021-07-16 15:59:56 +00:00
brw_ir_performance.h
intel/ir: Import shader performance analysis pass.
2020-04-28 23:01:03 -07:00
brw_ir_vec4.h
intel: Fix alignment and line wrapping due to gen_device renaming
2021-04-20 20:06:33 +00:00
brw_ir.h
intel/compiler: Add the ability to defer IP updates in backend_instruction::remove
2021-07-14 09:56:46 -07:00
brw_nir_analyze_boolean_resolves.c
intel/fs: Mark source 0 of bcsel as needing Boolean resolve
2019-06-11 12:12:07 -07:00
brw_nir_analyze_ubo_ranges.c
intel/nir,i965: Move HW generation check for UBO pushing to i965
2021-06-03 05:12:33 +00:00
brw_nir_attribute_workarounds.c
nir: Make nir_ssa_def_rewrite_uses_after take an SSA value
2021-03-08 16:59:55 +00:00
brw_nir_clamp_image_1d_2d_array_sizes.c
intel: Rename GEN:BUG:### to Wa_###
2021-04-02 18:33:07 +00:00
brw_nir_lower_alpha_to_coverage.c
intel/nir: Clean up lower_alpha_to_coverage a bit
2020-08-29 16:41:05 +00:00
brw_nir_lower_conversions.c
nir: Make nir_ssa_def_rewrite_uses take an SSA value
2021-03-08 16:59:55 +00:00
brw_nir_lower_cs_intrinsics.c
nir: Move workgroup_size and workgroup_variable_size into common shader_info
2021-06-08 09:23:55 -07:00
brw_nir_lower_intersection_shader.c
intel: Rename gen_device prefix to intel_device
2021-04-20 20:06:33 +00:00
brw_nir_lower_mem_access_bit_sizes.c
nir: Drop nir_ssa_def::name and nir_register::name
2021-07-08 17:34:41 +00:00
brw_nir_lower_rt_intrinsics.c
nir: use a more fitting index for btd_stack_push_intel
2021-06-22 21:09:25 +00:00
brw_nir_lower_scoped_barriers.c
intel/compiler: use intrinsic builders
2021-01-06 14:34:41 +00:00
brw_nir_lower_shader_calls.c
nir: drop the btd_resume_intel intrinsic
2021-06-22 21:09:25 +00:00
brw_nir_lower_storage_image.c
intel/compiler: Lower cube image sizes using nir_lower_image()
2021-07-21 11:34:49 -07:00
brw_nir_opt_peephole_ffma.c
nir: Drop nir_ssa_def::name and nir_register::name
2021-07-08 17:34:41 +00:00
brw_nir_rt_builder.h
nir: drop the btd_resume_intel intrinsic
2021-06-22 21:09:25 +00:00
brw_nir_rt.c
nir: Move workgroup_size and workgroup_variable_size into common shader_info
2021-06-08 09:23:55 -07:00
brw_nir_rt.h
intel/rt: switch to common pass for shader calls lowering
2021-06-22 21:09:25 +00:00
brw_nir_tcs_workarounds.c
intel: Rename Genx keyword to Gfxx
2021-04-02 18:33:07 +00:00
brw_nir_trig_workarounds.py
intel/nir: do not apply the fsin and fcos trig workarounds for consts
2019-09-17 23:39:18 +03:00
brw_nir.c
nir/lower_tex: Rework invalid implicit LOD lowering
2021-07-23 15:53:57 +00:00
brw_nir.h
intel/compiler: Rename brw_nir_lower_image_load_store to brw_nir_lower_storage_image
2021-07-21 11:02:15 -07:00
brw_packed_float.c
intel/compiler: Cast to target type before shifting left
2019-10-24 16:19:23 +02:00
brw_predicated_break.cpp
intel/compiler: Pass detailed dependency classes to invalidate_analysis()
2020-03-06 10:20:39 -08:00
brw_reg_type.c
intel: Rename gen_device prefix to intel_device
2021-04-20 20:06:33 +00:00
brw_reg_type.h
intel/compiler: document register types
2021-07-12 13:27:41 +00:00
brw_reg.h
intel/compiler: document register types
2021-07-12 13:27:41 +00:00
brw_rt.h
intel: Rename gen_device prefix to intel_device
2021-04-20 20:06:33 +00:00
brw_schedule_instructions.cpp
intel/compiler: Track latency/perf of LSC fences
2021-07-12 11:39:03 +00:00
brw_shader.cpp
intel/compiler: Add support for ternary add instruction on XeHP
2021-07-16 15:59:56 +00:00
brw_shader.h
intel/vec4: Add support for UBO pushing
2021-05-19 14:38:13 +00:00
brw_vec4_builder.h
intel: Rename Genx keyword to Gfxx
2021-04-02 18:33:07 +00:00
brw_vec4_cmod_propagation.cpp
intel/compiler: Pass detailed dependency classes to invalidate_analysis()
2020-03-06 10:20:39 -08:00
brw_vec4_copy_propagation.cpp
intel: Rename gen_device prefix to intel_device
2021-04-20 20:06:33 +00:00
brw_vec4_cse.cpp
i965/vec4: Ignore swizzle of VGRF for use by var_range_end()
2020-05-20 20:19:18 +00:00
brw_vec4_dead_code_eliminate.cpp
intel/compiler/vec4: Switch liveness analysis to IR analysis framework
2020-03-06 10:20:59 -08:00
brw_vec4_generator.cpp
intel/compiler: Add id parameter to shader_debug_log callback
2021-08-01 23:58:08 +00:00
brw_vec4_gs_nir.cpp
nir: Add ability to count emitted GS primitives.
2020-10-09 15:26:14 +02:00
brw_vec4_gs_visitor.cpp
intel/gfx6: move xfb_setup outside the gs compiler into the driver.
2021-06-03 04:05:07 +00:00
brw_vec4_gs_visitor.h
intel/compiler: Make visitors take debug_enabled as a parameter
2021-03-24 23:18:46 +00:00
brw_vec4_live_variables.cpp
intel/compiler: Drop invalidate_live_intervals()
2020-03-06 10:21:01 -08:00
brw_vec4_live_variables.h
intel/compiler/vec4: Switch liveness analysis to IR analysis framework
2020-03-06 10:20:59 -08:00
brw_vec4_nir.cpp
glsl: Delete lower_texture_projection
2021-07-13 14:06:33 +00:00
brw_vec4_reg_allocate.cpp
intel/vec4: Use ra_alloc_contig_reg_class() to reduce RA overhead.
2021-06-04 19:08:57 +00:00
brw_vec4_surface_builder.cpp
intel/vec4: Remove all support for Gen8+ [v2]
2020-09-28 11:43:10 -07:00
brw_vec4_surface_builder.h
intel/vec4: Drop dead code for handling typed surface messages
2019-02-28 16:58:20 -06:00
brw_vec4_tcs.cpp
intel: Rename gen_device prefix to intel_device
2021-04-20 20:06:33 +00:00
brw_vec4_tcs.h
intel/compiler: remove unused member 'input_vue_map'
2021-04-08 18:20:10 +00:00
brw_vec4_tes.cpp
intel: Rename files with gen_debug prefix
2021-04-20 20:06:33 +00:00
brw_vec4_tes.h
intel/compiler: Make visitors take debug_enabled as a parameter
2021-03-24 23:18:46 +00:00
brw_vec4_visitor.cpp
i965: Use nir_lower_passthrough_edgeflags
2021-06-11 21:19:06 +00:00
brw_vec4_vs_visitor.cpp
intel: Rename files with gen_debug prefix
2021-04-20 20:06:33 +00:00
brw_vec4_vs.h
intel/compiler: Make visitors take debug_enabled as a parameter
2021-03-24 23:18:46 +00:00
brw_vec4.cpp
intel/compiler: Add id parameter to shader_perf_log callback
2021-08-01 23:58:08 +00:00
brw_vec4.h
intel/vec4: Set up push ranges before we emit any code
2021-05-19 14:38:13 +00:00
brw_vue_map.c
intel: Rename gen_device prefix to intel_device
2021-04-20 20:06:33 +00:00
brw_wm_iz.cpp
intel: Rename genx keyword to gfxx in source files
2021-04-02 18:33:07 +00:00
gfx6_gs_visitor.cpp
intel/gfx6: move xfb_setup outside the gs compiler into the driver.
2021-06-03 04:05:07 +00:00
gfx6_gs_visitor.h
intel/gfx6: move xfb_setup outside the gs compiler into the driver.
2021-06-03 04:05:07 +00:00
meson.build
intel/compiler: Rename brw_nir_lower_image_load_store to brw_nir_lower_storage_image
2021-07-21 11:02:15 -07:00
test_eu_compact.cpp
intel: Rename eu compact instruction tests
2021-04-20 20:06:34 +00:00
test_eu_validate.cpp
intel: simplify is_haswell checks, part 1
2021-05-17 09:46:45 +00:00
test_fs_cmod_propagation.cpp
intel: Rename gen_device prefix to intel_device
2021-04-20 20:06:33 +00:00
test_fs_copy_propagation.cpp
intel: Rename gen_device prefix to intel_device
2021-04-20 20:06:33 +00:00
test_fs_saturate_propagation.cpp
intel: Rename gen_device prefix to intel_device
2021-04-20 20:06:33 +00:00
test_fs_scoreboard.cpp
intel: Rename gen_device prefix to intel_device
2021-04-20 20:06:33 +00:00
test_vec4_cmod_propagation.cpp
intel: Rename gen_device prefix to intel_device
2021-04-20 20:06:33 +00:00
test_vec4_copy_propagation.cpp
intel: Rename gen_device prefix to intel_device
2021-04-20 20:06:33 +00:00
test_vec4_dead_code_eliminate.cpp
intel: Rename gen_device prefix to intel_device
2021-04-20 20:06:33 +00:00
test_vec4_register_coalesce.cpp
intel: Rename gen_device prefix to intel_device
2021-04-20 20:06:33 +00:00
test_vf_float_conversions.cpp
…