41623be20e
Otherwise a smaller type may be promoted to int, which can hit undefined
behaviour:
../src/intel/compiler/brw_packed_float.c:66:17: runtime error: left shift of 128 by 24 places cannot be represented in type 'int'
#0 0x5604a03969aa in brw_vf_to_float ../src/intel/compiler/brw_packed_float.c:66
#1 0x5604a0391305 in vf_float_conversion_test_test_vf_to_float_Test::TestBody() ../src/intel/compiler/test_vf_float_conversions.cpp:70
#2 0x5604a041a323 in void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) ../src/gtest/src/gtest.cc:2402
#3 0x5604a0405c31 in void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) ../src/gtest/src/gtest.cc:2438
#4 0x5604a03ab03b in testing::Test::Run() ../src/gtest/src/gtest.cc:2474
#5 0x5604a03ad714 in testing::TestInfo::Run() ../src/gtest/src/gtest.cc:2656
#6 0x5604a03afea2 in testing::TestCase::Run() ../src/gtest/src/gtest.cc:2774
#7 0x5604a03cb87c in testing::internal::UnitTestImpl::RunAllTests() ../src/gtest/src/gtest.cc:4649
#8 0x5604a041df3c in bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) ../src/gtest/src/gtest.cc:2402
#9 0x5604a0409609 in bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) ../src/gtest/src/gtest.cc:2438
#10 0x5604a03c2e9e in testing::UnitTest::Run() ../src/gtest/src/gtest.cc:4257
#11 0x5604a0442d57 in RUN_ALL_TESTS() ../src/gtest/include/gtest/gtest.h:2233
#12 0x5604a0442c17 in main ../src/gtest/src/gtest_main.cc:37
#13 0x7f9a1983dbba in __libc_start_main ../csu/libc-start.c:308
#14 0x5604a0390d89 in _start (/home/daenzer/src/mesa-git/mesa/build-amd64-sanitize/src/intel/compiler/vf_float_conversions+0x8dd89)
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net>
Reviewed-by: Adam Jackson <ajax@redhat.com>
76 lines
2.2 KiB
C
76 lines
2.2 KiB
C
/*
|
|
* Copyright © 2014 Intel Corporation
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person obtaining a
|
|
* copy of this software and associated documentation files (the "Software"),
|
|
* to deal in the Software without restriction, including without limitation
|
|
* the rights to use, copy, modify, merge, publish, distribute, sublicense,
|
|
* and/or sell copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following conditions:
|
|
*
|
|
* The above copyright notice and this permission notice (including the next
|
|
* paragraph) shall be included in all copies or substantial portions of the
|
|
* Software.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
|
|
* IN THE SOFTWARE.
|
|
*/
|
|
#include "brw_reg.h"
|
|
|
|
union fu {
|
|
float f;
|
|
unsigned u;
|
|
struct {
|
|
unsigned mantissa:23;
|
|
unsigned exponent:8;
|
|
unsigned sign:1;
|
|
} s;
|
|
};
|
|
|
|
int
|
|
brw_float_to_vf(float f)
|
|
{
|
|
union fu fu = { .f = f };
|
|
|
|
/* ±0.0f is special cased. */
|
|
if (f == 0.0f)
|
|
return fu.s.sign << 7;
|
|
|
|
unsigned mantissa = fu.s.mantissa >> (23 - 4);
|
|
unsigned exponent = fu.s.exponent - (127 - 3);
|
|
unsigned vf = (fu.s.sign << 7) | (exponent << 4) | mantissa;
|
|
|
|
/* 0.125 would have had the same representation as 0.0, so reject it. */
|
|
if ((vf & 0x7f) == 0)
|
|
return -1;
|
|
|
|
/* Make sure the mantissa fits in 4-bits and the exponent in 3-bits. */
|
|
if (fu.u & 0x7ffff || exponent > 7)
|
|
return -1;
|
|
|
|
return vf;
|
|
}
|
|
|
|
float
|
|
brw_vf_to_float(unsigned char vf)
|
|
{
|
|
union fu fu;
|
|
|
|
/* ±0.0f is special cased. */
|
|
if (vf == 0x00 || vf == 0x80) {
|
|
fu.u = (unsigned)vf << 24;
|
|
return fu.f;
|
|
}
|
|
|
|
fu.s.sign = vf >> 7;
|
|
fu.s.exponent = ((vf & 0x70) >> 4) + (127 - 3);
|
|
fu.s.mantissa = (vf & 0xf) << (23 - 4);
|
|
|
|
return fu.f;
|
|
}
|