
In some jobs, such as https://gitlab.freedesktop.org/gallo/mesa/-/jobs/24904100, the kmsg is interleaved with stderr/stdout in serial console, making it difficult to confidently find the log messages to detect when the DUT is booting, when the DUT is running etc. Luckily, LAVA sends redundant messages about their signals. We can use them to mitigate the chance of missing an interleaved message by being more open to different messages, using the regex on both `debug` and `target` LAVA log levels. Signed-off-by: Guilherme Gallo <guilherme.gallo@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16323>
309 lines
9.6 KiB
Python
309 lines
9.6 KiB
Python
#!/usr/bin/env python3
|
|
#
|
|
# Copyright (C) 2022 Collabora Limited
|
|
# Author: Guilherme Gallo <guilherme.gallo@collabora.com>
|
|
#
|
|
# Permission is hereby granted, free of charge, to any person obtaining a
|
|
# copy of this software and associated documentation files (the "Software"),
|
|
# to deal in the Software without restriction, including without limitation
|
|
# the rights to use, copy, modify, merge, publish, distribute, sublicense,
|
|
# and/or sell copies of the Software, and to permit persons to whom the
|
|
# Software is furnished to do so, subject to the following conditions:
|
|
#
|
|
# The above copyright notice and this permission notice (including the next
|
|
# paragraph) shall be included in all copies or substantial portions of the
|
|
# Software.
|
|
#
|
|
# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
# THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
|
|
# SOFTWARE.
|
|
|
|
from datetime import datetime, timedelta
|
|
|
|
import pytest
|
|
import yaml
|
|
from lava.exceptions import MesaCITimeoutError
|
|
from lava.utils.lava_log import (
|
|
GitlabSection,
|
|
LogFollower,
|
|
LogSectionType,
|
|
fix_lava_color_log,
|
|
fix_lava_gitlab_section_log,
|
|
hide_sensitive_data,
|
|
)
|
|
|
|
from ..lava.helpers import create_lava_yaml_msg, does_not_raise
|
|
|
|
GITLAB_SECTION_SCENARIOS = {
|
|
"start collapsed": (
|
|
"start",
|
|
True,
|
|
f"\x1b[0Ksection_start:mock_date:my_first_section[collapsed=true]\r\x1b[0K{GitlabSection.colour}my_header\x1b[0m",
|
|
),
|
|
"start non_collapsed": (
|
|
"start",
|
|
False,
|
|
f"\x1b[0Ksection_start:mock_date:my_first_section\r\x1b[0K{GitlabSection.colour}my_header\x1b[0m",
|
|
),
|
|
"end collapsed": (
|
|
"end",
|
|
True,
|
|
"\x1b[0Ksection_end:mock_date:my_first_section\r\x1b[0K",
|
|
),
|
|
"end non_collapsed": (
|
|
"end",
|
|
False,
|
|
"\x1b[0Ksection_end:mock_date:my_first_section\r\x1b[0K",
|
|
),
|
|
}
|
|
|
|
@pytest.mark.parametrize(
|
|
"method, collapsed, expectation",
|
|
GITLAB_SECTION_SCENARIOS.values(),
|
|
ids=GITLAB_SECTION_SCENARIOS.keys(),
|
|
)
|
|
def test_gitlab_section(method, collapsed, expectation):
|
|
gs = GitlabSection(
|
|
id="my_first_section",
|
|
header="my_header",
|
|
type=LogSectionType.TEST_CASE,
|
|
start_collapsed=collapsed,
|
|
)
|
|
gs.get_timestamp = lambda x: "mock_date"
|
|
gs.start()
|
|
result = getattr(gs, method)()
|
|
assert result == expectation
|
|
|
|
|
|
def test_gl_sections():
|
|
lines = [
|
|
{
|
|
"dt": datetime.now(),
|
|
"lvl": "debug",
|
|
"msg": "Received signal: <STARTRUN> 0_mesa 5971831_1.3.2.3.1",
|
|
},
|
|
# Redundant log message which triggers the same Gitlab Section, it
|
|
# should be ignored, unless the id is different
|
|
{
|
|
"dt": datetime.now(),
|
|
"lvl": "target",
|
|
"msg": "[ 7.778836] <LAVA_SIGNAL_STARTRUN 0_mesa 5971831_1.3.2.3.1>",
|
|
},
|
|
{
|
|
"dt": datetime.now(),
|
|
"lvl": "debug",
|
|
"msg": "Received signal: <STARTTC> mesa-ci_iris-kbl-traces",
|
|
},
|
|
# Another redundant log message
|
|
{
|
|
"dt": datetime.now(),
|
|
"lvl": "target",
|
|
"msg": "[ 16.997829] <LAVA_SIGNAL_STARTTC mesa-ci_iris-kbl-traces>",
|
|
},
|
|
{
|
|
"dt": datetime.now(),
|
|
"lvl": "target",
|
|
"msg": "<LAVA_SIGNAL_ENDTC mesa-ci_iris-kbl-traces>",
|
|
},
|
|
]
|
|
lf = LogFollower()
|
|
for line in lines:
|
|
lf.manage_gl_sections(line)
|
|
|
|
parsed_lines = lf.flush()
|
|
assert "section_start" in parsed_lines[0]
|
|
assert "collapsed=true" not in parsed_lines[0]
|
|
assert "section_end" in parsed_lines[1]
|
|
assert "section_start" in parsed_lines[2]
|
|
assert "collapsed=true" not in parsed_lines[2]
|
|
assert "section_end" in parsed_lines[3]
|
|
assert "section_start" in parsed_lines[4]
|
|
assert "collapsed=true" in parsed_lines[4]
|
|
|
|
|
|
def test_log_follower_flush():
|
|
lines = [
|
|
{
|
|
"dt": datetime.now(),
|
|
"lvl": "debug",
|
|
"msg": "Received signal: <STARTTC> mesa-ci_iris-kbl-traces",
|
|
},
|
|
{
|
|
"dt": datetime.now(),
|
|
"lvl": "target",
|
|
"msg": "<LAVA_SIGNAL_ENDTC mesa-ci_iris-kbl-traces>",
|
|
},
|
|
]
|
|
lf = LogFollower()
|
|
lf.feed(lines)
|
|
parsed_lines = lf.flush()
|
|
empty = lf.flush()
|
|
lf.feed(lines)
|
|
repeated_parsed_lines = lf.flush()
|
|
|
|
assert parsed_lines
|
|
assert not empty
|
|
assert repeated_parsed_lines
|
|
|
|
|
|
SENSITIVE_DATA_SCENARIOS = {
|
|
"no sensitive data tagged": (
|
|
["bla bla", "mytoken: asdkfjsde1341=="],
|
|
["bla bla", "mytoken: asdkfjsde1341=="],
|
|
"HIDEME",
|
|
),
|
|
"sensitive data tagged": (
|
|
["bla bla", "mytoken: asdkfjsde1341== # HIDEME"],
|
|
["bla bla"],
|
|
"HIDEME",
|
|
),
|
|
"sensitive data tagged with custom word": (
|
|
["bla bla", "mytoken: asdkfjsde1341== # DELETETHISLINE", "third line"],
|
|
["bla bla", "third line"],
|
|
"DELETETHISLINE",
|
|
),
|
|
}
|
|
|
|
|
|
@pytest.mark.parametrize(
|
|
"input, expectation, tag",
|
|
SENSITIVE_DATA_SCENARIOS.values(),
|
|
ids=SENSITIVE_DATA_SCENARIOS.keys(),
|
|
)
|
|
def test_hide_sensitive_data(input, expectation, tag):
|
|
yaml_data = yaml.safe_dump(input)
|
|
yaml_result = hide_sensitive_data(yaml_data, tag)
|
|
result = yaml.safe_load(yaml_result)
|
|
|
|
assert result == expectation
|
|
|
|
|
|
COLOR_MANGLED_SCENARIOS = {
|
|
"Mangled error message at target level": (
|
|
create_lava_yaml_msg(msg="[0m[0m[31mERROR - dEQP error: ", lvl="target"),
|
|
"\x1b[0m\x1b[0m\x1b[31mERROR - dEQP error: ",
|
|
),
|
|
"Mangled pass message at target level": (
|
|
create_lava_yaml_msg(
|
|
msg="[0mPass: 26718, ExpectedFail: 95, Skip: 25187, Duration: 8:18, Remaining: 13",
|
|
lvl="target",
|
|
),
|
|
"\x1b[0mPass: 26718, ExpectedFail: 95, Skip: 25187, Duration: 8:18, Remaining: 13",
|
|
),
|
|
"Mangled error message with bold formatting at target level": (
|
|
create_lava_yaml_msg(msg="[1;31mReview the image changes...", lvl="target"),
|
|
"\x1b[1;31mReview the image changes...",
|
|
),
|
|
"Mangled error message with high intensity background at target level": (
|
|
create_lava_yaml_msg(msg="[100mReview the image changes...", lvl="target"),
|
|
"\x1b[100mReview the image changes...",
|
|
),
|
|
"Mangled error message with underline+bg color+fg color at target level": (
|
|
create_lava_yaml_msg(msg="[4;41;97mReview the image changes...", lvl="target"),
|
|
"\x1b[4;41;97mReview the image changes...",
|
|
),
|
|
"Bad input for color code.": (
|
|
create_lava_yaml_msg(
|
|
msg="[4;97 This message is missing the `m`.", lvl="target"
|
|
),
|
|
"[4;97 This message is missing the `m`.",
|
|
),
|
|
}
|
|
|
|
|
|
@pytest.mark.parametrize(
|
|
"message, fixed_message",
|
|
COLOR_MANGLED_SCENARIOS.values(),
|
|
ids=COLOR_MANGLED_SCENARIOS.keys(),
|
|
)
|
|
def test_fix_lava_color_log(message, fixed_message):
|
|
fix_lava_color_log(message)
|
|
|
|
assert message["msg"] == fixed_message
|
|
|
|
|
|
GITLAB_SECTION_MANGLED_SCENARIOS = {
|
|
"Mangled section_start at target level": (
|
|
create_lava_yaml_msg(
|
|
msg="[0Ksection_start:1652658415:deqp[collapsed=false][0Kdeqp-runner",
|
|
lvl="target",
|
|
),
|
|
"\x1b[0Ksection_start:1652658415:deqp[collapsed=false]\r\x1b[0Kdeqp-runner",
|
|
),
|
|
"Mangled section_start at target level with header with spaces": (
|
|
create_lava_yaml_msg(
|
|
msg="[0Ksection_start:1652658415:deqp[collapsed=false][0Kdeqp runner stats",
|
|
lvl="target",
|
|
),
|
|
"\x1b[0Ksection_start:1652658415:deqp[collapsed=false]\r\x1b[0Kdeqp runner stats",
|
|
),
|
|
"Mangled section_end at target level": (
|
|
create_lava_yaml_msg(
|
|
msg="[0Ksection_end:1652658415:test_setup[0K",
|
|
lvl="target",
|
|
),
|
|
"\x1b[0Ksection_end:1652658415:test_setup\r\x1b[0K",
|
|
),
|
|
}
|
|
|
|
|
|
@pytest.mark.parametrize(
|
|
"message, fixed_message",
|
|
GITLAB_SECTION_MANGLED_SCENARIOS.values(),
|
|
ids=GITLAB_SECTION_MANGLED_SCENARIOS.keys(),
|
|
)
|
|
def test_fix_lava_gitlab_section_log(message, fixed_message):
|
|
fix_lava_gitlab_section_log(message)
|
|
|
|
assert message["msg"] == fixed_message
|
|
|
|
|
|
WATCHDOG_SCENARIOS = {
|
|
"1 second before timeout": ({"seconds": -1}, does_not_raise()),
|
|
"1 second after timeout": ({"seconds": 1}, pytest.raises(MesaCITimeoutError)),
|
|
}
|
|
|
|
|
|
@pytest.mark.parametrize(
|
|
"timedelta_kwargs, exception",
|
|
WATCHDOG_SCENARIOS.values(),
|
|
ids=WATCHDOG_SCENARIOS.keys(),
|
|
)
|
|
def test_log_follower_watchdog(frozen_time, timedelta_kwargs, exception):
|
|
lines = [
|
|
{
|
|
"dt": datetime.now(),
|
|
"lvl": "debug",
|
|
"msg": "Received signal: <STARTTC> mesa-ci_iris-kbl-traces",
|
|
},
|
|
]
|
|
td = {LogSectionType.TEST_CASE: timedelta(minutes=1)}
|
|
lf = LogFollower(timeout_durations=td)
|
|
lf.feed(lines)
|
|
frozen_time.tick(
|
|
lf.timeout_durations[LogSectionType.TEST_CASE] + timedelta(**timedelta_kwargs)
|
|
)
|
|
lines = [create_lava_yaml_msg()]
|
|
with exception:
|
|
lf.feed(lines)
|
|
|
|
|
|
GITLAB_SECTION_ID_SCENARIOS = [
|
|
("a-good_name", "a-good_name"),
|
|
("spaces are not welcome", "spaces-are-not-welcome"),
|
|
("abc:amd64 1/3", "abc-amd64-1-3"),
|
|
]
|
|
|
|
|
|
@pytest.mark.parametrize("case_name, expected_id", GITLAB_SECTION_ID_SCENARIOS)
|
|
def test_gitlab_section_id(case_name, expected_id):
|
|
gl = GitlabSection(
|
|
id=case_name, header=case_name, type=LogSectionType.LAVA_POST_PROCESSING
|
|
)
|
|
|
|
assert gl.id == expected_id
|