13ea7db760
I'm bringing up freedreno Vulkan on an Android phone, and my pains are
exactly what Chad said when working on Intel's vulkan for Android in
aa716db0f6 ("intel: Add simple logging façade for Android (v2)"):
On Android, stdio goes to /dev/null. On Android, remote gdb is even
more painful than the usual remote gdb. On Android, nothing works like
you expect and debugging is hell. I need logging.
This patch introduces a small, simple logging API that can easily wrap
Android's API. On non-Android platforms, this logger does nothing
fancy. It follows the time-honored Unix tradition of spewing
everything to stderr with minimal fuss.
My goal here is not perfection. My goal is to make a minimal, clean API,
that people hate merely a little instead of a lot, and that's good
enough to let me bring up Android Vulkan. And it needs to be fast,
which means it must be small. No one wants to their game to miss frames
while aiming a flaming bow into the jaws of an angry robot t-rex, and
thus become t-rex breakfast, because some fool had too much fun desiging
a bloated, ideal logging API.
Compared to trusty fprintf, _mesa_log[ewi]() is actually usable on
Android. Compared to os_log_message(), this has different error levels
and supports format arguments.
The only code change in the move is wrapping flockfile/funlockfile in
!DETECT_OS_WINDOWS, since mingw32 doesn't have it. Windows likely wants
different logging code, anyway.
Reviewed-by: Tapani Pälli <tapani.palli@intel.com>
Reviewed-by: Kristian H. Kristensen <hoegsberg@google.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6806>
93 lines
2.5 KiB
C
93 lines
2.5 KiB
C
/*
|
|
* Copyright © 2017 Google, Inc.
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person obtaining a
|
|
* copy of this software and associated documentation files (the "Software"),
|
|
* to deal in the Software without restriction, including without limitation
|
|
* the rights to use, copy, modify, merge, publish, distribute, sublicense,
|
|
* and/or sell copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following conditions:
|
|
*
|
|
* The above copyright notice and this permission notice (including the next
|
|
* paragraph) shall be included in all copies or substantial portions of the
|
|
* Software.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
|
|
* IN THE SOFTWARE.
|
|
*/
|
|
|
|
#include <stdarg.h>
|
|
|
|
#ifdef ANDROID
|
|
#include <android/log.h>
|
|
#else
|
|
#include <stdio.h>
|
|
#endif
|
|
|
|
#include "util/detect_os.h"
|
|
#include "util/log.h"
|
|
|
|
#ifdef ANDROID
|
|
static inline android_LogPriority
|
|
level_to_android(enum mesa_log_level l)
|
|
{
|
|
switch (l) {
|
|
case MESA_LOG_ERROR: return ANDROID_LOG_ERROR;
|
|
case MESA_LOG_WARN: return ANDROID_LOG_WARN;
|
|
case MESA_LOG_INFO: return ANDROID_LOG_INFO;
|
|
case MESA_LOG_DEBUG: return ANDROID_LOG_DEBUG;
|
|
}
|
|
|
|
unreachable("bad mesa_log_level");
|
|
}
|
|
#endif
|
|
|
|
#ifndef ANDROID
|
|
static inline const char *
|
|
level_to_str(enum mesa_log_level l)
|
|
{
|
|
switch (l) {
|
|
case MESA_LOG_ERROR: return "error";
|
|
case MESA_LOG_WARN: return "warning";
|
|
case MESA_LOG_INFO: return "info";
|
|
case MESA_LOG_DEBUG: return "debug";
|
|
}
|
|
|
|
unreachable("bad mesa_log_level");
|
|
}
|
|
#endif
|
|
|
|
void
|
|
mesa_log(enum mesa_log_level level, const char *tag, const char *format, ...)
|
|
{
|
|
va_list va;
|
|
|
|
va_start(va, format);
|
|
mesa_log_v(level, tag, format, va);
|
|
va_end(va);
|
|
}
|
|
|
|
void
|
|
mesa_log_v(enum mesa_log_level level, const char *tag, const char *format,
|
|
va_list va)
|
|
{
|
|
#ifdef ANDROID
|
|
__android_log_vprint(level_to_android(level), tag, format, va);
|
|
#else
|
|
#if !DETECT_OS_WINDOWS
|
|
flockfile(stderr);
|
|
#endif
|
|
fprintf(stderr, "%s: %s: ", tag, level_to_str(level));
|
|
vfprintf(stderr, format, va);
|
|
fprintf(stderr, "\n");
|
|
#if !DETECT_OS_WINDOWS
|
|
funlockfile(stderr);
|
|
#endif
|
|
#endif
|
|
}
|