
util_cpu_detect is an anti-pattern: it relies on callers high up in the call chain initializing a local implementation detail. As a real example, I added: ...a Mali compiler unit test ...that called bi_imm_f16() to construct an FP16 immediate ...that calls _mesa_float_to_half internally ...that calls util_get_cpu_caps internally, but only on x86_64! ...that relies on util_cpu_detect having been called before. As a consequence, this unit test: ...crashes on x86_64 with USE_X86_64_ASM set ...passes on every other architecture ...works on my local arm64 workstation and on my test board ...failed CI which runs on x86_64 ...needed to have a random util_cpu_detect() call sprinkled in. This is a bad design decision. It pollutes the tree with magic, it causes mysterious CI failures especially for non-x86_64 developers, and it is not justified by a micro-optimization. Instead, let's call util_cpu_detect directly from util_get_cpu_caps, avoiding the footgun where it fails to be called. This cleans up Mesa's design, simplifies the tree, and avoids a class of a (possibly platform-specific) failures. To mitigate the added overhead, wrap it all in a (fast) atomic load check and declare the whole thing as ATTRIBUTE_CONST so the compiler will CSE calls to util_cpu_detect. Co-authored-by: Alyssa Rosenzweig <alyssa@collabora.com> Reviewed-by: Marek Olšák <maraeo@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15580>
213 lines
5.9 KiB
C
213 lines
5.9 KiB
C
/**************************************************************************
|
|
*
|
|
* Copyright 2012 Francisco Jerez
|
|
* All Rights Reserved.
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person obtaining a
|
|
* copy of this software and associated documentation files (the
|
|
* "Software"), to deal in the Software without restriction, including
|
|
* without limitation the rights to use, copy, modify, merge, publish,
|
|
* distribute, sub license, and/or sell copies of the Software, and to
|
|
* permit persons to whom the Software is furnished to do so, subject to
|
|
* the following conditions:
|
|
*
|
|
* The above copyright notice and this permission notice (including the
|
|
* next paragraph) shall be included in all copies or substantial portions
|
|
* of the Software.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
|
|
* OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
|
|
* MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT.
|
|
* IN NO EVENT SHALL VMWARE AND/OR ITS SUPPLIERS BE LIABLE FOR
|
|
* ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT,
|
|
* TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE
|
|
* SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
|
|
*
|
|
**************************************************************************/
|
|
|
|
#include "pipe_loader_priv.h"
|
|
|
|
#include "util/u_inlines.h"
|
|
#include "util/u_memory.h"
|
|
#include "util/u_string.h"
|
|
#include "util/u_dl.h"
|
|
#include "util/u_file.h"
|
|
#include "util/xmlconfig.h"
|
|
#include "util/driconf.h"
|
|
|
|
#include <string.h>
|
|
|
|
#ifdef _MSC_VER
|
|
#include <stdlib.h>
|
|
#define PATH_MAX _MAX_PATH
|
|
#endif
|
|
|
|
#define MODULE_PREFIX "pipe_"
|
|
|
|
static int (*backends[])(struct pipe_loader_device **, int) = {
|
|
#ifdef HAVE_LIBDRM
|
|
&pipe_loader_drm_probe,
|
|
#endif
|
|
&pipe_loader_sw_probe
|
|
};
|
|
|
|
const driOptionDescription gallium_driconf[] = {
|
|
#include "driinfo_gallium.h"
|
|
};
|
|
|
|
int
|
|
pipe_loader_probe(struct pipe_loader_device **devs, int ndev)
|
|
{
|
|
int i, n = 0;
|
|
|
|
for (i = 0; i < ARRAY_SIZE(backends); i++)
|
|
n += backends[i](&devs[n], MAX2(0, ndev - n));
|
|
|
|
return n;
|
|
}
|
|
|
|
void
|
|
pipe_loader_release(struct pipe_loader_device **devs, int ndev)
|
|
{
|
|
int i;
|
|
|
|
for (i = 0; i < ndev; i++)
|
|
devs[i]->ops->release(&devs[i]);
|
|
}
|
|
|
|
void
|
|
pipe_loader_base_release(struct pipe_loader_device **dev)
|
|
{
|
|
driDestroyOptionCache(&(*dev)->option_cache);
|
|
driDestroyOptionInfo(&(*dev)->option_info);
|
|
|
|
FREE(*dev);
|
|
*dev = NULL;
|
|
}
|
|
|
|
static driOptionDescription *
|
|
merge_driconf(const driOptionDescription *driver_driconf, unsigned driver_count,
|
|
unsigned *merged_count)
|
|
{
|
|
unsigned gallium_count = ARRAY_SIZE(gallium_driconf);
|
|
driOptionDescription *merged = malloc((driver_count + gallium_count) *
|
|
sizeof(*merged));
|
|
if (!merged) {
|
|
*merged_count = 0;
|
|
return NULL;
|
|
}
|
|
|
|
memcpy(merged, gallium_driconf, sizeof(*merged) * gallium_count);
|
|
memcpy(&merged[gallium_count], driver_driconf, sizeof(*merged) * driver_count);
|
|
|
|
*merged_count = driver_count + gallium_count;
|
|
return merged;
|
|
}
|
|
|
|
/**
|
|
* Ensure that dev->option_cache is initialized appropriately for the driver.
|
|
*
|
|
* This function can be called multiple times.
|
|
*
|
|
* \param dev Device for which options should be loaded.
|
|
*/
|
|
static void
|
|
pipe_loader_load_options(struct pipe_loader_device *dev)
|
|
{
|
|
if (dev->option_info.info)
|
|
return;
|
|
|
|
unsigned driver_count, merged_count;
|
|
const driOptionDescription *driver_driconf =
|
|
dev->ops->get_driconf(dev, &driver_count);
|
|
|
|
const driOptionDescription *merged_driconf =
|
|
merge_driconf(driver_driconf, driver_count, &merged_count);
|
|
driParseOptionInfo(&dev->option_info, merged_driconf, merged_count);
|
|
free((void *)merged_driconf);
|
|
}
|
|
|
|
void
|
|
pipe_loader_config_options(struct pipe_loader_device *dev)
|
|
{
|
|
if (!dev->option_cache.info) {
|
|
driParseConfigFiles(&dev->option_cache, &dev->option_info, 0,
|
|
dev->driver_name, NULL, NULL, NULL, 0, NULL, 0);
|
|
}
|
|
}
|
|
|
|
char *
|
|
pipe_loader_get_driinfo_xml(const char *driver_name)
|
|
{
|
|
unsigned driver_count = 0;
|
|
const driOptionDescription *driver_driconf = NULL;
|
|
|
|
#ifdef HAVE_LIBDRM
|
|
driver_driconf = pipe_loader_drm_get_driconf_by_name(driver_name,
|
|
&driver_count);
|
|
#endif
|
|
|
|
unsigned merged_count;
|
|
const driOptionDescription *merged_driconf =
|
|
merge_driconf(driver_driconf, driver_count, &merged_count);
|
|
free((void *)driver_driconf);
|
|
|
|
char *xml = driGetOptionsXml(merged_driconf, merged_count);
|
|
|
|
free((void *)merged_driconf);
|
|
|
|
return xml;
|
|
}
|
|
|
|
struct pipe_screen *
|
|
pipe_loader_create_screen_vk(struct pipe_loader_device *dev, bool sw_vk)
|
|
{
|
|
struct pipe_screen_config config;
|
|
|
|
pipe_loader_load_options(dev);
|
|
config.options_info = &dev->option_info;
|
|
config.options = &dev->option_cache;
|
|
|
|
return dev->ops->create_screen(dev, &config, sw_vk);
|
|
}
|
|
|
|
struct pipe_screen *
|
|
pipe_loader_create_screen(struct pipe_loader_device *dev)
|
|
{
|
|
return pipe_loader_create_screen_vk(dev, false);
|
|
}
|
|
|
|
struct util_dl_library *
|
|
pipe_loader_find_module(const char *driver_name,
|
|
const char *library_paths)
|
|
{
|
|
struct util_dl_library *lib;
|
|
const char *next;
|
|
char path[PATH_MAX];
|
|
int len, ret;
|
|
|
|
for (next = library_paths; *next; library_paths = next + 1) {
|
|
next = strchrnul(library_paths, ':');
|
|
len = next - library_paths;
|
|
|
|
if (len)
|
|
ret = snprintf(path, sizeof(path), "%.*s/%s%s%s",
|
|
len, library_paths,
|
|
MODULE_PREFIX, driver_name, UTIL_DL_EXT);
|
|
else
|
|
ret = snprintf(path, sizeof(path), "%s%s%s",
|
|
MODULE_PREFIX, driver_name, UTIL_DL_EXT);
|
|
|
|
if (ret > 0 && ret < sizeof(path) && u_file_access(path, 0) != -1) {
|
|
lib = util_dl_open(path);
|
|
if (lib) {
|
|
return lib;
|
|
}
|
|
fprintf(stderr, "ERROR: Failed to load pipe driver at `%s': %s\n",
|
|
path, util_dl_error());
|
|
}
|
|
}
|
|
|
|
return NULL;
|
|
}
|