01ef56a7e4
If we only read 8 bytes from a UBO, we need to use LD_UNIFORM.64 as opposed to LD_UNIFORM.128. In addition to probably being faster, this fixes a buffer overrun manifesting as MMU faults with source ID 0x500/0x600/0x700, visible in WebGL Aquarium. This is essentially the same patch as616394cf31("pan/mdg: Use appropriate sizes for global loads/stores"), only this is for UBOs where that was for SSBOs. Before enabling PACKED_UNIFORMS, this bug was not visible since we could guarantee the UBO size was a multiple of 16. We no longer have that invariant, and in rare cases the last 8 bytes of the last 16-byte slot of a mapped uniform buffer would overrun the BO and trigger a fault, even if the result is unused. Fixes:24d7c413fe("panfrost: Enable packed uniforms.") Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10772>
`Mesa <https://mesa3d.org>`_ - The 3D Graphics Library ====================================================== Source ------ This repository lives at https://gitlab.freedesktop.org/mesa/mesa. Other repositories are likely forks, and code found there is not supported. Build & install --------------- You can find more information in our documentation (`docs/install.rst <https://mesa3d.org/install.html>`_), but the recommended way is to use Meson (`docs/meson.rst <https://mesa3d.org/meson.html>`_): .. code-block:: sh $ mkdir build $ cd build $ meson .. $ sudo ninja install Support ------- Many Mesa devs hang on IRC; if you're not sure which channel is appropriate, you should ask your question on `Freenode's #dri-devel <irc://chat.freenode.net#dri-devel>`_, someone will redirect you if necessary. Remember that not everyone is in the same timezone as you, so it might take a while before someone qualified sees your question. To figure out who you're talking to, or which nick to ping for your question, check out `Who's Who on IRC <https://dri.freedesktop.org/wiki/WhosWho/>`_. The next best option is to ask your question in an email to the mailing lists: `mesa-dev\@lists.freedesktop.org <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>`_ Bug reports ----------- If you think something isn't working properly, please file a bug report (`docs/bugs.rst <https://mesa3d.org/bugs.html>`_). Contributing ------------ Contributions are welcome, and step-by-step instructions can be found in our documentation (`docs/submittingpatches.rst <https://mesa3d.org/submittingpatches.html>`_). Note that Mesa uses gitlab for patches submission, review and discussions.