David Heidelberg
f7cf53a0b1
ci: re-enable shader-db for nouveau
...
As we have separate jobs, failure won't trigger an extra 20m of waiting.
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28648 >
2024-05-24 21:39:57 +00:00
Martin Roukala (né Peres)
addeb5ca9a
radv/ci: add a bunch of flakes
...
Signed-off-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29381 >
2024-05-24 21:05:46 +00:00
Martin Roukala (né Peres)
9a7facc97d
radv+zink/ci: document recent flakes
...
Signed-off-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29381 >
2024-05-24 21:05:46 +00:00
Martin Roukala (né Peres)
946b1027ef
turnip+zink/ci: add more flakes to the expectations
...
Signed-off-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29381 >
2024-05-24 21:05:46 +00:00
Martin Roukala (né Peres)
fed03b9662
turnip/ci: bump the a750_vk timeout
...
We already managed to hit the timeout once, and since the job is manual
anyway, let's bump it generously so as to also allow for more tests
to be added without having to bump the timeout every time.
Signed-off-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29381 >
2024-05-24 21:05:46 +00:00
Martin Roukala (né Peres)
8b6ea47020
turnip/ci: document a missing flake from the a750_vk job
...
Signed-off-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29381 >
2024-05-24 21:05:46 +00:00
Martin Roukala (né Peres)
fb5096eb37
nvk+zink/ci: document more flakes in the ga106
...
It also has the benefit of being a shorter name than the original.
Signed-off-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29381 >
2024-05-24 21:05:46 +00:00
Martin Roukala (né Peres)
1d9092ad49
nvk+zink/ci/ga106: make the expectations codename-specific
...
CI expectations are definitely not portable across different gpu
families, so let's tag them as such to reduce confusion and be more
in line with the rest of the codebase.
Signed-off-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29381 >
2024-05-24 21:05:46 +00:00
Martin Roukala (né Peres)
d0d3924c60
nvk+zink/ci: rename the ga106 jobs to be more in line with RADV
...
It also has the benefit of being a shorter name than the original.
Signed-off-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29381 >
2024-05-24 21:05:46 +00:00
Eric R. Smith
43f9b3b986
glsl: make the xfb varying sort stable
...
qsort is not guaranteed to produce a stable sort, and indeed
in MSVC CRT does not. The xfb varying sort functions were
relying on undefined behavior (that qsort would be stable).
Signed-off-by: Eric R. Smith <eric.smith@collabora.com >
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com >
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29178 >
2024-05-24 17:36:39 +00:00
Eric R. Smith
5102a922e7
glsl: test both inputs when sorting varyings for xfb
...
In the sort functions used to sort varyings in gl_nir_link_varyings,
we were only checking the first input for whether or not it is xfb.
Check both inputs, and also provide a definite order for the xfb vs.
non-xfb varyings (the xfb come last, as the initial sort established).
This fixes a problem encountered on panfrost, where qsort could
mix xfb and non-xfb varyings which started out separate.
Note that the sort is still not stable. We probably should make it
stable, but that is a more extensive change that's handled in a later
commit.
Cc: mesa-stable
Signed-off-by: Eric R. Smith <eric.smith@collabora.com >
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29178 >
2024-05-24 17:36:39 +00:00
Eric Engestrom
485d56ed81
mr-label-maker: label src/vulkan/wsi/ as wsi
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29388 >
2024-05-24 19:12:49 +02:00
Samuel Pitoiset
003d49c0bc
ac,radv,radeonsi: add a function to translate texture data format
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29301 >
2024-05-24 17:04:54 +02:00
Samuel Pitoiset
e1997226da
radv: use PIPE_FORMAT in radv_translate_tex_dataformat()
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29301 >
2024-05-24 17:04:54 +02:00
Samuel Pitoiset
7785a63fc0
amd/common: add ac_gpu_info::has_etc_support
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29301 >
2024-05-24 17:04:54 +02:00
Marek Olšák
ae9331694b
radeonsi: lower NIR resource srcs to descriptors last
...
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29313 >
2024-05-24 13:48:28 +00:00
Marek Olšák
f493d6fb6f
radeonsi: don't lower UBO/SSBOs to descriptors if they are already lowered
...
The next change will depend on this.
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29313 >
2024-05-24 13:48:28 +00:00
Marek Olšák
e1c65ce680
radeonsi/gfx12: fix a regression in si_init_depth_surface
...
si_htile_enabled has an assertion not expecting GFX12
Fixes: d0810d528c
- radeonsi: use the common helper for initializing DS surfaces
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29313 >
2024-05-24 13:48:28 +00:00
Marek Olšák
321cb43c11
radeonsi/gfx12: fix depth bounds register values
...
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29313 >
2024-05-24 13:48:28 +00:00
Marek Olšák
59d7d06828
radeonsi/gfx12: fix a regression in si_set_mutable_tex_desc_fields
...
Fixes: 26cd3a1718
- ac,radv,radeonsi: add a helper to set mutable tex desc fields
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29313 >
2024-05-24 13:48:28 +00:00
Marek Olšák
a548ec7ad4
radeonsi/gfx12: disable CU1 instead of CU0 for GS due to SQTT
...
SQTT captures traces from CU0, so we need to keep it enabled.
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29313 >
2024-05-24 13:48:28 +00:00
Marek Olšák
34be14d957
radeonsi/gfx12: fix incorrect condition for when to do clear_buffer via compute
...
It was missing the requirement that offset % 4 == 0.
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29313 >
2024-05-24 13:48:28 +00:00
Marek Olšák
76b0ad33bc
radeonsi/gfx12: fix the alpha ref value
...
This was missed when the code was refactored.
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29313 >
2024-05-24 13:48:28 +00:00
Marek Olšák
3ab0e18db4
radeonsi: vectorize loads/store after ABI lowering and optimizations
...
This results in slightly better code.
SGPRs: 3552 -> 3608 (1.58 %)
VGPRs: 1988 -> 2020 (1.61 %)
Code Size: 178036 -> 177664 (-0.21 %) bytes
Max Waves: 1136 -> 1136 (0.00 %)
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29313 >
2024-05-24 13:48:28 +00:00
Marek Olšák
35c5435eae
ac/llvm: fix incorrect parameter type in llvm.amdgcn.s.nop
...
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29313 >
2024-05-24 13:48:28 +00:00
Marek Olšák
ad07ea3162
amd: enable 32B minimum DCC block size for gfx1151
...
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29313 >
2024-05-24 13:48:28 +00:00
Marek Olšák
cf4eb41540
amd: add more gfx11 APUs
...
Acked-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29313 >
2024-05-24 13:48:28 +00:00
Marek Olšák
7650127040
amd: update addrlib
...
Acked-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29313 >
2024-05-24 13:48:28 +00:00
Natanael Copa
0274518615
nir/opt_varyings: reduce stack usage
...
Avoid put a huge struct on stack to fix a stack overflow on musl libc.
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/10988
Fixes: c66967b5cb
(nir: add nir_opt_varyings, new pass optimizing and compacting varyings)
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29375 >
2024-05-24 13:15:33 +00:00
Valentine Burley
f7a262cd6d
freedreno/devices: Fix indentation for Adreno A32
...
Adjust indentation to match other entries.
Fixes: cd7da3a807
("freedreno/devices: Add support for Adreno A32 (G3x Gen 2)")
Signed-off-by: Valentine Burley <valentine.burley@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29347 >
2024-05-24 12:21:07 +00:00
Valentine Burley
674d5b54bf
tu: Expose VK_EXT_nested_command_buffer
...
Signed-off-by: Valentine Burley <valentine.burley@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29347 >
2024-05-24 12:21:07 +00:00
Samuel Pitoiset
cd5f980d51
ac,radv,radeonsi: move ZRANGE_PRECISION to mutable DS fields
...
The DS surfaces are now completely configured in common code.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29349 >
2024-05-24 11:48:32 +00:00
Samuel Pitoiset
332a06903d
ac,radv,radeonsi: a function that sets mutable DS surface fields
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29349 >
2024-05-24 11:48:32 +00:00
Samuel Pitoiset
1a08fa6150
ac,radv,radeonsi: add function to get the number of ZPLANES
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29349 >
2024-05-24 11:48:32 +00:00
Samuel Pitoiset
709452b9d1
radv: do not check image usage for ITERATE256 with TC-compat HTILE
...
This is redundant because TC-compat HTILE is only enabled for images
that are readable by shaders.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29349 >
2024-05-24 11:48:32 +00:00
Samuel Pitoiset
dcfa351af3
radv: only enable DB_STENCIL_INFO.ITERATE_FLUSH when necessary
...
When no HTILE for stencil this shouldn't be neessary.
This also matches RadeonSI.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29349 >
2024-05-24 11:48:32 +00:00
Constantine Shablia
2adf01fa61
panvk: enable KHR and EXT BDA
...
And get it tested by CI.
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com >
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com >
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29302 >
2024-05-24 13:07:26 +02:00
Boris Brezillon
deb9756e23
panvk: Lower global memory IOs
...
If we want to support KHR_buffer_device_address, we need to lower global
IOs.
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com >
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29302 >
2024-05-24 13:06:50 +02:00
Mary Guillemard
fe59b772b5
bi: Alloc replacement array once in opt_cse
...
This create an uneeded pressure otherwise.
Signed-off-by: Mary Guillemard <mary.guillemard@collabora.com >
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29372 >
2024-05-24 11:16:31 +02:00
Mary Guillemard
01ea55b44c
midgard: Reformat code
...
Signed-off-by: Mary Guillemard <mary.guillemard@collabora.com >
Acked-by: Boris Brezillon <boris.brezillon@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29372 >
2024-05-24 11:16:31 +02:00
Mary Guillemard
547308990d
bi: Reformat code
...
Had some broken formatting.
Signed-off-by: Mary Guillemard <mary.guillemard@collabora.com >
Acked-by: Boris Brezillon <boris.brezillon@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29372 >
2024-05-24 11:16:03 +02:00
Lionel Landwerlin
2c65d90bc8
intel/brw: ensure find_live_channel don't access arch register without sync
...
Another architecture register that requires some care before reading.
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Fixes: 49ee3ae9e8
("intel/compiler: Lower FIND_[LAST_]LIVE_CHANNEL in IR on Gfx8+")
Tested-by: Tapani Pälli <tapani.palli@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29319 >
2024-05-24 07:26:17 +00:00
Eric Engestrom
1add55863f
zink+nvk/ci: spec@ext_external_objects@vk-vert-buf-reuse has been fixed
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29371 >
2024-05-24 08:48:07 +02:00
Eric Engestrom
ace5c27898
zink+nvk/ci: add more flakes seen in nightly
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29371 >
2024-05-24 08:47:20 +02:00
Eric Engestrom
6789d4c0b2
zink+nvk/ci: more KHR-GL46.packed_pixels.varied_rectangle.* flakes, so mark the group as flaky
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29371 >
2024-05-24 08:45:39 +02:00
Eric Engestrom
6843a7951b
ci/b2c: make B2C_JOB_WARN_REGEX optional
...
Fixes: bfd4db0476
("radv/ci: move amdgpu-specific kernel message warning to src/amd/ci/")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29368 >
2024-05-24 05:58:26 +00:00
Iago Toral Quiroga
865e682ad7
broadcom/compiler: apply payload conflict to spill setup before RA
...
We can emit spill setup before RA if we use scratch. In that case
we have the same situation as during spilling, with the caveat that
we have already emitted the instructions so we need to find them
(they should be the only instructions ones before the instructions
accessing payload registers) and flag them as such.
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com >
cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29343 >
2024-05-24 05:25:22 +00:00
Iago Toral Quiroga
cb83f25b39
broadcom/compiler: don't assign payload registers to spilling setup temps
...
We read our payload registers first in the shader so we generally don't have
to care about temps being allocated to them and stomping their value before
we can read them. Hoewer, spilling setup instructions are an exception since
these will be inserted first when there is any spilling in the program.
To fix this, we flag RA nodes involved with these instructions so we can
then try to avoid assiging these registers to them.
Fixes CTS failures with V3D_DEBUG=opt_compile_time, particularly:
dEQP-VK.binding_model.buffer_device_address.set0.depth2.basessbo.convertcheckuv2.nostore.single.std140.comp_offset_nonzero
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com >
cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29343 >
2024-05-24 05:25:22 +00:00
Iago Toral Quiroga
901c485997
broadcom/compiler: make add_node return the node index
...
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com >
cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29343 >
2024-05-24 05:25:21 +00:00
David Heidelberg
33492dd9e8
ci/radv: dEQP-GLES3.functional.polygon_offset.fixed16_render_with_units passes now
...
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29367 >
2024-05-24 03:45:44 +00:00