Gert Wollny
ab06b00c63
r600: Update nir options
...
Signed-off-by: Gert Wollny <gert.wollny@collabora.com >
Reviewed-by: Filip Gawin <filip@gawin.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17076 >
2022-07-07 20:11:02 +00:00
Gert Wollny
3525d29a8d
r600: Make sure that LDS instructions only use bank swizzle 012
...
Not sure whether this is really needed. With the TGSI code path no
other bank swizzle is emitted for LDS ops, so make sure it's the same here.
Signed-off-by: Gert Wollny <gert.wollny@collabora.com >
Reviewed-by: Filip Gawin <filip@gawin.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17076 >
2022-07-07 20:11:01 +00:00
Gert Wollny
105b03a5ed
r600: Add number of ALU groups to statistics
...
The number of ALU groups is important for good sccheduling, so
let's add it to the stats.
Signed-off-by: Gert Wollny <gert.wollny@collabora.com >
Reviewed-by: Filip Gawin <filip@gawin.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17076 >
2022-07-07 20:11:01 +00:00
Lionel Landwerlin
c67c9688c3
anv/utrace: use a bo pool for utrace buffers
...
When utrace/perfetto is active, we allocate/free utrace buffers at the
same rate as command buffers. It's useful to have a pool that avoids
GEM_CREATE/GEM_CLOSE ioctls.
v2: Use the pool more
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Acked-by: Caio Oliveira <caio.oliveira@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16613 >
2022-07-07 18:49:05 +00:00
Jason Ekstrand
0b92636b62
dozen: Stop asking for semaphore/fence signaling
...
Dozen is currently a SW driver as far as WSI is concerned so it's going
to wait on a fence anyway. Also, I highly doubt it's actually hooked
these up properly. It's probably just a copy+paste from ANV.
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17388 >
2022-07-07 11:44:20 -05:00
Jason Ekstrand
14dd5bd2cb
dozen: Increase optimalBufferCopy*Alignment
...
D3D12 requires the offset to be 512B-aligned and row pitch to be
256B-aligned for copy commands. There will need to be a fallback
written eventually because Vulkan has no such requirements but these
will remain the optimal limits as they allow using the D3D12 copy
commands directly.
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17388 >
2022-07-07 11:44:19 -05:00
Jesse Natalie
8faf3781c8
vulkan/wsi/win32: Use the new helpers and persistent map
...
Reviewed-by: Jason Ekstrand <jason.ekstrand@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17388 >
2022-07-07 11:44:19 -05:00
Jason Ekstrand
aca545d616
vulkan/wsi/wayland: Use host pointer import when available
...
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17388 >
2022-07-07 11:44:19 -05:00
Jason Ekstrand
54fa5ff406
vulkan/wsi/x11: Only use MIT_SHM if the device supports EXT_external_memory_host
...
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17388 >
2022-07-07 11:44:19 -05:00
Jason Ekstrand
5abc05f1df
vulkan/wsi/x11: Don't leak shm_reply if we don't have dri3 or present
...
Fixes: b5c390c113
("vulkan/wsi: add support for detecting mit-shm pixmaps.")
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17388 >
2022-07-07 11:44:19 -05:00
Jason Ekstrand
124848bf9e
vulkan/wsi: Support tiled CPU images
...
Some drivers such as lavapipe are 100% fine with using linear for WSI
images. Most HW drivers, however, would rather render tiled and eat a
blit.
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17388 >
2022-07-07 11:44:19 -05:00
Jason Ekstrand
83fb6fe569
vulkan/wsi: Align buffer image strides to optimalBufferCopyRowPitchAlignment
...
This isn't a big deal for the current buffer paths because the required
alignment for PRIME is already higher than any driver advertises.
However, the SW path we're about to add won't have the PRIME requirement.
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17388 >
2022-07-07 11:44:17 -05:00
Jason Ekstrand
13148b9c68
vulkan/wsi: Compute stride and size in configure_buffer_image
...
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17388 >
2022-07-07 11:44:10 -05:00
Jason Ekstrand
cf37837d36
vulkan/wsi: Persistently map CPU images
...
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17388 >
2022-07-07 11:44:09 -05:00
Jason Ekstrand
1d0290fbfe
vulkan/wsi: Delete SW support from configure_native_image
...
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17388 >
2022-07-07 10:21:35 -05:00
Jason Ekstrand
4c79ec1934
vulkan/wsi/wayland: Use wsi_configure_cpu_image
...
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17388 >
2022-07-07 10:21:34 -05:00
Jason Ekstrand
3d48b3c6f8
vulkan/wsi/x11: Use wsi_configure_cpu_image
...
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17388 >
2022-07-07 10:21:33 -05:00
Jason Ekstrand
afe2cb7b11
vulkan/wsi: Add a helper for creating CPU images
...
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17388 >
2022-07-07 10:21:30 -05:00
Jason Ekstrand
1cc20fbefd
vulkan/wsi: Move select_memory_type to common and rework it a bit
...
Instead of taking a single boolean for device-local, take a set of
required properties and denied properties. This will let us require
additional things like being CPU mappable in the future.
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17388 >
2022-07-07 10:21:29 -05:00
Jason Ekstrand
fbb7b6e052
vulkan/wsi/wayland: Use a single memcpy in the SW path
...
The strides match. There's no reason to loop over image height.
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17388 >
2022-07-07 10:21:27 -05:00
Jason Ekstrand
ca6bd57e76
vulkan/wsi: Pass the size to MapMemory in the SW path
...
Cc: mesa-stable@lists.freedesktop.org
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17388 >
2022-07-07 10:21:24 -05:00
Tatsuyuki Ishi
2848e2f28e
radv/ci: Move sample_texture.*_compressed_format_* to faillist for gfx<=9
...
This turned out to be not a CTS bug but rather hardware bug around the
cache handle BCn textures.
It requires significant tracking to detect such cases, and it's likely
not worth a workaround since reading a texture as both compressed and
uncompressed in succession shall not be a realistic use case.
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/6689
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17345 >
2022-07-07 13:19:56 +00:00
Pierre-Eric Pelloux-Prayer
5791826b1a
mesa: skip draws with invalid indices offset
...
It's easy to misuse glDrawElements and end up with an
invalid indices offset.
Since this can cause a hang, detect this case and skip
the draw.
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/6625
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16662 >
2022-07-07 12:25:05 +00:00
Pierre-Eric Pelloux-Prayer
3c61f2cc15
util/blob: use memcpy in read functions
...
Type casting may require specific alignment on some platforms;
since the input data can be provided by the application we can't
require any alignment.
Switch to using memcpy like the write functions do, and drop the
asserts.
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/6493
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16662 >
2022-07-07 12:25:05 +00:00
Pierre-Eric Pelloux-Prayer
8856379a03
mesa/st: don't guess the internal format if it's known
...
This fixes tests using imageLoad/imageStore on texture
created using glEGLImageTargetTexture2DOES.
Before this change, the format was guessed as GL_RGBA,
which would be rejected by _mesa_get_shader_image_format.
Reviewed-by: Adam Jackson <ajax@redhat.com >
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16662 >
2022-07-07 12:25:05 +00:00
Pierre-Eric Pelloux-Prayer
085bdd89c2
dri: store internal_format when known
...
For images created from textures or renderbuffer, the internal
format is known so store it.
This will be used in the next commit to replaces guessing it.
Reviewed-by: Adam Jackson <ajax@redhat.com >
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16662 >
2022-07-07 12:25:05 +00:00
Lionel Landwerlin
f1dd487531
intel/nir: temporarly disable opt_uniform_atomics for RT/CL
...
Not had time to investiguate what is going is on but it's definitely a
contributor to failures.
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Acked-by: Caio Oliveira <caio.oliveira@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16104 >
2022-07-07 10:21:48 +00:00
Gert Wollny
bf29ebc0a7
virgl: Submit the TGSI_PROPERTY_SEPARABLE_PROGRAM when the host understands it
...
We can't unconditionally support separable shader objects on the host,
so submit the property only if the shader is actually separable, the
host knows about the property, and supports SSO.
Without support for SSOs, the host can still compile and link the shaders,
it needs to do more work on interface matching though.
Signed-off-by: Gert Wollny <gert.wollny@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17344 >
2022-07-07 09:46:53 +00:00
Gert Wollny
198bcf7726
tgsi: Don't bother setting the TGSI_PROPERTY_SEPARABLE_PROGRAM
...
Most drivers don't care about the property, and virgl should only handle
it if the host supports it.
This is a partial revert of b634030
, i.e. we keep the definition of the
property, but we don't set it only based on the shader info.
Fixes: b634030542
tgsi: Add SEPARABLE_PROGRAM property
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17344 >
2022-07-07 09:46:53 +00:00
Iago Toral Quiroga
f4a3bccf94
v3dv: remove obsolete comment
...
multop + umul24 can only be used to implement 32-bit multiplies,
so for a full 64-bit result we always need to lower.
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17372 >
2022-07-07 09:16:24 +00:00
Iago Toral Quiroga
152fc4fd28
v3dv: don't lower uadd_carry and usub_borrow
...
We can produce slightly better code for these in the backend, so
do that. For this we need to:
1. Fix our implementation of uadd_carry (which wasn't used) to return
an integer instead of a boolean value.
2. Add an implementation of usub_borrow.
Notice these are only used in Vulkan. In GL these instructions are
always unconditionally lowered by the state tracker in GLSL IR so
we never get to see them in the backend.
Shader-db stats from a collection of Vulkan samples:
total instructions in shared programs: 122351 -> 122345 (<.01%)
instructions in affected programs: 196 -> 190 (-3.06%)
helped: 2
HURT: 0
total uniforms in shared programs: 18670 -> 18672 (0.01%)
uniforms in affected programs: 59 -> 61 (3.39%)
helped: 0
HURT: 2
total max-temps in shared programs: 13145 -> 13147 (0.02%)
max-temps in affected programs: 27 -> 29 (7.41%)
helped: 0
HURT: 2
total inst-and-stalls in shared programs: 123052 -> 123046 (<.01%)
inst-and-stalls in affected programs: 197 -> 191 (-3.05%)
helped: 2
HURT: 0
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17372 >
2022-07-07 09:16:24 +00:00
Iago Toral Quiroga
84a0dca9df
nir: fix documentation for uadd_carry and usub_borry opcodes
...
These opcodes where fixed to return an integer instead of a boolean
value some time ago but the documentation for them was not updated
and still talked about a boolean result.
Fixes: b0d4ee520
('nir/opcodes: Fix up uadd_carry and usub_borrow')
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17372 >
2022-07-07 09:16:24 +00:00
Lionel Landwerlin
1b6c74c48d
intel/fs: make sure memory writes have landed for thread dispatch
...
The thread dispatch SEND instructions will dispatch new threads
immediately even before the caller of the SEND instruction has reached
EOT. So we really need to make sure all the memory writes are visible
to other threads within the DSS before the SEND.
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Reviewed-by: Caio Oliveira <caio.oliveira@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15755 >
2022-07-07 09:48:20 +03:00
Clément Guérin
a1a22862c6
venus: implement VK_EXT_physical_device_drm
...
Reviewed-by: Yiwei Zhang <zzyiwei@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17387 >
2022-07-07 02:46:45 +00:00
Dawn Han
fdf550cdf0
venus: enabled iub in physical device
...
Signed-off-by: Dawn Han <dawnhan@google.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16699 >
2022-07-07 02:37:36 +00:00
Dawn Han
32283b9703
Refactor and add template support for iub
...
Signed-off-by: Dawn Han <dawnhan@google.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16699 >
2022-07-07 02:37:36 +00:00
Dawn Han
abae9d4831
Add the iub binding count tracking
...
Signed-off-by: Dawn Han <dawnhan@google.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16699 >
2022-07-07 02:37:36 +00:00
Dawn Han
6bd8dda57b
Add iub type to vn_descriptor_type
...
Verified the pNext VkWriteDescriptorSet is not NULL on iub type
Signed-off-by: Dawn Han <dawnhan@google.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16699 >
2022-07-07 02:37:36 +00:00
Dawn Han
78e637f857
Refactor the descriptor enums to be extensible
...
Signed-off-by: Dawn Han <dawnhan@google.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16699 >
2022-07-07 02:37:36 +00:00
Dawn Han
40fb107664
Add iub features and properties passthrough
...
Signed-off-by: Dawn Han <dawnhan@google.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16699 >
2022-07-07 02:37:36 +00:00
Guilherme Gallo
20827dfa9b
ci/lava: Update license header
...
Use SPDX to indicate the license.
Update authors of lava_job_submitter.py
Signed-off-by: Guilherme Gallo <guilherme.gallo@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16323 >
2022-07-07 00:28:53 +00:00
Guilherme Gallo
3f3b0a28f2
ci/lava: Rename console color names
...
Use FG to indicate foreground colors
Signed-off-by: Guilherme Gallo <guilherme.gallo@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16323 >
2022-07-07 00:28:53 +00:00
Guilherme Gallo
6ba2b33a8c
ci/lava: Flexibilize section marker regexes
...
In some jobs, such as
https://gitlab.freedesktop.org/gallo/mesa/-/jobs/24904100 , the kmsg is
interleaved with stderr/stdout in serial console, making it difficult to
confidently find the log messages to detect when the DUT is booting,
when the DUT is running etc.
Luckily, LAVA sends redundant messages about their signals. We can use
them to mitigate the chance of missing an interleaved message by being
more open to different messages, using the regex on both `debug` and
`target` LAVA log levels.
Signed-off-by: Guilherme Gallo <guilherme.gallo@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16323 >
2022-07-07 00:28:53 +00:00
Guilherme Gallo
24f368d652
ci/lava: Stop printing after the result line
...
There are some leftovers in the jobs logs after the result log line.
Only print until the init-stage2.sh output, to raise the chance to check
for the test script results at the first glance in the Gitlab logs.
Extra changes:
- Add `hung` status for jobs considered hanging in the Gitlab
- print them after the retry loop
Signed-off-by: Guilherme Gallo <guilherme.gallo@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16323 >
2022-07-07 00:28:53 +00:00
Guilherme Gallo
f09aab08e9
ci/lava: Highlight job retrying message
...
It should be clear to the developer that the job was not successful in
the first run.
Signed-off-by: Guilherme Gallo <guilherme.gallo@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16323 >
2022-07-07 00:28:53 +00:00
Guilherme Gallo
868daded22
ci/lava: Highlight kernel messages in bold
...
This will serve to warn the user that those messages are processed
differently, e.g. the kmsgs does not trigger heartbeats and maybe
eventual targets of hint to retry the job immediately.
Signed-off-by: Guilherme Gallo <guilherme.gallo@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16323 >
2022-07-07 00:28:53 +00:00
Guilherme Gallo
29af421272
ci/lava: Don't print LAVA debug messages
...
Remove debug messages from the output in order to unclutter the log a
little more for the developers.
Signed-off-by: Guilherme Gallo <guilherme.gallo@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16323 >
2022-07-07 00:28:53 +00:00
Guilherme Gallo
466917ea4c
ci/lava: Add an integration test for LAVA jobs
...
test_full_yaml_log is a test that will look for a LAVA log YAML file at
`/tmp/log.yaml` and consume it as it was a realtime CI job.
It is useful for debugging issues related with LAVA.
Let's keep it skipped by default, to avoid introducing entire logs into
the codebase.
Signed-off-by: Guilherme Gallo <guilherme.gallo@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16323 >
2022-07-07 00:28:53 +00:00
Guilherme Gallo
c9d4076c1e
ci/lava: Wrap job definition dump into a collapsed section
...
Signed-off-by: Guilherme Gallo <guilherme.gallo@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16323 >
2022-07-07 00:28:53 +00:00
Guilherme Gallo
fc2ae8d375
ci/lava: Wrap job info into a collapsed section
...
Signed-off-by: Guilherme Gallo <guilherme.gallo@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16323 >
2022-07-07 00:28:53 +00:00