Gert Wollny
80a1b91601
nir/lower_int64: Fix compilation with gcc-13 and tsan enabled
...
../src/compiler/nir/nir_lower_int64.c: In function ‘lower_int64_intrinsic’:
../src/compiler/nir/nir_lower_int64.c:1347:1: error: control reaches end of non-void function [-Werror=return-type]
1347 | }
Fixes: bf7a114246
nir/lower_int64: Add lowering for some 64-bit subgroup ops
Signed-off-by: Gert Wollny <gert.wollny@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27345 >
2024-01-30 20:42:07 +00:00
Gert Wollny
ca47138fb1
radv: Fix compilation with gcc-13 and tsan enabled
...
../src/amd/vulkan/radv_sampler.c: In function ‘radv_tex_wrap’:
../src/amd/vulkan/radv_sampler.c:50:1: error: control reaches end of non-void function [-Werror=return-type]
50 | }
| ^
../src/amd/vulkan/radv_sampler.c: In function ‘radv_tex_compare’:
../src/amd/vulkan/radv_sampler.c:76:1: error: control reaches end of non-void function [-Werror=return-type]
76 | }
| ^
Fixes: 4de305cb8a
radv: move sampler related code to radv_sampler.c
Signed-off-by: Gert Wollny <gert.wollny@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27345 >
2024-01-30 20:42:07 +00:00
Gert Wollny
f6383e03f9
zink: use enums as return values in resource_object_create
...
(As suggested by Mike).
With that replace the goto statements for error cleanup by
a switch/case.
Signed-off-by: Gert Wollny <gert.wollny@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27155 >
2024-01-30 20:17:32 +00:00
Gert Wollny
3d203b5477
zink: remove duplicate arguments and use VkMemoryRequirements locally
...
Signed-off-by: Gert Wollny <gert.wollny@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27155 >
2024-01-30 20:17:32 +00:00
Gert Wollny
9c3e733779
zink: simplify call to get_export_flags
...
Signed-off-by: Gert Wollny <gert.wollny@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27155 >
2024-01-30 20:17:32 +00:00
Gert Wollny
472bca9469
zink: Move more code to create_image and create_buffer
...
With that resource_object_create only contains the common
initzialization, the error handling and then calls seperate
functions to create buffers or images.
Signed-off-by: Gert Wollny <gert.wollny@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27155 >
2024-01-30 20:17:32 +00:00
Gert Wollny
0b88f68067
zink: extract allocate_bo_and_update_obj from resource_object_create
...
Signed-off-by: Gert Wollny <gert.wollny@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27155 >
2024-01-30 20:17:32 +00:00
Gert Wollny
df9cbe431e
zink: drop duplicate assignment to obj->alignment
...
The value resource_object_create obj->alignment is set again in
allocate_bo and the assignment uses a few more tests there.
Signed-off-by: Gert Wollny <gert.wollny@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27155 >
2024-01-30 20:17:32 +00:00
Gert Wollny
063949063c
zink: extract debug_resource_mem from resource_object_create
...
Signed-off-by: Gert Wollny <gert.wollny@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27155 >
2024-01-30 20:17:32 +00:00
Gert Wollny
7180670e28
zink: extract update_obj_info from resource_object_create
...
Signed-off-by: Gert Wollny <gert.wollny@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27155 >
2024-01-30 20:17:32 +00:00
Gert Wollny
081e5d1109
zink: extract function update_alloc_info from resource_object_create
...
Signed-off-by: Gert Wollny <gert.wollny@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27155 >
2024-01-30 20:17:32 +00:00
Gert Wollny
1d0e9001cd
zink: extract function create_image from resource_object_create
...
Signed-off-by: Gert Wollny <gert.wollny@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27155 >
2024-01-30 20:17:32 +00:00
Gert Wollny
eb394f5316
zink: redesign the allocation try loop to test all heaps
...
Before the first time an allocation failed the heap was changed,
now we only change the heap type when checking all heaps results
in allocation failure.
Signed-off-by: Gert Wollny <gert.wollny@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27155 >
2024-01-30 20:17:32 +00:00
Gert Wollny
252e877a87
zink: extract function allocate_bo from resource_create_object
...
v2: move reworking the loop to a new commit (Mike)
Signed-off-by: Gert Wollny <gert.wollny@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27155 >
2024-01-30 20:17:32 +00:00
Gert Wollny
3806586c6e
zink: extract get_export_flags from resource_object_create
...
Signed-off-by: Gert Wollny <gert.wollny@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27155 >
2024-01-30 20:17:32 +00:00
Gert Wollny
e22c525aa0
zink: reduce number of #ifdefs in resource_create_object
...
Signed-off-by: Gert Wollny <gert.wollny@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27155 >
2024-01-30 20:17:32 +00:00
Gert Wollny
a5fd408a74
zink: factor out get_image_memory_requirement in resource_object_create
...
Signed-off-by: Gert Wollny <gert.wollny@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27155 >
2024-01-30 20:17:32 +00:00
Gert Wollny
55f3941076
zink: factor out get_format_feature_flags in resource_object_create
...
Signed-off-by: Gert Wollny <gert.wollny@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27155 >
2024-01-30 20:17:32 +00:00
Gert Wollny
6664fdaf48
zink: Factor out create sampler conversion in resource_object_create
...
Signed-off-by: Gert Wollny <gert.wollny@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27155 >
2024-01-30 20:17:32 +00:00
Gert Wollny
b2ce61b91d
zink: shorten lifetime of success variable in resource_object_create
...
Signed-off-by: Gert Wollny <gert.wollny@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27155 >
2024-01-30 20:17:32 +00:00
Gert Wollny
7cf77c553c
zink: Factor out create buffer from resource_object_create
...
Signed-off-by: Gert Wollny <gert.wollny@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27155 >
2024-01-30 20:17:31 +00:00
Leo Liu
46f5a226d6
radeonsi: fix video processing path without VPE enabled
...
Fixes: 6b441ef6ab
(amd, radeonsi: supports post processing entrypoint)
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/10495
Cc: mesa-stable
Signed-off-by: Leo Liu <leo.liu@amd.com >
Reviewed-by: Ruijing Dong <ruijing.dong@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27339 >
2024-01-30 19:53:53 +00:00
Daniel Schürmann
26c8f13ff5
vulkan: enable VK_KHR_shader_expect_assume
...
This implementation ignores the hints.
Acked-by: Caio Oliveira <caio.oliveira@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27265 >
2024-01-30 19:09:42 +00:00
Daniel Schürmann
5df7be8017
spirv: Fix SpvOpExpectKHR
...
This instruction behaves the same as *OpCopyObject* by making a copy of _Value_.
Reviewed-by: Georg Lehmann <dadschoorse@gmail.com >
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com >
Reviewed-by: Caio Oliveira <caio.oliveira@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27265 >
2024-01-30 19:09:42 +00:00
Samuel Pitoiset
9b5ea35158
radv: add support for VK_SHADER_CREATE_NO_TASK_SHADER_BIT_EXT
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27237 >
2024-01-30 18:29:51 +00:00
Samuel Pitoiset
9211eef738
radv: init the shader key in radv_shader_stage_init() for ESO
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27237 >
2024-01-30 18:29:51 +00:00
Samuel Pitoiset
13add95beb
radv: prevent crashes when a task shader is compiled unlinked with ESO
...
That means the mesh shader stage would be NULL.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27237 >
2024-01-30 18:29:51 +00:00
Samuel Pitoiset
f23efd7093
radv: bind and emit mesh/task shaders with ESO
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27237 >
2024-01-30 18:29:51 +00:00
Samuel Pitoiset
29491d36aa
radv: determine the last VGT api stage with mesh shaders and ESO
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27237 >
2024-01-30 18:29:51 +00:00
Samuel Pitoiset
6adea03a3e
radv: ignore unneeded dynamic states with mesh shaders and ESO
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27237 >
2024-01-30 18:29:51 +00:00
Samuel Pitoiset
9157087d43
radv: determine next stage for mesh/task with ESO
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27237 >
2024-01-30 18:29:51 +00:00
Samuel Pitoiset
64aa84eaf7
radv: rebind mesh/task shaders when restoring meta context
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27237 >
2024-01-30 18:29:51 +00:00
Christian Gmeiner
1602129465
etnaviv/isa: Add missing dep of encode.py/decode.py calls on isa.py
...
Changing src/compiler/isaspec/*.py did not cause rebuilds of
etnaviv-isa.c and etnaviv-isa.h.
Signed-off-by: Christian Gmeiner <cgmeiner@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27134 >
2024-01-30 18:05:43 +00:00
Eric Engestrom
944aefa933
zink+anv/ci: add a couple more flakes
...
`UnexpectedImprovement(Pass)` in https://gitlab.freedesktop.org/mesa/mesa/-/jobs/54381879
Expected `Fail` in https://gitlab.freedesktop.org/mesa/mesa/-/jobs/54386127
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27361 >
2024-01-30 15:37:13 +00:00
Mike Blumenkrantz
f0aca7e7c9
lavapipe: KHR_dynamic_rendering_local_read
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27282 >
2024-01-30 13:59:11 +00:00
Eric Engestrom
92c24191d4
tree-wide: use __normal_user() everywhere instead of writing the check manually
...
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27346 >
2024-01-30 12:45:54 +00:00
Eric Engestrom
3e00558ef0
util: rename __check_suid() to __normal_user()
...
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27346 >
2024-01-30 12:45:54 +00:00
Samuel Pitoiset
2d91b870fb
radv: emit required programming for tess on GFX10+ in radv_emit_hw_vs()
...
This is required on GFX10+ with legacy pipeline (no NGG) and without
a geometry shader. So this can be moved to radv_emit_hw_vs() because
if we have a TES+GS, TES would be NULL and if we have TES as NGG it
would be emitted from radv_emit_hw_ngg().
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27301 >
2024-01-30 11:47:29 +00:00
Samuel Pitoiset
f870e5ff11
radv: fix emitting tess domain origin for merged TES+GS on GFX9
...
For merged TES+GS, TES is NULL and this state wasn't emitted.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27301 >
2024-01-30 11:47:29 +00:00
Samuel Pitoiset
d9b61de2f7
radv: fix detecting invalid binaries with ESO
...
On GFX9+, if linked shaders are created and shaders are merged (for
example VS to GS).
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27301 >
2024-01-30 11:47:29 +00:00
Juan A. Suarez Romero
3304c6ca01
v3d/ci: update expected results
...
Signed-off-by: Juan A. Suarez Romero <jasuarez@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27356 >
2024-01-30 11:17:06 +00:00
Konstantin Seurer
9acc869b57
llvmpipe: Fix building with llvm11
...
Acked-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27223 >
2024-01-30 10:14:45 +00:00
Konstantin Seurer
f27a973283
radv/rt: Use doubles inside intersect_ray_amd_software_tri
...
Increasing precision lets us avoid duplicate hits on shared edges. The
previous biasing WA made a bunch of tests fail.
Reviewed-by: Friedrich Vock <friedrich.vock@gmx.de >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27243 >
2024-01-30 10:26:43 +01:00
Haihao Xiang
29d18f3ca9
anv: Fix typo in transition_color_buffer
...
Signed-off-by: Haihao Xiang <haihao.xiang@intel.com >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27330 >
2024-01-30 07:39:01 +00:00
Daniel Almeida
8ff3a13e4d
nak: sm50: fix some legalization issues
...
Match the sm50 legalization pass with the requirements expressed in
encode_sm50.rs. Make sure the SrcTypes passed in the legalization
pass are correct while we're at it.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26987 >
2024-01-30 02:36:57 +00:00
Daniel Almeida
b18472c718
nak/sm50: add support for brev
...
Fixes dEQP-VK.spirv_assembly.type.vec3.u32.bit_reverse_comp
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26723 >
2024-01-30 01:49:59 +00:00
Daniel Almeida
84a7e94f31
nak/sm50: legalize: display instruction on panic
...
This makes it faster to know what is broken from logs
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26723 >
2024-01-30 01:49:59 +00:00
Daniel Almeida
c1614913d9
nak: sm50: fadd: ensure src[0] is in a register
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26723 >
2024-01-30 01:49:59 +00:00
Daniel Almeida
2ac28dd9a9
nak: sm50: add support for OpOut
...
Geometry shaders are broken otherwise.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26723 >
2024-01-30 01:49:59 +00:00
Daniel Almeida
8b40a8715d
nak/sm50: add support for isberd
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26723 >
2024-01-30 01:49:59 +00:00