Rhys Perry
8096e0df7a
aco: remove trailing whitespace
...
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com >
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7043 >
2020-10-07 11:53:23 +00:00
Samuel Pitoiset
3c5eb1f761
aco: more uses of nir_get_io_offset_src()
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7003 >
2020-10-07 13:31:36 +02:00
Samuel Pitoiset
1211d05bef
aco: bail out if the NIR IO base offset isn't zero
...
nir_io_add_const_offset_to_base takes care of this.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7003 >
2020-10-07 13:31:25 +02:00
Lucas Stach
9d5ec7f6f2
etnaviv: stop leaking the dummy texure descriptor BO
...
Free the dummy texture descriptor BO on context destroy.
Fixes: eda73d7127
(etnaviv: GC7000: Texture descriptors)
Signed-off-by: Lucas Stach <l.stach@pengutronix.de >
Reviewed-by: Guido Günther <agx@sigxcpu.org >
Reviewed-by: Christian Gmeiner <christian.gmeiner@gmail.com >
Cc: <mesa-stable@lists.freedesktop.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6986 >
2020-10-07 11:17:18 +02:00
Juan A. Suarez Romero
6a44bda879
intel/uuid: use git-sha1/package for the driver UUID
...
We can't read information from the loaded shared object because we have
different objects for Vulkan and OpenGL drivers, but we need to share
the same UUID for both.
Hence let's use SHA1 from the Git commit and package version.
v2: use also package version for the case of building from tarball (Eric)
v3: fix typos in comment (Tapani)
Signed-off-by: Juan A. Suarez Romero <jasuarez@igalia.com >
Reviewed-by: Eric Engestrom <eric@engestrom.ch >
Reviewed-by: Rohan Garg <rohan.garg@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7025 >
2020-10-07 11:11:34 +03:00
Juan A. Suarez Romero
456fa9b838
iris: plumb device/driver UUID generators
...
Use the same generators as used in anv driver so both Vulkan and OpenGL
drivers can share the same external memory objects.
v2: removed extra parameter from function gen_uuid_compute_device_id
Signed-off-by: Juan A. Suarez Romero <jasuarez@igalia.com >
Signed-off-by: Eleni Maria Stea <estea@igalia.com >
Reviewed-by: Eric Engestrom <eric@engestrom.ch >
Reviewed-by: Rohan Garg <rohan.garg@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7025 >
2020-10-07 11:11:28 +03:00
Juan A. Suarez Romero
e9a766a8c0
intel: split driver/device UUID generators
...
We need Vulkan and GL to produce the same UUIDs. So move the generator
from ANV to a common code that can be shared by ANV and Iris driver.
v2: fix android build (Tapani)
Signed-off-by: Juan A. Suarez Romero <jasuarez@igalia.com >
Reviewed-by: Eric Engestrom <eric@engestrom.ch >
Reviewed-by: Rohan Garg <rohan.garg@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7025 >
2020-10-07 11:11:23 +03:00
Eduardo Lima Mitev
713386af20
turnip: Enable support for KHR_incremental_present
...
All bits should already be provided by wsi/common.
Reviewed-by: Eric Anholt <eric@anholt.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6704 >
2020-10-07 07:13:41 +00:00
Pierre-Eric Pelloux-Prayer
8b205402c3
omx/tizonia: fix build
...
Fixes: 24f2b0a856
("gallium/video: remove pipe_video_buffer.chroma_format")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/3595
Reviewed-by: Leo Liu <leo.liu@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7026 >
2020-10-07 09:05:21 +02:00
Marek Olšák
f5f0c012ad
gallium/util: remove empty file u_half.h
...
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Reviewed-by: Matt Turner <mattst88@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6987 >
2020-10-06 21:07:11 -04:00
Marek Olšák
71697953ec
gallium/util: remove redundant util_float_to_half_rtz
...
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Reviewed-by: Matt Turner <mattst88@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6987 >
2020-10-06 21:07:09 -04:00
Marek Olšák
b42c6ff6f6
util: remove util_float_to_half and util_half_to_float wrappers
...
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Reviewed-by: Matt Turner <mattst88@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6987 >
2020-10-06 21:07:07 -04:00
Marek Olšák
24a62dd0fb
util: move util_half_to_float code into _mesa_half_to_float_slow
...
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Reviewed-by: Matt Turner <mattst88@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6987 >
2020-10-06 21:07:05 -04:00
Marek Olšák
ffcdf76799
util: implement F16C using inline assembly on x86_64
...
F16C: https://en.wikipedia.org/wiki/F16C
This also happens to fix bptc-float-modes on llvmpipe.
Reviewed-by: Matt Turner <mattst88@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6987 >
2020-10-06 21:07:03 -04:00
Samuel Pitoiset
4c54f05915
nir/constant_folding: init nir_const_value to zero
...
To avoid NIR validation failures.
Fixes: 9df1ff3678
("nir/constant_folding: Use the builder")
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7035 >
2020-10-06 20:27:39 +00:00
Dave Airlie
335132cd4d
lavapipe: drop dri,dricommon deps.
...
This would be a step towards building elsewhere.
Reviewed-by: Eric Anholt <eric@anholt.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7019 >
2020-10-06 19:04:44 +00:00
Marcin Ślusarz
9c25689287
intel: drop likely/unlikely around INTEL_DEBUG
...
It's included in declaration of INTEL_DEBUG.
Signed-off-by: Marcin Ślusarz <marcin.slusarz@intel.com >
Acked-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Reviewed-by: Matt Turner <mattst88@gmail.com >
Reviewed-by: Eric Anholt <eric@anholt.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6732 >
2020-10-06 18:43:07 +00:00
Marcin Ślusarz
e06da554e9
anv: drop likely/unlikely around INTEL_DEBUG
...
It's included in declaration of INTEL_DEBUG.
Signed-off-by: Marcin Ślusarz <marcin.slusarz@intel.com >
Acked-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Reviewed-by: Matt Turner <mattst88@gmail.com >
Reviewed-by: Eric Anholt <eric@anholt.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6732 >
2020-10-06 18:43:07 +00:00
Marcin Ślusarz
4b9e38ca06
i965: drop likely/unlikely around INTEL_DEBUG
...
It's included in declaration of INTEL_DEBUG.
Signed-off-by: Marcin Ślusarz <marcin.slusarz@intel.com >
Acked-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Reviewed-by: Matt Turner <mattst88@gmail.com >
Reviewed-by: Eric Anholt <eric@anholt.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6732 >
2020-10-06 18:43:07 +00:00
Marcin Ślusarz
e6d26fbf3d
iris: drop likely/unlikely around INTEL_DEBUG
...
It's included in declaration of INTEL_DEBUG.
Signed-off-by: Marcin Ślusarz <marcin.slusarz@intel.com >
Acked-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Reviewed-by: Matt Turner <mattst88@gmail.com >
Reviewed-by: Eric Anholt <eric@anholt.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6732 >
2020-10-06 18:43:07 +00:00
Marcin Ślusarz
4015e1876a
intel: add INTEL_DEBUG expected value in declaration
...
Signed-off-by: Marcin Ślusarz <marcin.slusarz@intel.com >
Acked-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Reviewed-by: Matt Turner <mattst88@gmail.com >
Reviewed-by: Eric Anholt <eric@anholt.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6732 >
2020-10-06 18:43:07 +00:00
Sagar Ghuge
bcfec61d1e
anv: Add driconf option to disable compression for 16bpp format
...
On Fallout4, enabling HIZ_CCS_WT compression for D16_UNORM format
regress the performance by 2%, in order to avoid that disable
compression via driconf option.
The experiment showed that, running Fallout4 with HIZ performs better
than HIZ_CCS and HIZ_CCS_WT. Reason behind that is the benchmark uses
the depth pass with D16_UNORM surfaces format which fills the L3 cache
and next pass doesn't make use of it where we end up clearing cache.
v2:
- Don't add conditional check in isl (Nanley, Jason)
- Move disable_d16unorm_compression flag to instance (Lionel)
- Use plane_format.isl_format (Nanley)
v3:
- Add more descriptive comment (Marcin Ślusarz)
Signed-off-by: Sagar Ghuge <sagar.ghuge@intel.com >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6734 >
2020-10-06 18:27:25 +00:00
Sagar Ghuge
49593205b9
anv: Factor out dri option initialization code in separate function
...
Signed-off-by: Sagar Ghuge <sagar.ghuge@intel.com >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6734 >
2020-10-06 18:27:25 +00:00
Karol Herbst
7c6f1d3bf9
clover/nir: extract constant buffer into its own section
...
Fixes test_basic constant_source
Signed-off-by: Karol Herbst <kherbst@redhat.com >
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net >
Reviewed-by: Francisco Jerez <currojerez@riseup.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6569 >
2020-10-06 17:30:41 +00:00
Karol Herbst
adbfff6eae
clover: bind constant buffer if one is provided
...
We will use that with NIR as it is easier to manage the constant buffer
inside clover instead of letting all drivers to deal with it.
Signed-off-by: Karol Herbst <kherbst@redhat.com >
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net >
Reviewed-by: Francisco Jerez <currojerez@riseup.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6569 >
2020-10-06 17:30:41 +00:00
Karol Herbst
af85985250
clover/util: add id_type_equals to support symbols with multiple sections
...
Signed-off-by: Karol Herbst <kherbst@redhat.com >
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6569 >
2020-10-06 17:30:41 +00:00
Eric Anholt
7fb4ab9ec1
driconf: Restore the ability to override driconf with the environment.
...
I distinctly remember testing this during development, yet clearly deleted
the code.
I pulled the parseValue code back up to the top where it used to be since
we have to use it, rather than just adding a prototype.
Fixes: 8a05d6ffc6
("driconf: Make the driver's declarations be structs instead of XML.")
Reviewed-by: Michel Dänzer <mdaenzer@redhat.com >
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7012 >
2020-10-06 17:03:49 +00:00
Eric Anholt
455bfecdff
driconf: Make sure that the range check on the defaults actually works.
...
Fixes: 8a05d6ffc6
("driconf: Make the driver's declarations be structs instead of XML.")
Reviewed-by: Michel Dänzer <mdaenzer@redhat.com >
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7012 >
2020-10-06 17:03:49 +00:00
Daniel Stone
24b4a63b3d
CI: Re-enable Panfrost T7xx CI
...
Lab maintenance is done now.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7032 >
2020-10-06 16:37:27 +00:00
Marek Olšák
3dc00c33f0
gallium/u_threaded_context: fix use-after-free in transfer_unmap
...
discovered by valgrind
Fixes: fd6a5e112a
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6952 >
2020-10-06 16:18:40 +00:00
Marek Olšák
706fef711b
gallium/u_threaded_context: always flush asynchronously if requested
...
This can reduce overhead depending on whether st/mesa uses the ASYNC flag
and the app flushes often.
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6952 >
2020-10-06 16:18:40 +00:00
Marek Olšák
28256d3d7b
gallium/u_threaded_context: don't call memcpy in tc_set_constant_buffer
...
In sysprof, the CPU time spend in tc_set_constant_buffer drops
from 7% to 1.4% in a release build. It doesn't make sense to me.
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6952 >
2020-10-06 16:18:40 +00:00
Marek Olšák
ed3c5fe469
radeonsi: implement GL_INTEL_blackhole_render
...
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7031 >
2020-10-06 15:59:08 +00:00
Marek Olšák
bad7b38aa1
radeonsi: remove dead variable postponed_kill
...
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7031 >
2020-10-06 15:59:08 +00:00
Marek Olšák
d5575ca7a1
gallium/util: add set_frontend_noop into driver_noop and u_threaded_context
...
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7031 >
2020-10-06 15:59:08 +00:00
Marek Olšák
72fa3372cc
util/idalloc: resize if ID is too large for reservation
...
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7031 >
2020-10-06 15:59:07 +00:00
Marek Olšák
155b1b1792
st/mesa: enable GL name reuse for queries based on the driconf option
...
Fixes: a56849ddda
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7031 >
2020-10-06 15:59:07 +00:00
Marek Olšák
6f7446bda5
driconf: enable force_glsl_extensions_warn for viewperf
...
Discovered by Pierre-Eric Pelloux-Prayer.
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7031 >
2020-10-06 15:59:07 +00:00
Marek Olšák
a8b4e690cf
driconf: force the vendor string to NVIDIA to fix viewperf energy tests
...
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7031 >
2020-10-06 15:59:07 +00:00
Marek Olšák
5827fe898e
gl_marshal.py: inline print_sync_dispatch
...
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7031 >
2020-10-06 15:59:07 +00:00
Marek Olšák
bcd6b0c685
mesa: factor out layout parsing for glInterleavedArrays
...
glthread will use it.
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7031 >
2020-10-06 15:59:07 +00:00
Jason Ekstrand
60825a542d
nir/constant_folding: Fold load_deref of nir_var_mem_constant
...
Reviewed-by: Eric Anholt <eric@anholt.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6974 >
2020-10-06 15:42:03 +00:00
Jason Ekstrand
481b7538ab
nir: Validate constant initializers
...
Reviewed-by: Eric Anholt <eric@anholt.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6974 >
2020-10-06 15:42:03 +00:00
Jason Ekstrand
1ada83504f
nir/constant_folding: Use nir_shader_instruction_pass
...
This gets rid of so much boilerplate...
Reviewed-by: Eric Anholt <eric@anholt.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6974 >
2020-10-06 15:42:03 +00:00
Jason Ekstrand
9df1ff3678
nir/constant_folding: Use the builder
...
Reviewed-by: Eric Anholt <eric@anholt.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6974 >
2020-10-06 15:42:03 +00:00
Mike Blumenkrantz
3b11b37a1b
radv: remove VkPipelineCacheCreateInfo::flags assert
...
flags are handled, so this just crashes for no reason
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7030 >
2020-10-06 15:12:35 +00:00
Nanley Chery
3f3a5f3489
iris: Fix a fast-clear skipping optimization
...
When support for multi-slice fast-clears was introduced for color
surfaces, an existing optimization for skipping fast-clears was not
updated (this optimization assumed single-slice fast-clears). As a
result, the driver began to skip multi-layer fast-clears if just the
first slice was in the CLEAR state (ignoring the state of the others).
A Civilization VI trace was the only workload I found to make use of
this optimization and it did so for 2D, non-array textures. Therefore,
this fix simply checks that the depth of the clear box is 1. It also
moves the single-slice aux-state query closer to the optimization to
clarify the need for the depth check.
Enables iris to pass a case of the fcc-write-after-clear piglit test,
[fast-clear tracking across layers 0 -> 1 -> (0,1)].
Fixes: 393f659ed8
("iris: Enable fast clears on other miplevels and layers than 0.")
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6973 >
2020-10-06 15:05:30 +00:00
Mike Blumenkrantz
c416adfb2d
anv: remove VkPipelineCacheCreateInfo::flags assert
...
flags are handled, so this just crashes for no reason
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7029 >
2020-10-06 10:29:33 -04:00
Lionel Landwerlin
9ad4b8b924
intel/dev: add a small non installable tool to print device info
...
Mostly for debug purposes.
$ ./build/src/intel/dev/intel_device_info
/dev/dri/renderD128:
name: Intel(R) UHD Graphics 620 (WHL GT2)
gen: 9
PCI id: 0x3ea0
revision: 2
slice0.subslice0: 11111111
slice0.subslice1: 11111111
slice0.subslice2: 11111111
slices: 1
subslices: 3
EUs: 24
EU threads: 168
LLC: 1
threads per EU: 7
L3 banks: 4
max VS threads: 336
max TCS threads: 336
max TES threads: 336
max GS threads: 336
max WM threads: 256
max CS threads: 56
timestamp frequency: 12000000
v2: Missing license (Marcin)
Fix stderr usage (Marcin)
v3: Reformat topology printing (Marcin)
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Reviewed-by: Marcin Ślusarz <marcin.slusarz@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6957 >
2020-10-06 12:31:16 +00:00
Mike Blumenkrantz
61c095f09a
zink: enable pipe caps for ARB_timer_query
...
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6923 >
2020-10-06 12:17:31 +00:00