Corentin Noël
edc56f944a
zink: Initialize pipe_query_result
...
Avoid reading garbage from memory.
Found by the clang static analyzer
Signed-off-by: Corentin Noël <corentin.noel@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27259 >
2024-01-29 21:49:50 +00:00
Corentin Noël
66cc73a304
zink: Initialize zink_bindless_descriptor to zero on creation
...
Make sure to have all fields to 0 as we are then using pipe_resource_reference
on some of its fields.
Fix defect reported by Coverity Scan.
Uninitialized pointer read
Incorrect values could be read from, or even written to, an arbitrary memory location, causing incorrect computations.
CID: 1520759
Signed-off-by: Corentin Noël <corentin.noel@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27259 >
2024-01-29 21:49:50 +00:00
Corentin Noël
3f0af613d0
zink: Initialize zink_shader_object
...
Fix defect reported by Coverity Scan.
Uninitialized scalar variable
The variable will contain an arbitrary value left from earlier computations.
CID: 1528166
Signed-off-by: Corentin Noël <corentin.noel@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27259 >
2024-01-29 21:49:50 +00:00
Sil Vilerino
9710fca612
frontends/va, d3d12: Fix PIPE_VIDEO_SLICE_MODE_MAX_SLICE_SICE -> PIPE_VIDEO_SLICE_MODE_MAX_SLICE_SIZE typo
...
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27342 >
2024-01-29 20:19:42 +00:00
Marek Olšák
e28d52e761
gallium/hud: add "csv" option to print values to stdout as CSV
...
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27247 >
2024-01-29 19:40:46 +00:00
Marek Olšák
0f79f9ac4d
glthread: apply the thread scheduling policy when a batch executes synchronously
...
before this, when no batch was executed asynchronously, the policy wasn't
applied
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27247 >
2024-01-29 19:40:46 +00:00
Marek Olšák
c8c926d776
glthread: apply the thread scheduling policy when the context is created
...
instead of after 128 batches
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27247 >
2024-01-29 19:40:46 +00:00
Marek Olšák
787ddadf73
util: add mesa_pin_threads environment variable that sets a static affinity mask
...
This is required for deterministic benchmark results.
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27247 >
2024-01-29 19:40:46 +00:00
Marek Olšák
ea08690d1c
st/mesa: rename ST_L3_PINNING_DISABLED -> ST_THREAD_SCHEDULER_DISABLED
...
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27247 >
2024-01-29 19:40:46 +00:00
Marek Olšák
386822c1b0
gallium: rename PIPE_.._PIN_THREADS_TO_L3_CACHE -> .._UPDATE_THREAD_SCHEDULING
...
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27247 >
2024-01-29 19:40:46 +00:00
Marek Olšák
d230434ae3
mesa,gallium: move the thread scheduler to src/util
...
The only change in behavior is that setting the affinity mask is skipped
when it has no effect, which happens when the app thread hasn't been moved
under a different L3 cache by the kernel (the sched_state variable tracks
that). This improves performance because setting the affinity mask incurs
measurable CPU overhead even if it has no effect.
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27247 >
2024-01-29 19:40:46 +00:00
Collabora's Gfx CI Team
1c29869c20
Uprev Piglit to e9316bcd12544aaf7e753ce37fe50d64165d9598
...
f7db20b03d...e9316bcd12
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25449 >
2024-01-29 18:27:07 +00:00
Eric Engestrom
2d290eda36
Reapply "bin/ci: Add GitLab basic token validation"
...
This reverts commit e39fed5737
.
One change from the original commit (cd8b546205
):
- in `validate_gitlab_token()`, `raise ValueError` was replaced with
`return False`.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27331 >
2024-01-29 18:21:29 +00:00
Jesse Natalie
24f14bfacc
dzn: Add missing blit source barriers for enhanced barriers
...
I was under the impression these would never be needed, since the source
should already be in the right GENERIC_READ layout, but when resolving
rendering attachments with a blit, the source is still in the layout that
it was in at the end of rendering.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27313 >
2024-01-29 17:46:11 +00:00
Jesse Natalie
f91ac2ff41
dzn: Add missing condition to immutable sampler init loop
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27313 >
2024-01-29 17:46:11 +00:00
Jesse Natalie
fd89ca82a6
dzn: Add a stencil blit fallback
...
Not all D3D hardware supports specifying the stencil ref value from the
pixel shader. For such hardware, stencil blits need to do the awful
8-pass one-bit-per-pass discard-to-not-write blit approach.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27313 >
2024-01-29 17:46:11 +00:00
Jesse Natalie
5cdcb7134a
microsoft/compiler: Use double pack/unpack instead of int for reduce ops on doubles
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27313 >
2024-01-29 17:46:11 +00:00
David (Ming Qiang) Wu
b75ee1a067
frontends/va: make vlVaSyncSurface blocking
...
According to VA documentation, vaSyncSurface should block,
so this mapping function vlVaSyncSurface is changed to be blocking.
add vlVaSyncSurface2 which can be used as non-blocking version.
Signed-off-by: David (Ming Qiang) Wu <David.Wu3@amd.com >
Reviewed-by: Boyuan Zhang <Boyuan.Zhang@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27309 >
2024-01-29 14:02:47 +00:00
Lionel Landwerlin
c4b32f9e90
docs/features: synchronize new features for Anv
...
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Acked-by: Tapani Pälli <tapani.palli@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27325 >
2024-01-29 10:35:32 +00:00
Lionel Landwerlin
c258e02e66
docs/features: drop gen8+/gen9+ on Anv
...
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Acked-by: Tapani Pälli <tapani.palli@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27325 >
2024-01-29 10:35:31 +00:00
Samuel Pitoiset
dc1b16c010
radv: export alpha-to-coverage via MRTZ for ESO on GFX11
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27236 >
2024-01-29 09:47:01 +00:00
Samuel Pitoiset
6a2b264526
radv: emit more default states for ESO on GFX10.3+
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27236 >
2024-01-29 09:47:01 +00:00
Samuel Pitoiset
b7fdfdc901
radv: do not ignore RADV_DYNAMIC_FRAGMENT_SHADING_RATE for ESO on GFX10.3+
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27236 >
2024-01-29 09:47:01 +00:00
Samuel Pitoiset
9a7c551f95
radv: set NGG fields in vgt_shader_key for ESO on GFX10+
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27236 >
2024-01-29 09:47:01 +00:00
Samuel Pitoiset
70c288558a
radv: fix the late scissor emission workaround with ESO on GFX9
...
graphics_pipeline is NULL when ESO is used.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27236 >
2024-01-29 09:47:01 +00:00
Samuel Pitoiset
411e23e193
radv: use the non-emitted graphics pipeline for the needed dynamic states
...
This is similar but it will allow us to re-use the helper for the
late scissor bug on GFX9.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27236 >
2024-01-29 09:47:01 +00:00
Samuel Pitoiset
bbcdd1dc09
radv: refactor gfx103_pipeline_emit_vrs_state()
...
For using it with ESO.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27236 >
2024-01-29 09:47:01 +00:00
Samuel Pitoiset
e7b4dcd522
radv: refactor gfx103_pipeline_emit_vgt_draw_payload_cntl()
...
For using it with ESO.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27236 >
2024-01-29 09:47:01 +00:00
Gert Wollny
5ccc40cbd5
ci: Upref virglrenderer
...
Signed-off-by: Gert Wollny <gert.wollny@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27106 >
2024-01-29 09:01:26 +00:00
Gert Wollny
b9fea5ea6b
virgl: Use better reporting for mirror_clamp features
...
Fixes: 9efe50c83b
virgl: report MIRROR_CLAMP features better
Signed-off-by: Gert Wollny <gert.wollny@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27106 >
2024-01-29 09:01:26 +00:00
Lionel Landwerlin
fe19405c46
vulkan/runtime: handle new dynamic states for attachment remapping
...
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27307 >
2024-01-29 08:24:14 +00:00
Samuel Pitoiset
0105cfd93c
radv/ci: enable RADV_PERFTEST=shader_object for vkcts-polaris10-valve
...
This now runs +571k tests for ESO in ~34 minutes compared to ~30 minutes
without shader_object support. Definitely acceptable for a manual job.
Note that the next VKCTS uprev will reduce the number of ESO tests by
a lot because most of them weren't useful for coverage.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27139 >
2024-01-29 07:50:39 +00:00
Samuel Pitoiset
c68f96878c
radv: fix segfault when getting device vm fault info
...
pFaultInfo can be NULL.
Fixes: 8097becc7f
("radv: add initial VK_EXT_device_fault support")
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27292 >
2024-01-29 07:26:28 +00:00
Eric Engestrom
e39fed5737
Revert "bin/ci: Add GitLab basic token validation"
...
This validation code has 2 bugs, the main one being that it is wrong and
is refusing perfectly valid codes. Let's remove this until we come up
with a valid check.
This reverts commit cd8b546205
.
Fixes: cd8b546205
("bin/ci: Add GitLab basic token validation")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27312 >
2024-01-29 01:44:43 +00:00
Hans-Kristian Arntzen
2f4d6df372
wsi/common: Allow KHR_present_wait on WL.
...
The fallback in place ensures a good enough solution.
Signed-off-by: Hans-Kristian Arntzen <post@arntzen-software.no >
Reviewed-by: Joshua Ashton <joshua@froggi.es >
Reviewed-by: Sebastian Wick <sebastian.wick@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27275 >
2024-01-28 23:14:36 +00:00
Hans-Kristian Arntzen
0d51cd4808
wsi/wl: Improve fallback for present_wait.
...
When presentation feedback protocol is not supported,
fallback to using frame callbacks.
In some sense, frame callbacks functions like
present complete + latch delay, so it's a reasonable approach, given the
alternative.
Xwl uses frame callback for COMPLETE events, so it's not a new approach.
To guard against lack of forward progress guarantee,
add a timeout for present complete to avoid deadlocking applications.
Signed-off-by: Hans-Kristian Arntzen <post@arntzen-software.no >
Reviewed-by: Joshua Ashton <joshua@froggi.es >
Reviewed-by: Sebastian Wick <sebastian.wick@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27275 >
2024-01-28 23:14:36 +00:00
Hans-Kristian Arntzen
1af7f41174
wsi/wl: Refactor out code to update current present ID.
...
Signed-off-by: Hans-Kristian Arntzen <post@arntzen-software.no >
Reviewed-by: Joshua Ashton <joshua@froggi.es >
Reviewed-by: Sebastian Wick <sebastian.wick@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27275 >
2024-01-28 23:14:36 +00:00
Gert Wollny
820859a6ab
r600: lower dround_even also on hardware that supports fp64
...
Fixes: aed6a39c10
glsl: Retire dround lowering.
Signed-off-by: Gert Wollny <gert.wollny@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27329 >
2024-01-28 22:33:30 +00:00
David Heidelberg
324ddd0919
ci: Valve farm (Keywords location) works again
...
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27328 >
2024-01-28 21:45:18 +01:00
David Heidelberg
4a23b28623
ci/VK-GL-CTS: add patches to fix dEQP-VK.glsl.derivate crashes
...
Acked-by: Rob Clark <robdclark@chromium.org >
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27324 >
2024-01-28 20:41:37 +01:00
David Heidelberg
299aebaa55
ci: bump libdrm to 2.4.120
...
Acked-by: Rob Clark <robdclark@chromium.org >
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27324 >
2024-01-28 20:41:37 +01:00
David Heidelberg
7965483b4c
ci: disable Valve farm in Keywords
...
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27326 >
2024-01-28 20:36:20 +01:00
Max R
68b3b1573b
d3d10umd: Fix compilation
...
Commit eb20ef92
changed signature of cso_set_vertex_buffers.
But this change wasn't reflected in d3d10umd.
Update call to cso_set_vertex_buffers to fix it.
Fixes: eb20ef927
("gallium: remove unbind_trailing_count from set_vertex_buffers")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27238 >
2024-01-27 18:18:35 +00:00
Faith Ekstrand
55413e33dc
nvk: Disable all cbufs in nvk_queue_init_context_draw_state()
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27320 >
2024-01-27 17:54:19 +00:00
Faith Ekstrand
35bd36c1b0
nvk: Whitespace fixes
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27320 >
2024-01-27 17:54:19 +00:00
Faith Ekstrand
c4254f374f
nvk: Do a second submit to check for errors in the sync case
...
With NVK_DEBUG=push_sync, we signal and immediately wait on a syncobj
to better detect whitch push failed and then print it. However, the
syncobj wait itself isn't enough to check for errors. We have to try
pushing again. Adding an empty push lets us get errors immediately and
print the actually failing pushbuf to stderr.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27320 >
2024-01-27 17:54:19 +00:00
Thomas H.P. Andersen
38aba351f1
docs: update features.txt for nvk
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27297 >
2024-01-27 17:38:58 +00:00
Thomas H.P. Andersen
614e4269cf
nvk: promote load_store_op_none to KHR
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27297 >
2024-01-27 17:38:58 +00:00
Thomas H.P. Andersen
132b3a79f4
nvk: promote VK_EXT_line_rasterization to KHR
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27297 >
2024-01-27 17:38:58 +00:00
Thomas H.P. Andersen
da910fc2fd
nvk: promote VK_EXT_index_type_uint8 to KHR
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27297 >
2024-01-27 17:38:58 +00:00