Mike Blumenkrantz
349576d92f
nine: check return on resource_get_handle
...
this has a return code, and if it return false, this is probably an
exit condition
cc: mesa-stable
Reviewed-by: Dave Airlie <airlied@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17775 >
(cherry picked from commit 188721d6d3
)
2022-08-05 10:09:56 -07:00
Mike Blumenkrantz
0d7d35c84a
zink: fix return for PIPE_CAP_DEPTH_CLIP_DISABLE
...
this uses the extension now
Fixes: 21ea19d504
("zink: Always enable depth clamping, make depth clipping independent.")
Reviewed-by: Dave Airlie <airlied@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17775 >
(cherry picked from commit 721f33cd0f
)
2022-08-05 10:09:56 -07:00
Mike Blumenkrantz
1889d87783
zink: handle !half_pixel_center
...
the shader is already getting a -0.5,-0.5 bias, but the viewport also
needs to be shifted by 0.5 to match
cc: mesa-stable
Reviewed-by: Dave Airlie <airlied@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17775 >
(cherry picked from commit 55a4a6b8dc
)
Conflicts:
src/gallium/drivers/zink/zink_state.c
2022-08-05 10:09:55 -07:00
Mike Blumenkrantz
50e133465c
zink: handle unscaled depth bias from nine
...
nine uses this to pass unscaled units for depth bias, which means
the units must be scaled based on the format of the depth buffer
cc: mesa-stable
Reviewed-by: Dave Airlie <airlied@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17775 >
(cherry picked from commit 8a8edb310d
)
Conflicts:
src/gallium/drivers/zink/zink_screen.h
2022-08-05 10:06:14 -07:00
Mike Blumenkrantz
fdbabb07cf
zink: drop mode_changed check from linewidth/depthbias draw updates
...
this doesn't need to be updated on primtype change since it's always
set
cc: mesa-stable
Reviewed-by: Dave Airlie <airlied@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17775 >
(cherry picked from commit a912952c3e
)
2022-08-05 10:04:54 -07:00
Mike Blumenkrantz
71b113251d
zink: force a new framebuffer for clear_depth_stencil if the clear region is big
...
can't clear outside the framebuffer, so set a new one if necessary
Fixes: f1f08e3529
("zink: massively simplify zink_clear_depth_stencil")
Reviewed-by: Dave Airlie <airlied@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17775 >
(cherry picked from commit ff1fb9101f
)
2022-08-05 10:04:54 -07:00
Mike Blumenkrantz
0ee8821b83
zink: force flush clears on fb change if fb geometry changes
...
Fixes: 66ceea7ed9
("zink: lift clearing on fb state change up a level")
Reviewed-by: Dave Airlie <airlied@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17775 >
(cherry picked from commit 80364c4d19
)
2022-08-05 10:04:53 -07:00
Dylan Baker
3eda2a96a8
.pick_status.json: Update to 0a0205f045
2022-08-05 10:04:52 -07:00
pal1000
5c8aaa70e8
d3d12/dzn/spirv2dxil: Require version library
...
Fixes: b8328c9
("microsoft/compiler: Blacklist DXIL validator 1.6 from 20348 SDK")
Closes : #6952
Closes : #6959
v2: Always lookup version library on Windows
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17837 >
(cherry picked from commit ec46a85c4f
)
2022-08-04 11:33:21 -07:00
Mike Blumenkrantz
081fd3a4f4
zink: init cache_put program fence on program creation
...
re-initializing here might overwrite an existing cache_put job
cc: mesa-stable
Reviewed-by: Dave Airlie <airlied@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17225 >
(cherry picked from commit 3d58642984
)
2022-08-04 11:33:21 -07:00
Dave Airlie
08adb7bb9d
gallivm: fix printf hook for cached shaders.
...
I've noticed this before but never tracked it down, but it's annoying.
The printf hooks would crash with debug shaders when they were loaded
from the cache. This was because nothing was initing the printf hook
in the cached path so the global was never set.
No problems just always creating this afaics.
Fixes: 333ee94285
("gallivm: rework debug printf hook to use global mapping.")
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17867 >
(cherry picked from commit 4c0a7a169d
)
2022-08-04 11:33:21 -07:00
Eric Engestrom
c702465d56
bin/gen_release_notes.py: bump advertised vulkan version to 1.3
...
Fixes: df8ac77af8
("anv: Advertise Vulkan 1.3")
Fixes: 08c6f437cf
("radv: advertise Vulkan 1.3")
Signed-off-by: Eric Engestrom <eric@igalia.com >
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17759 >
(cherry picked from commit 446d2039cb
)
2022-08-04 11:33:21 -07:00
Mike Blumenkrantz
5e00b2d8a7
zink: use modifier feature flags during surface creation when necessary
...
cc: mesa-stable
Acked-by: Emma Anholt <emma@anholt.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17773 >
(cherry picked from commit 22eff86eaf
)
2022-08-04 11:33:21 -07:00
Mike Blumenkrantz
46fc1b37b5
zink: store VkFormatFeatureFlags on creation
...
Acked-by: Emma Anholt <emma@anholt.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17773 >
(cherry picked from commit fffd57ef61
)
2022-08-04 11:33:21 -07:00
Mike Blumenkrantz
5814485a10
zink: handle mutable swapchain images with dmabuf
...
if a non-kopper swapchain image supports srgb, add a VkImageFormatListCreateInfo
to permit srgb mutability and avoid violating spec
cc: mesa-stable
Acked-by: Emma Anholt <emma@anholt.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17773 >
(cherry picked from commit 28ee911ad6
)
2022-08-04 10:38:11 -07:00
Dylan Baker
16d299e40b
.pick_status.json: Update to 8e6bdb2ed3
2022-08-04 10:38:10 -07:00
Dylan Baker
f8367fc41e
VERSION: bump for 22.2.0-rc1
2022-08-03 11:11:03 -07:00
Dylan Baker
373b232675
VERSION: bump 22.3.0-devel
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17875 >
2022-08-03 17:16:14 +00:00
Emma Anholt
fcd96ce002
turnip: Use the GMEM CCU space for attachments when the stores won't.
...
Since the CCU only gets used for unaligned attachment stores or resolves
with the wrong formats, we can use that space for attachments in many
cases.
This gets two more of vk-5-normal's main renderpass's attachments to fit
in the next gmem_pixels increment, leaving 1 to go. Other renderpasses do
get better gmem_pixels, and a few get better tile sizes as a result, but
the fps increase from those looks to be <.2% at least.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16921 >
2022-08-03 16:54:15 +00:00
Emma Anholt
b8a334b547
turnip: Split the tiling config into separate layouts based on CCU usage.
...
We now choose between two (equal as of this commit) layouts based on
whether the renderpass's stores will use the CCU space, and assert that we
always know the chosen layout when we go using the gmem offsets.
This required making vkCmdClearAttachments in a secondary take the 3D path
instead of gmem blits, since secondaries only have to be compatible with
the primary's renderpass, rather than equal.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16921 >
2022-08-03 16:54:15 +00:00
Emma Anholt
a1db4fcab7
ci/freedreno: Update a630 s8 resolve xfails.
...
These tests are all only run in a full vk run. These removed ones were
fixed in https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17684
and I'm betting the bypass ones were pre-existing (we hadn't updated 630's
full vk run list for these new stencil tests, I belive -- my previous full
run update was just from one of the two jobs).
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16921 >
2022-08-03 16:54:15 +00:00
Connor Abbott
19418adfba
tu: Restore formatting of tu_clear_blit.c
...
Conflict resolution appears to have gone awry. Use my previous resolution
of that rebase instead.
Fixes: 89263fde20
("tu: Use common vk_image struct")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16921 >
2022-08-03 16:54:15 +00:00
Nanley Chery
6875e07538
iris: Dedent enum iris_depth_reg_mode
...
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17859 >
2022-08-03 15:31:10 +00:00
Nanley Chery
a75cd15b94
iris: Make the D16 reg mode single-sampled
...
Wa_14010455700 is dependent on the format and sample count, but our
code to track whether or not it had been applied was only dependent on
the format.
As a result, we failed to enable the workaround when an app used a D16
2xMSAA buffer, then a D16 1xMSAA buffer right afterwards.
Make the workaround tracking code sample-dependent to fix this.
Cc: mesa-stable
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17859 >
2022-08-03 15:31:10 +00:00
Nanley Chery
e7419c11ae
anv: Make the D16 reg mode single-sampled
...
Wa_14010455700 is dependent on the format and sample count, but our
code to track whether or not it had been applied was only dependent on
the format.
As a result, we failed to enable the workaround when an app used a D16
2xMSAA buffer, then a D16 1xMSAA buffer right afterwards.
Make the workaround tracking code sample-dependent to fix this.
Cc: mesa-stable
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17859 >
2022-08-03 15:31:10 +00:00
Alyssa Rosenzweig
a4a15f500c
nir/lower_idiv: Be less creative about signs
...
I'm sorry to whoever wrote this, but
(x - (int) (x < 0)) ^ -((int) (x < 0))
is not an acceptable way to write iabs.
Shader-db results on Intel Tiger Lake with lower_idiv enabled:
total instructions in shared programs: 21122548 -> 21122570 (<.01%)
instructions in affected programs: 2369 -> 2391 (0.93%)
helped: 2
HURT: 8
total cycles in shared programs: 791609360 -> 791608062 (<.01%)
cycles in affected programs: 114106 -> 112808 (-1.14%)
helped: 9
HURT: 1
If we make the Intel back-end less stupid, we get to 9/1 helped/HURT for
instructions as well but that's for a different MR.
Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com >
Reviewed-by: Jason Ekstrand <jason.ekstrand@collabora.com >
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17845 >
2022-08-03 14:24:38 +00:00
Mike Blumenkrantz
e13c9d2168
zink: combine loops for lazy descriptor program deinit
...
the bindless and push sets don't have update templates stored to
the program, so merging these loops avoids trying to destroy them
cc: mesa-stable
Reviewed-by: Dave Airlie <airlied@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17866 >
2022-08-03 12:24:46 +00:00
Mike Blumenkrantz
7450990558
zink: don't flag lazy push constant set dirty on batch change
...
this has its own flag
cc: mesa-stable
Reviewed-by: Dave Airlie <airlied@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17866 >
2022-08-03 12:24:46 +00:00
Mike Blumenkrantz
c7ef4f9735
zink: fix gfx program cache pruning with generated tcs
...
if the tcs was generated, then the prgram was added to the non-tcs cache,
which means deleting it from the tcs+tes cache will fail and then
context_destroy will explode
Fixes: 4123ee3c71
("zink: invoke descriptor_program_deinit for programs on context destroy")
Reviewed-by: Dave Airlie <airlied@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17866 >
2022-08-03 12:24:46 +00:00
Danylo Piliaiev
e1c89abd86
ir3: Never remove GS_HEADER_IR3 sysval input
...
Without GS header geometry shader is never invoked which may cause
issues if it has side-effects.
Fixes GL CTS tests running via Zink:
KHR-GL46.shader_image_load_store.multiple-uniforms
KHR-GL46.texture_cube_map_array.image_op_geometry_sh
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/6940
Signed-off-by: Danylo Piliaiev <dpiliaiev@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17771 >
2022-08-03 10:51:58 +00:00
Danylo Piliaiev
ed7814def7
ir3/ra: Always insert interval for precolored inputs
...
insert_dst checked whether dst is unused, however for precolored
inputs we always want to reserve a reg for them. Input could be
unused only if we explicitly want it.
Suggested-by: Connor Abbott <cwabbott0@gmail.com >
Signed-off-by: Danylo Piliaiev <dpiliaiev@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17771 >
2022-08-03 10:51:58 +00:00
Marek Olšák
ff8e52541d
radeonsi: move small prim precision computation out of si_emit_cull_state
...
to put it next to its only use and remove the structure fields
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Reviewed-by: Qiang Yu <yuq825@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17864 >
2022-08-03 00:57:16 +00:00
Marek Olšák
fa46f3d40e
radeonsi: move the no-AA small prim precision cull constant into an SGPR
...
This reduces the scalar load from vec4 to vec2.
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Reviewed-by: Qiang Yu <yuq825@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17864 >
2022-08-03 00:57:16 +00:00
Marek Olšák
788dce46a3
radeonsi: add a randomized blit test
...
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17864 >
2022-08-03 00:57:16 +00:00
Marek Olšák
a42be1efdc
radeonsi: allow texture_map to upload only 1 sample for MSAA instead of all
...
Reuse the level parameter to do that, which allows us to keep
the pipe_transfer size unchanged. It's kinda hacky, but it's the simplest
way to do it. This will be used by the blit test to initialize MSAA textures.
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17864 >
2022-08-03 00:57:16 +00:00
Marek Olšák
2afaedf1d6
radeonsi: make various blit functions non-static
...
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17864 >
2022-08-03 00:57:16 +00:00
Marek Olšák
f129db911b
radeonsi/gfx11: use a better workaround for the export conflict bug
...
This is recommended for better performance.
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17864 >
2022-08-03 00:57:16 +00:00
Marek Olšák
2ed9eb1b63
radeonsi/gfx11: enable shader prefetch except for initial chip revisions
...
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17864 >
2022-08-03 00:57:16 +00:00
Marek Olšák
a09d971007
radeonsi/gfx11: rename si_calc_inst_pref_size -> si_get_shader_prefetch_size
...
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17864 >
2022-08-03 00:57:16 +00:00
Marek Olšák
a791e7f37f
radeonsi/gfx11: skip code in si_update_shaders that has no effect
...
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17864 >
2022-08-03 00:57:16 +00:00
Marek Olšák
34196148c1
radeonsi/gfx11: use better PRIM_GRP_SIZE_GFX11 setting
...
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17864 >
2022-08-03 00:57:16 +00:00
Marek Olšák
23a1dca8c6
radeonsi/gfx11: set SAMPLE_MASK_TRACKER_WATERMARK = 15 and clean up
...
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17864 >
2022-08-03 00:57:16 +00:00
Marek Olšák
b1af36163c
radeonsi/gfx11: use correct VGT_TESS_DISTRIBUTION settings
...
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17864 >
2022-08-03 00:57:16 +00:00
Marek Olšák
28842d96df
radeonsi: cosmetic changes around do_hardware_msaa_resolve
...
- move gfx_level checking into the function
- rename the function
- call it in si_blit later
- set the SQTT event
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17864 >
2022-08-03 00:57:16 +00:00
Marek Olšák
b1b0a860a5
radeonsi: fold async_copy into the preceding conditional in si_blit
...
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17864 >
2022-08-03 00:57:16 +00:00
Marek Olšák
7f1485d5ea
radeonsi: move compute-related code from si_blit.c to si_compute_blit.c
...
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17864 >
2022-08-03 00:57:16 +00:00
Marek Olšák
3b7512cacf
radeonsi: check for 16-bit hw support instead of relying on options.fp16
...
options.fp16 can be true even when the hw doesn't support FP16.
options.fp16 should only affect the CAP because 16-bit ops can still be
used by internal shaders.
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17864 >
2022-08-03 00:57:16 +00:00
Marek Olšák
2847106b94
radeonsi: add need_fmask_expand parameter into si_decompress_subresource
...
This is required by MSAA image stores for internal compute blits.
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17864 >
2022-08-03 00:57:16 +00:00
Marek Olšák
9e9cc62912
radeonsi: follow shader_info.float_controls_execution_mode (mostly)
...
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17864 >
2022-08-03 00:57:16 +00:00
Marek Olšák
0482ff3158
radeonsi: don't do image stores with RGBX, L, LA, I, and SRGB formats
...
The only change in behavior is that RGBX stores now overwrite X, which is
what CB does and it's faster.
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17864 >
2022-08-03 00:57:16 +00:00