Iago Toral Quiroga
3f3c83a6b7
v3dv: handle VkPipelineCreateFlags2CreateInfoKHR
...
This is added with VK_KHR_maintenance5 to allow 64-bit
for pipeline creation flags.
The flags are backwards compatible so we don't need to
change the flag enum values by the new ones.
This patch also addresses a small issue where compute pipelines
where not initializing the flags field in the pipeline object.
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29449 >
2024-05-29 09:40:15 +00:00
Iago Toral Quiroga
5ff01962fc
v3dv: handle VkBufferUsageFlags2CreateInfoKHR
...
This is added with VK_KHR_maintenance5 to allow 64-bit
for buffer usage flags.
The flags are backwards compatible so we don't need to
change the flag enum values by the new ones.
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29449 >
2024-05-29 09:40:15 +00:00
Konstantin Seurer
b31919f36e
radv: Return a block from radv_replay_shader_arena_block
...
ret_block is only set to NULL.
Fixes: 28be0cc
("radv: Add locking to radv_replay_shader_arena_block")
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29455 >
2024-05-29 09:10:47 +00:00
Erik Faye-Lund
0f7bdc2d36
mesa/main: fixup indent
...
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29386 >
2024-05-29 06:41:03 +00:00
Erik Faye-Lund
e80201a685
mesa/main: prefer non-suffixed enums
...
These are the same enums, we're just sometimes using the old spelling.
Let's be consistent and use the non-EXT/ARB enums instead.
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29386 >
2024-05-29 06:41:03 +00:00
Erik Faye-Lund
a37333305b
mesa/main: do not return _REV format for uncompressed format
...
Instead of returning the wrong value, and then correct it later on,
let's just return the correct value right away.
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29386 >
2024-05-29 06:41:03 +00:00
Erik Faye-Lund
b9b4507faa
mesa/main: clean up switch statement
...
This groups the enums by return-value, and makes the table more
compact and easier to scan through.
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29386 >
2024-05-29 06:41:03 +00:00
Erik Faye-Lund
1ddd043273
mesa/main: clean up _mesa_uncompressed_format_to_type_and_comps
...
No callsites cares about the number of components any more, so let's
remove it. Rename and make it return a single enum instead of passing
return values through pointers while we're at it.
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29386 >
2024-05-29 06:41:03 +00:00
Erik Faye-Lund
d549d4fa82
mesa/main: rework GL_IMAGE_PIXEL_TYPE query
...
This used to depend on both _mesa_get_shader_image_format() and
_mesa_uncompressed_format_to_type_and_comps() doing a specific mapping
to behave like the spec requires. But only a small subset of what the
latter function does is needed, and that function is used for other
purposes where the needs are dictated by other means.
It's going to be easier to maintain this code if we use different
implementations for these two things.
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29386 >
2024-05-29 06:41:03 +00:00
Erik Faye-Lund
563b9786ce
mesa/main: remove unused function
...
This has been unused since 8ec6534b26
("mesa: Use _mesa_format_convert
to implement texstore_rgba."), from October 2014. It took us close to
10 years to notice that it's been unused. Let's remove it :)
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29386 >
2024-05-29 06:41:03 +00:00
Samuel Pitoiset
07a826ba93
radv: fix flushing DB meta cache on GFX11.5
...
Only GFX11 is affected by this hw bug.
Found by inspection.
Cc: mesa-stable
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29424 >
2024-05-29 06:21:17 +00:00
Mike Blumenkrantz
bc29d2c9fc
zink: add atomic image ops to the ms deleting pass
...
this otherwise results in nir validation errors
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/11209
Fixes: 90cf8d14d6
("zink: add a pass to strip out multisample storage image ops")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29383 >
2024-05-29 01:51:12 +00:00
Eric Engestrom
8e60f26016
vc4/ci: skip VK piglit tests
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29442 >
2024-05-28 20:24:44 +00:00
Valentine Burley
20f4cd88e1
tu: Advertise VK_KHR_maintenance6
...
Signed-off-by: Valentine Burley <valentine.burley@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28360 >
2024-05-28 20:02:50 +00:00
Valentine Burley
14d3dd8984
tu: Add support for version 2 of all descriptor binding commands
...
Signed-off-by: Valentine Burley <valentine.burley@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28360 >
2024-05-28 20:02:50 +00:00
Valentine Burley
94e2c6d000
tu: Add support for NULL index buffer
...
Signed-off-by: Valentine Burley <valentine.burley@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28360 >
2024-05-28 20:02:50 +00:00
Valentine Burley
7ac6aaf522
tu: Add support for VkBindMemoryStatusKHR
...
Signed-off-by: Valentine Burley <valentine.burley@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28360 >
2024-05-28 20:02:50 +00:00
Eric Engestrom
06f7407172
ci: disable debian-build-testing until it can be fixed
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29439 >
2024-05-28 19:28:08 +00:00
Jordan Justen
410ca6a3e9
Revert "anv: Disable Ray Tracing on xe2 until our compiler supports Xe2 RT"
...
This reverts commit 65684b0c7f
.
Reviewed-by: José Roberto de Souza <jose.souza@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29273 >
2024-05-28 18:45:49 +00:00
Jordan Justen
f1b502f8c7
anv/grl: Build for xe2
...
Signed-off-by: Jordan Justen <jordan.l.justen@intel.com >
Reviewed-by: José Roberto de Souza <jose.souza@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29273 >
2024-05-28 18:45:49 +00:00
Jordan Justen
4ffe1a9f9e
intel/brw: Fix SSBO/shared load offset register size for Xe2
...
Rework:
* Ken: Reword commit message
Signed-off-by: Jordan Justen <jordan.l.justen@intel.com >
Reviewed-by: Sagar Ghuge <sagar.ghuge@intel.com >
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29273 >
2024-05-28 18:45:49 +00:00
Jordan Justen
4bc4da01f4
intel/brw: Allow xe2 in brw_stage_has_packed_dispatch()
...
Signed-off-by: Jordan Justen <jordan.l.justen@intel.com >
Reviewed-by: José Roberto de Souza <jose.souza@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29273 >
2024-05-28 18:45:49 +00:00
Jordan Justen
739613ec70
intel/brw: Simplify enabling brw_fs_test_dispatch_packing
...
Signed-off-by: Jordan Justen <jordan.l.justen@intel.com >
Reviewed-by: Francisco Jerez <currojerez@riseup.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29273 >
2024-05-28 18:45:49 +00:00
Jordan Justen
aa152ef431
anv/grl: Set INTEL_FORCE_PROBE=* when running intel_clc
...
In order to build grl, we need to get the device_info struct from the
PCI ID, but for pre-production platforms we don't want to enable them
unless INTEL_FORCE_PROBE is set.
Setting it when running intel_clc allows us to get the device_info
struct when the pre-production hardware is not ready to be enabled by
default.
Signed-off-by: Jordan Justen <jordan.l.justen@intel.com >
Reviewed-by: José Roberto de Souza <jose.souza@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29273 >
2024-05-28 18:45:49 +00:00
Jordan Justen
2217cff68a
pci_ids/intel: Add LNL PCI IDs (with FORCE_PROBE set)
...
Signed-off-by: Jordan Justen <jordan.l.justen@intel.com >
Reviewed-by: José Roberto de Souza <jose.souza@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29273 >
2024-05-28 18:45:49 +00:00
Jordan Justen
845ca72a14
intel/dev: Add LNL device info
...
Reworks:
* José: Disable has_integer_dword_mul support (BSpec 56800)
* Rohan: Set has_indirect_unroll
* José: Add PAT settings
* Jianxun: Set has_flat_ccs
Signed-off-by: Jordan Justen <jordan.l.justen@intel.com >
Co-authored-by: José Roberto de Souza <jose.souza@intel.com >
Co-authored-by: Rohan Garg <rohan.garg@intel.com >
Co-authored-by: Jianxun Zhang <jianxun.zhang@intel.com >
Reviewed-by: José Roberto de Souza <jose.souza@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29273 >
2024-05-28 18:45:49 +00:00
Jordan Justen
4beab24d69
docs: Document INTEL_FORCE_PROBE env-var
...
Signed-off-by: Jordan Justen <jordan.l.justen@intel.com >
Reviewed-by: José Roberto de Souza <jose.souza@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29273 >
2024-05-28 18:45:49 +00:00
Jordan Justen
237d9e7c45
intel/dev: Support INTEL_FORCE_PROBE env-var
...
This environment variable allows some Intel devices that are
unsupported to be forced to run. These devices have incomplete
support, and therefore might not work at all.
Reworks:
* José: Simplify scan_for_force_probe() with strtok()
Signed-off-by: Jordan Justen <jordan.l.justen@intel.com >
Reviewed-by: José Roberto de Souza <jose.souza@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29273 >
2024-05-28 18:45:49 +00:00
Jordan Justen
c967b38c7c
intel/dev: Allow setting FORCE_PROBE for intel PCI IDs
...
For example:
CHIPSET(0x56a0, dg2_g10, "DG2", "Intel(R) Arc(tm) A770 Graphics", FORCE_PROBE)
For now if a PCI ID has FORCE_PROBE set, then we refuse to start the
device.
Signed-off-by: Jordan Justen <jordan.l.justen@intel.com >
Reviewed-by: José Roberto de Souza <jose.souza@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29273 >
2024-05-28 18:45:49 +00:00
Iván Briano
8d098ecfea
anv: check cmd_buffer is on a transfer queue more properly
...
The queueFlags of the associated queue may have more flags than just the
type of queue it is, based on what that queue supports, like sparse or
protected content. Check that the queue is a blitter engine instead.
Fixes a bunch of dEQP-VK.api.copy_and_blit.core.*_transfer on MTL with
ANV_SPARSE=0
Fixes: 17b8b2cffd
("anv: Add support for a transfer queue on Alchemist")
Reviewed-by: Sagar Ghuge <sagar.ghuge@intel.com >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29336 >
2024-05-28 18:25:16 +00:00
Eric Engestrom
e6d9201c6c
v3dv/ci: fix typo in renderer_check
...
Fixes: 993dd0832f
("rpi4/ci: use deqp-runner suite for vk job as well")
Fixes: c0e6a72b00
("rpi5/ci: use deqp-runner suite for vk job")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29412 >
2024-05-28 18:04:22 +00:00
Eric Engestrom
dc3bc70899
.mailmap: fix email address for @cpmichael
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29437 >
2024-05-28 16:31:23 +00:00
Boris Brezillon
76047bfa5e
pan/jc: Drop unused pool argument passed to pan_jc_add_job()
...
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com >
Reviewed-by: Mary Guillemard <mary.guillemard@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29382 >
2024-05-28 16:03:30 +00:00
Boris Brezillon
443fe41ad2
pan/desc: Add missing format in translate_s_format()
...
Vulkan stencil image views of combined stencil Z32_S8 buffers can result
in a PIPE_FORMAT_X32_S8X24_UINT format being passed to the stencil view.
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com >
Reviewed-by: Mary Guillemard <mary.guillemard@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29382 >
2024-05-28 16:03:30 +00:00
Boris Brezillon
586e427b78
pan/decode: Be robust to NULL texture payload
...
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com >
Reviewed-by: Mary Guillemard <mary.guillemard@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29382 >
2024-05-28 16:03:30 +00:00
Boris Brezillon
20d25b9f07
panvk: Make sure we dump memory mappings before crashing
...
Kinda useful when we want to debug things.
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com >
Reviewed-by: Mary Guillemard <mary.guillemard@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29382 >
2024-05-28 16:03:30 +00:00
Boris Brezillon
47a1daa6da
panvk: Kill cmd_get_tiler_context()
...
cmd_prepare_tiler_context() is just a wrapper around
cmd_get_tiler_context(), and cmd_get_tiler_context() is only called
from cmd_prepare_tiler_context().
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com >
Reviewed-by: Mary Guillemard <mary.guillemard@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29382 >
2024-05-28 16:03:30 +00:00
Boris Brezillon
f57fac8d37
panvk: Use vk_pipeline_shader_stage_to_nir()
...
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com >
Reviewed-by: Mary Guillemard <mary.guillemard@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29382 >
2024-05-28 16:03:30 +00:00
Boris Brezillon
f21c163baa
panvk: Clean Midgard leftovers in the cmd_close_batch() path
...
pan_preload_fb() will use pre-frames on Bifrost. Pass NULL preload_jobs
and assert that num_preload_jobs is zero.
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com >
Reviewed-by: Mary Guillemard <mary.guillemard@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29382 >
2024-05-28 16:03:30 +00:00
Erik Faye-Lund
dd8fb7139d
mesa/main: rewrite mipmap generation code
...
The old mipmap generation code has a few problems:
1. It open-codes the format conversion, which is error prone, and it's
hard to know if we're missing some formats. Manual inspection shows
that we're indeed missing some less commonly used formats.
2. When downsampling between two miplevels with the same width (e.g a
width of one), the code would read from outside the image.
3. It averages sRGB textures in gamma space. Whilte that's legal in GL
(the filtering algorithm is undefined), it doesn't produce very good
results. And it's not the same thing as util_gen_mipmap() does.
4. Similarly, it uses a box-filter for the stencil values. And while
that's actually what the spec recomments (regardless of format), it's
absolutely *not* what most applications would want. Using nearest
sampling would make more sense.
5. It has requirements about the type and format returned by
_mesa_uncompressed_format_to_type_and_comps() which other call-sites
in mesa doesn't have. This is the real reason I want to get rid of
it, because it ends up complicating the GLES read formats / types.
So, let's rewrite all of this, fixing all of the above. The result is
quite a bit shorter, and if this ends up being less performant, it's
unlikely that this matters, because we almost always use the GPU
accelerated code-path provided by util_gen_mipmap() anyway.
The new code works by a few identities: It uses the pack / unpack
helpers to convert the texture to a few reasonable intermediate formats,
so we keep the amount of open-coded averaging to a minimum. To do this
without heap-allocations, we introduce a concept of a "span", which has
a max fixed size, that can trivially be allocated on the stack.
We also add some more requirements to keep things sane; the higher level
do_row functions only allow the dest image to be half of the source
width or one (whichever is larger). This matches the high-level needs of
mipmap generation. The lower level do_span() function is a bit more
flexible, because that turns out to be helpful when implementing
do_span_3D(), where we want to avoid collapsing the inner dimension
twice.
Tested-by: Eric R. Smith <eric.smith@collabora.com >
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29380 >
2024-05-28 15:04:14 +00:00
Erik Faye-Lund
cd37384985
util/format: correct a typo
...
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29380 >
2024-05-28 15:04:14 +00:00
Rohan Garg
6fc6f95e90
intel/genxml: Update STATE_COMPUTE_MODE for Xe2
...
Signed-off-by: Rohan Garg <rohan.garg@intel.com >
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29264 >
2024-05-28 14:42:19 +00:00
Rohan Garg
f5a5c35717
intel/genxml: update MI_SEMAPHORE_WAIT for Xe2
...
Rework:
* José: Restore "Register Poll Mode" default to "Memory Poll"
* José: Other minor formatting changes to match other genxml
Signed-off-by: José Roberto de Souza <jose.souza@intel.com >
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29264 >
2024-05-28 14:42:19 +00:00
Rohan Garg
569a037fb1
intel/genxml: Update XY_BLOCK_COPY_BLT
...
Signed-off-by: Rohan Garg <rohan.garg@intel.com >
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29264 >
2024-05-28 14:42:19 +00:00
Rohan Garg
26e78f83bb
intel/genxml: update CFE_STATE for LNL
...
Signed-off-by: Rohan Garg <rohan.garg@intel.com >
Reviewed-by: José Roberto de Souza <jose.souza@intel.com >
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29264 >
2024-05-28 14:42:19 +00:00
Rohan Garg
7001134246
isl: enable compression for CPS buffers on xe2+
...
Signed-off-by: Rohan Garg <rohan.garg@intel.com >
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29264 >
2024-05-28 14:42:19 +00:00
Rohan Garg
b9c68883c4
intel/genxml: update 3DSTATE_CPSIZE_CONTROL_BUFFER for xe2+
...
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29264 >
2024-05-28 14:42:19 +00:00
Rohan Garg
bd09649750
intel/genxml: add the new state byte stride instruction
...
Signed-off-by: Rohan Garg <rohan.garg@intel.com >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29264 >
2024-05-28 14:42:19 +00:00
Jordan Justen
17b6db893b
intel/genxml: Update 3DSTATE_BTD for xe2
...
Reworks:
- Rohan: 3DSTATE_BTD can also be emitted on the CCS
Signed-off-by: Jordan Justen <jordan.l.justen@intel.com >
Reviewed-by: Rohan Garg <rohan.garg@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29264 >
2024-05-28 14:42:19 +00:00
Jordan Justen
5709bbe033
intel/genxml: Add XY_FAST_COLOR_BLT for xe2
...
Reworks:
- Rohan: Use a uint for the surface format since we're dropping the
SURFACE_FORMAT enum from genxml
Signed-off-by: Jordan Justen <jordan.l.justen@intel.com >
Reviewed-by: Rohan Garg <rohan.garg@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29264 >
2024-05-28 14:42:19 +00:00