Karol Herbst
d460cb3675
rusticl/mesa: add missing files to meson.build
...
Reviewed-by: Adam Jackson <ajax@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32821 >
2025-01-03 18:26:19 +00:00
Karol Herbst
f3f84cfe9f
rusticl/mesa/context: use Default for pipe_grid_info initialization
...
Reviewed-by: Adam Jackson <ajax@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32821 >
2025-01-03 18:26:19 +00:00
Karol Herbst
a4cae3c6ed
rusticl/device: remove unused functions
...
Reviewed-by: Adam Jackson <ajax@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32821 >
2025-01-03 18:26:19 +00:00
Karol Herbst
05b37f3968
rusticl/mem: remove mem_type argument from new_image
...
Reviewed-by: Adam Jackson <ajax@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32821 >
2025-01-03 18:26:19 +00:00
Karol Herbst
4cbd4bead7
rusticl/mesa: remove PipeTransfer::res
...
The pipe_transfer struct already stores a pointer to the pipe_resource, so
no need to store it inside the Rust wrapper as well.
Reviewed-by: Adam Jackson <ajax@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32821 >
2025-01-03 18:26:19 +00:00
Karol Herbst
f667845741
include: Update the OpenCL headers to latest
...
A few breaking changes in rusticl which this also fixes.
Reviewed-by: Adam Jackson <ajax@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32821 >
2025-01-03 18:26:19 +00:00
Karol Herbst
f75ba4f9e3
rusticl: stop using system headers for CL and GL
...
Cc: mesa-stable
Reviewed-by: Adam Jackson <ajax@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32821 >
2025-01-03 18:26:19 +00:00
Karol Herbst
ccfeda77bd
rusticl/queue: add a life check to prevent applications dead locking
...
Cc: mesa-stable
Reviewed-by: Adam Jackson <ajax@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32821 >
2025-01-03 18:26:19 +00:00
Dylan Baker
f70ef03100
docs: update calendar for 24.3.3
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32870 >
2025-01-03 10:00:51 -08:00
Dylan Baker
d518c59b9d
docs: Add SHA sums to 24.3.3 release notes
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32870 >
2025-01-03 10:00:48 -08:00
Dylan Baker
0861975f49
docs: add release notes for 24.3.3
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32870 >
2025-01-03 10:00:47 -08:00
Vinson Lee
3514b65c35
hk: Fix hk_ia_update arguments order
...
Fix defect reported by Coverity Scan.
Arguments in wrong order (SWAPPED_ARGUMENTS)
swapped_arguments: The positions of arguments in the call to
hk_ia_update do not match the ordering of the parameters:stat_c_inv is
passed to c_prims.stat_c_prims is passed to c_inv.
Fixes: a3b796ba19
("libagx,hk: handle pipeline stats queries without a GS")
Signed-off-by: Vinson Lee <vlee@freedesktop.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32853 >
2025-01-03 17:14:48 +00:00
Erik Faye-Lund
eac8f1d460
Revert "panfrost: Disable CRC by default"
...
There's been a bunch of CRC fixes applied recently. Let's see if this
allows us to default to this as enabled instead.
This reverts commit fc30fe5bc5
.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31965 >
2025-01-03 12:12:15 +00:00
Lionel Landwerlin
1448778385
anv: rework tbimr push constant workaround
...
We'll want to know about the empty push constant for device generated
commands. It's easier if the information is stored in
anv_pipeline_bind_map::push_ranges[].
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Reviewed-by: José Roberto de Souza <jose.souza@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32828 >
2025-01-03 11:48:42 +00:00
Lionel Landwerlin
6281b207db
anv: add tracepoints timestamp mode for empty dispatches
...
When the runtime is going to potentially emit no dispatch, we need to
have a way to capture a timestamp. Add a new flag for this to tell
whether we don't have a HW instruction to capture the timestamp and
rely on MI_STORE_REGISTER_MEM instead.
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Fixes: de00fe3f66
("anv: add BVH building tracking through u_trace")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/12382
Reviewed-by: Sagar Ghuge <sagar.ghuge@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32835 >
2025-01-03 10:36:49 +00:00
Lionel Landwerlin
a224105a26
vulkan/runtime: avoid emitting empty build_leaves
...
Seen in GravityMark.
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Reviewed-by: Sagar Ghuge <sagar.ghuge@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32835 >
2025-01-03 10:36:49 +00:00
Zoltán Böszörményi
2b9b34887e
docs/features: Mark more Vulkan 1.4 features as done for drivers
...
For nvk: VK_KHR_global_priority
For lvp: VK_KHR_global_priority, VK_KHR_index_type_uint8,
VK_KHR_line_rasterization, VK_KHR_load_store_op_none,
VK_KHR_shader_float_controls2, VK_KHR_shader_subgroup_rotate,
VK_KHR_vertex_attribute_divisor, VK_EXT_host_image_copy and
VK_EXT_pipeline_robustness.
Signed-off-by: Zoltán Böszörményi <zboszor@gmail.com >
Reviewed-by: Valentine Burley <valentine.burley@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32801 >
2025-01-03 10:20:27 +00:00
Zoltán Böszörményi
43eaba013e
docs/features: Mark VK_EXT_host_image_copy as implemented on Turnip
...
Signed-off-by: Zoltán Böszörményi <zboszor@gmail.com >
Reviewed-by: Valentine Burley <valentine.burley@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32801 >
2025-01-03 10:20:27 +00:00
Zoltán Böszörményi
a0931e3361
features.txt: Add Vulkan 1.4 section
...
Some extensions were moved to core.
See https://docs.vulkan.org/spec/latest/appendices/versions.html
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/12392
Signed-off-by: Zoltán Böszörményi <zboszor@gmail.com >
Reviewed-by: Valentine Burley <valentine.burley@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32801 >
2025-01-03 10:20:27 +00:00
Valentine Burley
5fd9f08c1d
lavapipe/ci: Re-enable lavapipe-vk-asan
...
The previous issues have been resolved, and the only error the
job encountered was due to incorrect expectations.
Signed-off-by: Valentine Burley <valentine.burley@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32832 >
2025-01-03 10:02:05 +00:00
Samuel Pitoiset
03b037a0e3
radv: disable logic op for float/srgb formats
...
The Vulkan spec says:
"The application can enable a logical operation between the
fragment’s color values and the existing value in the framebuffer
attachment. This logical operation is applied prior to updating
the framebuffer attachment. Logical operations are applied only
for signed and unsigned integer and normalized integer
framebuffers. Logical operations are not applied to floating-point
or sRGB format color attachments."
Missing VKCTS coverage has been reported.
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/12345
Cc: mesa-stable
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32826 >
2025-01-03 09:35:45 +00:00
Samuel Pitoiset
0019900312
radv/meta: do not create redundant pipeline layout objects
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32834 >
2025-01-03 09:11:59 +00:00
Samuel Pitoiset
105e809a9d
radv/meta: add radv_meta_get_noop_pipeline_layout()
...
To avoid duplicated objects.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32834 >
2025-01-03 09:11:59 +00:00
Samuel Pitoiset
dd7343f278
radv/meta: reduce length of some cache keys
...
For faster hashing.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32834 >
2025-01-03 09:11:59 +00:00
Samuel Pitoiset
c8d2614113
radv/meta: fix loading the meta pipeline cache
...
This has been removed by mistake.
Fixes: f528c9e8f5
("radv/meta: stop initializing RT accel structs")
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32838 >
2025-01-03 08:49:42 +00:00
Samuel Pitoiset
370e392313
radv: fix adding the BO to cmdbuf list when emitting buffer markers
...
Found by inspection.
Cc: mesa-stable
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32840 >
2025-01-03 08:19:23 +00:00
Benjamin Lee
ff2a214e5f
panfrost: specialize VS on FS interpolation qualifiers
...
This re-enables noperspective varying support for OpenGL. Because VS may
depend on FS, we now need to wait for both VS and FS to be available
before compiling shaders, and need to update VS when a new FS is bound.
Signed-off-by: Benjamin Lee <benjamin.lee@collabora.com >
Reviewed-by: Eric R. Smith <eric.smith@collabora.com >
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32127 >
2025-01-03 07:04:05 +00:00
Benjamin Lee
bbd268d22c
panfrost: factor FS shader key into a helper function
...
This will make things easier to follow with the addition of a VS key.
Signed-off-by: Benjamin Lee <benjamin.lee@collabora.com >
Reviewed-by: Eric R. Smith <eric.smith@collabora.com >
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32127 >
2025-01-03 07:04:05 +00:00
Benjamin Lee
d93f9d6d1a
panvk: use static noperspective when statically linking VS and FS
...
This triggers with VK_EXT_graphics_pipeline_library and monolithic
pipelines when VK_PIPELINE_CREATE_LINK_TIME_OPTIMIZATION_BIT_EXT is set.
With VK_EXT_shader_object, it would trigger when
VK_SHADER_CREATE_LINK_STAGE_BIT_EXT is set on both VS and FS.
The fast-linking interface from [1] (unmerged) would allow us to use the
optimization with monolithic pipelines.
[1]: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27024/diffs?commit_id=cd1ba4d6375764680c5ced9be90f5519b92eefe6
Signed-off-by: Benjamin Lee <benjamin.lee@collabora.com >
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32127 >
2025-01-03 07:04:05 +00:00
Benjamin Lee
98de4f42ff
panfrost: add pass to lower noperspective varyings to a constant
...
This isn't hooked up yet, but should be a significant performance
improvement when available.
Signed-off-by: Benjamin Lee <benjamin.lee@collabora.com >
Reviewed-by: Mary Guillemard <mary.guillemard@collabora.com >
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32127 >
2025-01-03 07:04:05 +00:00
Benjamin Lee
30a288cdc9
panvk: pass noperspective_varyings sysval as a push constant
...
This can handle mismatched interpolation qualifiers between VS and FS,
and is a conformant noperspective implementation. Passing this sysval
dynamically has a performance cost. In the future we can reduce this by
passing it as a constant in some situations.
Signed-off-by: Benjamin Lee <benjamin.lee@collabora.com >
Reviewed-by: Mary Guillemard <mary.guillemard@collabora.com >
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32127 >
2025-01-03 07:04:05 +00:00
Benjamin Lee
103c4123ab
panfrost: collect noperspective varyings in shader info
...
When linking FS and VS with mismatched interpolation qualifiers, we need
to read the FS qualifiers and pass them to the VS. I put
nir_collect_noperspective_varyings in a separate function instead of
merging it into the existing walk_varyings loop because it will later be
used on uncompiled shaders that don't have a pan_shader_info yet.
Signed-off-by: Benjamin Lee <benjamin.lee@collabora.com >
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32127 >
2025-01-03 07:04:05 +00:00
Benjamin Lee
081438ad39
panfrost: add nir pass to lower noperspective varyings
...
Mali only supports perspective-correct varying interpolation in
hardware, so we have to emulate noperspective with lowering in both the
VS and FS.
Both vulkan and opengl allow mismatched interpolation qualifiers between
stages. Because we need all varyings that are noperspective in the FS to
be lowered in the VS, we cannot rely on the interpolation qualifiers in
the VS. Loading the set of noperspective varyings as a sysval allows the
implementation to pass them as a compile-time constant when known
statically, or a runtime push constant when not. Passing noperspective
varyings dynamically has a performance cost with unnecessary branches
and fmuls.
This sysval is not hooked up yet in either panfrost or panvk, so shader
compilation will fail.
Signed-off-by: Benjamin Lee <benjamin.lee@collabora.com >
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32127 >
2025-01-03 07:04:05 +00:00
Benjamin Lee
6f541e2016
panfrost: add intrinsic to load frag coord at a barycentric
...
This is needed for noperspective lowering, where we need to multiply the
varying value by gl_FragCoord.w at the same barycentric as the varying.
Normal nir_load_frag_coord_zw instructions are lowered to the new
intrinsic on bifrost with the pan_lower_frag_coord_zw pass.
Signed-off-by: Benjamin Lee <benjamin.lee@collabora.com >
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32127 >
2025-01-03 07:04:05 +00:00
Marek Olšák
9033e64b02
util/disk_cache: silence unused result warnings
...
Reviewed-by: Adam Jackson <ajax@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32810 >
2025-01-03 02:03:06 +00:00
Marek Olšák
8c819a2f95
llvmpipe: silence an unused result warning
...
Reviewed-by: Adam Jackson <ajax@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32810 >
2025-01-03 02:03:06 +00:00
Marek Olšák
03d24e56a2
vulkan: silence an unused variable warning
...
Reviewed-by: Adam Jackson <ajax@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32810 >
2025-01-03 02:03:06 +00:00
David Rosca
3474978d52
radv: Fix sampling from image layers of video decode target
...
Video decode target needs custom height alignment, but tex descriptor
still needs to be set to the original size the image was created with.
This makes the descriptor wrong for layer > 0, so we need to calculate
the layer offset and add it to bo address for this case.
Fixes: 5deb476095
("radv: align video images internal width/height inside the driver.")
Reviewed-by: Dave Airlie <airlied@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32069 >
2025-01-03 01:28:07 +00:00
David Rosca
9d477fae68
radv/video: Remove dt_field_mode handling code
...
This would be used for decoding into interlaced buffer, but since
that's not support it is a dead code.
Reviewed-by: Dave Airlie <airlied@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32069 >
2025-01-03 01:28:07 +00:00
David Rosca
ca0cb78869
radv/video: Use correct array index for decode target and DPB images
...
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/12057
Cc: mesa-stable
Reviewed-by: Dave Airlie <airlied@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32069 >
2025-01-03 01:28:07 +00:00
David Rosca
8dabb480e2
radv/video: Fix DPB tier2 surface params
...
Fixes: 3e2c768aa8
("radv/vcn: enable dynamic dpb tier 2 for h264/h265 on navi21+")
Reviewed-by: Dave Airlie <airlied@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32069 >
2025-01-03 01:28:07 +00:00
Dylan Baker
d9429229cf
intel/tests: Fix missing assignment of error condition
...
Coverity notices that `err` might be used uninitialized, which is true
as we don't assign the value we want to check! Fix that assignment so
the EXPECT_EQ macro does what we expect.
CID: 1635272
Fixes: 6b931a68c7
("intel/common: Implement Xe KMD in mi_builder tests")
Reviewed-by: Caio Oliveira <caio.oliveira@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32849 >
2025-01-03 00:53:49 +00:00
Dylan Baker
5420fc16d6
intel/tests: Fix coverity warning about possibly leaked memory
...
If the assert were to fail the memory would leak, which is pretty
harmless in a unit test, but the fix is trivial.
CID: 1635429
Fixes: 6b931a68c7
("intel/common: Implement Xe KMD in mi_builder tests")
Reviewed-by: Caio Oliveira <caio.oliveira@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32849 >
2025-01-03 00:53:49 +00:00
Erik Faye-Lund
51a2f70e5e
panvk/ci: drop needless envvar
...
We no longer need this opt-in for v10 GPUs, so let's drop it.
Fixes: 976eb6825e
("panvk: do not require opt-in for panvk on v10")
Acked-by: Valentine Burley <valentine.burley@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32825 >
2025-01-02 23:08:27 +00:00
Erik Faye-Lund
2bb6db3fb3
docs: update panvk status
...
Two things happened since last update; we added support for
VK_KHR_shader_draw_parameters, and we fixed imageCubeArray for Bifrost
GPUs.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32763 >
2025-01-02 22:59:36 +00:00
Erik Faye-Lund
cf07e89d06
docs/ci: treat warnings as errors
...
When we moved building the docs to Meson, we accidentally dropped the -W
flag that we used to have. This lead to us no longer detecting certain
problems in the docs, which is unfortunate.
Let's bring this back gated by the werror meson-option, and wire that up
on the CI end.
Fixes: fdd204538b
("ci: build docs using meson")
Reviewed-by: Dylan Baker <None>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32831 >
2025-01-02 21:33:51 +00:00
Erik Faye-Lund
7a8c46f54c
docs: fixup link in radv docs
...
This is not how to add links, this is how to use the default-role. Let's
correct it.
Fixes: 3ba3e00750
("radv: Add some documentation.")
Reviewed-by: Dylan Baker <None>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32831 >
2025-01-02 21:33:51 +00:00
Erik Faye-Lund
46ccc13691
docs: fixup broken markup
...
We need an empty line after ".. code-block: [...]", otherwise the first
lines are interpreted as arguments, not content. This makes the entire
code-blocks not render at all.
Fixes: 5d6d67a4d1
("docs/android: improve documentation about building llvmpipe for Android")
Reviewed-by: Dylan Baker <None>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32831 >
2025-01-02 21:33:51 +00:00
Mel Henning
c273ada502
compiler/rust/bitset: Test next_unset()
...
Reviewed-by: Mary Guillemard <mary.guillemard@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32812 >
2025-01-02 20:52:48 +00:00
Mel Henning
2bcb950865
compiler/rust/bitset: Don't expose words
...
This encapsulates the bitset's word size and word count, which means
consumers no longer need to be careful about word count. Users of the old
apis for writing expressions on bit sets should migrate to the new expression
API.
Reviewed-by: Mary Guillemard <mary.guillemard@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32812 >
2025-01-02 20:52:48 +00:00