Timothy Arceri
355a1f2058
glsl: remove out of date comment
...
GLSL 4.40 changed the relevant language in Section 8.13.2 (Interpolation
Functions) to:
"Component selection operators (e.g., .xy) may be used when specifying
interpolant."
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30239 >
2024-07-19 10:59:11 +00:00
Eric Engestrom
b2c3dfef75
llvmpipe/ci: mark spec@!opengl 1.1@gl_select tests as fixed
...
Fixed by a commit in the range d94a40fe...6f02ec5e, likely
https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26018
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30260 >
2024-07-19 09:57:24 +00:00
Eric Engestrom
4696e9c49b
v3d/ci: mark spec@amd_performance_monitor@vc4 tests as fixed
...
Fixed by a commit in the range 452fed52..decc040a, but no obvious
candidate stands out.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30259 >
2024-07-19 09:11:16 +00:00
Eric Engestrom
23ef65ea3b
ci/vkd3d: fix LD_LIBRARY_PATH
...
Fixes: 50fc7cc290
("glx: directly link to gallium")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30258 >
2024-07-19 08:29:51 +00:00
Georg Lehmann
e5b48da908
aco: remove optimize_cmp_subgroup_invocation
...
The new NIR optimization pass handles all these cases and more.
No Foz-DB changes.
Reviewed-by: Daniel Schürmann <daniel@schuermann.dev >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30236 >
2024-07-19 08:06:58 +00:00
Georg Lehmann
aa6d363634
nir: constant fold inverse_ballot
...
Foz-DB Navi21:
Totals from 210 (0.26% of 79395) affected shaders:
Instrs: 79583 -> 78892 (-0.87%)
CodeSize: 435636 -> 431680 (-0.91%)
VGPRs: 7208 -> 7224 (+0.22%)
Latency: 660376 -> 658808 (-0.24%); split: -0.38%, +0.14%
InvThroughput: 127489 -> 127544 (+0.04%); split: -0.35%, +0.39%
VClause: 1503 -> 1504 (+0.07%)
SClause: 3970 -> 3947 (-0.58%)
Copies: 4932 -> 4682 (-5.07%); split: -5.17%, +0.10%
Branches: 2411 -> 2406 (-0.21%); split: -0.33%, +0.12%
PreSGPRs: 6395 -> 6434 (+0.61%); split: -0.31%, +0.92%
PreVGPRs: 4100 -> 4103 (+0.07%)
VALU: 48484 -> 48145 (-0.70%); split: -0.70%, +0.00%
SALU: 12499 -> 12202 (-2.38%); split: -2.41%, +0.03%
SMEM: 6448 -> 6420 (-0.43%)
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Reviewed-by: Daniel Schürmann <daniel@schuermann.dev >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30235 >
2024-07-19 07:24:34 +00:00
Georg Lehmann
efb9258814
aco: handle clustered uniform reductions correctly
...
Alternatively we could just trust divergence analysis to do the right thing.
Reviewed-by: Daniel Schürmann <daniel@schuermann.dev >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30235 >
2024-07-19 07:24:34 +00:00
Samuel Pitoiset
65acc81e9d
radv: fix shaders cache corruption with indirect pipeline binds
...
Indirect pipeline binds force indirect descriptor sets and this needs
to be in the shader stage key, otherwise two shaders might result in
the same pipeline cache key.
Fixes: b1ba02e707
("radv: force using indirect descriptor sets for indirect compute pipelines")
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30209 >
2024-07-19 06:52:21 +00:00
M Henning
95bff5ca5b
nak: Add minimum bindgen requirement
...
This is copied from rusticl. We need bindgen 0.65 so we have
size_t-is-usize by default.
Fixes: 94436580
("nak: Only convert the written portion of the buffer in NirInstrPrinter")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/11371
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30178 >
2024-07-19 05:45:05 +00:00
Eric Engestrom
d5ec3a8988
meson/megadriver: replace hardlinks with symlinks
...
The wording in the script has always (3218056e0e
) been about symlinks,
and it feels like the use of `link()` instead of `symlink()` was
a typo that became fact.
These hardlinks make packaging harder (many distros have some variant of
this patch locally) especially when it comes to debug packages where gdb
expects the symbols file to have the same name as the lib the symbols
come from, and I don't think they make anything better, so let's change
to code to match the documentation :)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29731 >
2024-07-19 01:24:16 +00:00
Eric Engestrom
ac5d14c5ea
meson/megadriver: stop removing the "master" .so file
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29731 >
2024-07-19 01:24:16 +00:00
Eric Engestrom
da05938e65
meson/megadriver: fix install message to match the rest of meson
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29731 >
2024-07-19 01:24:16 +00:00
Eric Engestrom
dbc28332a9
meson: fix filename printed when generating devenv files
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29731 >
2024-07-19 01:24:16 +00:00
David Heidelberg
decc040abe
intel/debug: allow silencing CL warnings
...
Useful for CI and users previously aware of the warning.
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org >
Signed-off-by: David Heidelberg <david@ixit.cz >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29691 >
2024-07-19 00:24:29 +00:00
Mike Blumenkrantz
da47c0ed65
zink: use PIPE_CAP_NIR_SAMPLERS_AS_DEREF
...
this simplifies a bunch of stuff, though it also requires manually
clamping constnat oob indexing to avoid piglit hangs
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30001 >
2024-07-18 22:43:35 +00:00
Mike Blumenkrantz
235eb1af96
zink: move image aoa access to nir pass
...
this brings zink's output nir closer to the emitted spirv
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30001 >
2024-07-18 22:43:35 +00:00
Mike Blumenkrantz
586d0c4a9b
vl/dri3: use loader's dri3 init code and delete everything else
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30128 >
2024-07-18 21:58:49 +00:00
Mike Blumenkrantz
985e9c09f8
egl: use loader's multibuffer check to deduplicate lots of code
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30128 >
2024-07-18 21:58:49 +00:00
Mike Blumenkrantz
293c7b38ff
loader/glx: move multibuffers check to loader
...
make this code more reusable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30128 >
2024-07-18 21:58:49 +00:00
Mike Blumenkrantz
63191107ab
loader/dri3: avoid killing the xcb connection if dri3 not found
...
calling open if the extension is unsupported closes the connection
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30128 >
2024-07-18 21:58:49 +00:00
Mike Blumenkrantz
c24891e044
loader/dri3: check xfixes version in loader_dri3_open()
...
this will allow simplifying some code without losing functionality
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30128 >
2024-07-18 21:58:49 +00:00
Mike Blumenkrantz
fa541a887c
loader: delete loader_open_driver()
...
no longer used
Acked-by: Daniel Stone <daniels@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29771 >
2024-07-18 20:30:43 +00:00
Mike Blumenkrantz
93511c1c5c
gbm: link directly with libgallium
...
Acked-by: Daniel Stone <daniels@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29771 >
2024-07-18 20:30:43 +00:00
Mike Blumenkrantz
69c772e4ea
egl: link with libgallium directly
...
Acked-by: Daniel Stone <daniels@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29771 >
2024-07-18 20:30:43 +00:00
Mike Blumenkrantz
50fc7cc290
glx: directly link to gallium
...
this eliminates the loader interface, which avoids an entire class
of issues and simplifies a bunch of code
Acked-by: Daniel Stone <daniels@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29771 >
2024-07-18 20:30:43 +00:00
Lionel Landwerlin
67b778445a
brw: fix uniform rebuild of sources
...
If you have something like this :
con 32 %66 = @load_reg (%62) (base=0, legacy_fabs=0, legacy_fneg=0)
con 32 %27 = @resource_intel (%22 (0xdeaddead), %66, %67, %17 (0x0)) (desc_set=2, binding=96, resource_intel=0, resource_block_intel=-1)
Just copying the brw_reg in ssa_values[] is not enough for the
load_reg intrinsic. We need to call get_nir_src() to force some logic
to create the register correct.
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Fixes: b8209d69ff
("intel/fs: Add support for new-style registers")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30050 >
2024-07-18 19:58:46 +00:00
Rob Clark
b0d22461b9
freedreno: Enable the X1-85
...
Enable the GPU in the X1 elite/plus laptop SoCs.
Signed-off-by: Rob Clark <robdclark@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30249 >
2024-07-18 19:27:03 +00:00
Eric Engestrom
330006375e
bin/ci_run_n_monitor: replace ♲ with 🗙 to represent cancelled jobs
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30223 >
2024-07-18 19:21:45 +00:00
Eric Engestrom
964ecac0a4
bin/ci_run_n_monitor: add text labels next to the emojis
...
IMO emojis are nice to add next to the information to recognize things
easily in cases where they are visible, but they should not *replace*
the information.
This adds a readable text next to all emojis (some already had one,
like the "job duration" ones).
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30223 >
2024-07-18 19:21:45 +00:00
Eric Engestrom
032d4a20f9
bin/ci_run_n_monitor: explain that the 'Universal Recycling symbol' ♲ emoji means these jobs were cancelled
...
And not "restarted" for instance, which would also be a reasonable
interpretation.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30223 >
2024-07-18 19:21:45 +00:00
Kenneth Graunke
d630ff1f79
intel/brw: Disallow scalar byte to float conversions on DG2+
...
I haven't been able to find this restriction mentioned anywhere in the
hardware documentation, but the simulator has code to reject this case
as invalid, and it doesn't appear to work on hardware anymore.
Having lower_regioning() handle this takes care of the issue so we
don't have to worry about generating it in random places.
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/11489
Reviewed-by: Caio Oliveira <caio.oliveira@intel.com >
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30140 >
2024-07-18 18:51:35 +00:00
Sushma Venkatesh Reddy
7ca77370d2
anv: Fix I915_PARAM_HAS_CONTEXT_FREQ_HINT check
...
When I915_PARAM_HAS_CONTEXT_FREQ_HINT is not supported the
intel_ioctl(fd, DRM_IOCTL_I915_GETPARAM, &gp) will return -1 and that
will cause i915_gem_get_param() to return false.
val will be different than 1 when not using GuC submission, so we are
forcing val check to ensure this holds good in platforms that doesn't
support GuC submission.
Fixes: d52dd5a9
("anv/drirc: add option to provide low latency hint")
Signed-off-by: Sushma Venkatesh Reddy <sushma.venkatesh.reddy@intel.com >
Reviewed-by: José Roberto de Souza <jose.souza@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30234 >
2024-07-18 18:26:38 +00:00
Eric Engestrom
35cb0c350e
ci: replace gallium-drivers=swrast with gallium-drivers=llvmpipe,softpipe
...
Except debian-arm32 which disables llvm, so it can't get llvmpipe.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27607 >
2024-07-18 17:48:20 +00:00
Adam Jackson
010b2f9497
gallium/meson: Deconflate swrast/softpipe/llvmpipe
...
This adds explicit names for softpipe and llvmpipe to the gallium driver
list. "swrast" is treated as a compatibility name that selects both. We
clarify how lavapipe depends on (just) llvmpipe, and we make it possible
to build llvmpipe without softpipe.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27607 >
2024-07-18 17:48:20 +00:00
Samuel Pitoiset
3fba270907
radv/meta: create clear r32g32b32 pipelines on-demand when needed
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30248 >
2024-07-18 17:27:46 +02:00
Samuel Pitoiset
5933d2274b
radv/meta: add a helper to create clear r32g32b32 pipeline
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30248 >
2024-07-18 17:27:46 +02:00
Samuel Pitoiset
9a3f00e7e6
radv/meta: create clear pipeliones on-demand when needed
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30248 >
2024-07-18 17:27:46 +02:00
Samuel Pitoiset
7bda80f08b
radv/meta: update the helper that creates clear pipelines
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30248 >
2024-07-18 17:27:46 +02:00
Samuel Pitoiset
b406121d22
radv/meta: create itoi r32g32b32 pipelines on-demand when needed
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30248 >
2024-07-18 17:27:46 +02:00
Samuel Pitoiset
2e21c4098f
radv/meta: add a helper to create itoi r32g32b32 pipeline
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30248 >
2024-07-18 17:27:46 +02:00
Samuel Pitoiset
ef2af61300
radv/meta: create itoi pipelines on-demand when needed
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30248 >
2024-07-18 17:27:46 +02:00
Samuel Pitoiset
e47dffb100
radv/meta: update the helper that creates itoi pipelines
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30248 >
2024-07-18 17:27:46 +02:00
Samuel Pitoiset
bb745776b7
radv/meta: create btoi r32g32b32 pipeline on-demand when needed
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30248 >
2024-07-18 17:27:46 +02:00
Samuel Pitoiset
010e2c373b
radv/meta: add a helper to create btoi r32g32b32 pipeline
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30248 >
2024-07-18 17:27:46 +02:00
Samuel Pitoiset
b68b9b1677
radv/meta create btoi pipelines on-demand when needed
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30248 >
2024-07-18 17:27:46 +02:00
Samuel Pitoiset
3332de3640
radv/meta: add a helper to create btoi pipelines
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30248 >
2024-07-18 17:27:46 +02:00
Samuel Pitoiset
c23ec1a7c3
radv/meta: create itob pipelines on-demand when needed
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30248 >
2024-07-18 17:27:46 +02:00
Samuel Pitoiset
0cdd230772
radv/meta: add a helper to create itob pipelines
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30248 >
2024-07-18 17:27:46 +02:00
Samuel Pitoiset
9a2730d9a5
radv/meta: create DCC comp-to-single pipelines on-demand when needed
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30244 >
2024-07-18 14:55:05 +00:00
Samuel Pitoiset
72fa7a0449
radv/meta: create clear HTILE mask pipeline on-demand when needed
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30244 >
2024-07-18 14:55:05 +00:00