Emma Anholt
062e822e1b
ci/bare-metal: Collapse artifacts wget by default.
...
In trying to figure out why an rpi3 job took so long, I wished that the
wget verbosity was hidden by default, and that it told me how long it took
like other sections do.
Reviewed-by: Juan A. Suarez <jasuarez@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17146 >
2022-06-22 20:59:54 +00:00
Emma Anholt
13bf36588d
ci/bare-metal: Consolidate needs declarations in .baremetal-test-*.
...
We had it set up for arm64 asan already, do it for everyone else too. In
cleaning up the duplication, this fixes a pasteo in rpi3 which had the
"artifacts: false" on the wrong job, causing it to do a slow download of
the mesa build from gitlab.
Doing this required also moving the ".use-debian/arm_test" in as well, so
that its "needs:" didn't overwrite ours if it appeared after us in the
consumer's "extends:"
Should save about 20 seconds on rpi3 jobs.
Reviewed-by: Juan A. Suarez <jasuarez@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17146 >
2022-06-22 20:59:54 +00:00
Emma Anholt
1f9566cbb0
ci/bare-metal: Remove "stage: test" from .baremetal-test.
...
This is not one of the valid stages in the top level "stages:"
declaration, you're supposed to get your stage from your
test-source-dep.yml include. Avoids issues when .baremetal-test gets
included after your test-source-dep.
Acked-by: Daniel Stone <daniels@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17146 >
2022-06-22 20:59:54 +00:00
Mike Blumenkrantz
e13f04fcf0
zink: flag dmabufs for foreign queue transition on flush_resource call
...
this is needed by ext_external_objects
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15810 >
2022-06-22 20:42:02 +00:00
Mike Blumenkrantz
32c34e93aa
zink: add flag to indicate if a resource is a dmabuf
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15810 >
2022-06-22 20:42:02 +00:00
Emma Anholt
69cad6dcb7
ci/freedreno: Turn a530 back on by default and update expectations.
...
I think it should be fixed since I redid how we manage serial around
restarts. Haven't seen a fail in the manual runs I've done.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17004 >
2022-06-22 20:07:36 +00:00
Emma Anholt
4e3c51cbd8
freedreno/a5xx: Set the buffer bit appropriately in XS_CTRL_REG0.
...
This seems to be how the bit gets used, from grepping my blob traces.
Hopefully this helps stabilize some stuff.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17004 >
2022-06-22 20:07:36 +00:00
Emma Anholt
6cf2b24eaf
freedreno/ir3: Disable image/ssbo 16-bit conversion folding pre-a6xx.
...
I don't see it in blob dumps, and the reordered args tripped up validation.
Fixes: 49dc60efa1
("freedreno/ir3: Fold 16-bit conversions into image load/store src/dsts.")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17004 >
2022-06-22 20:07:36 +00:00
Ian Romanick
fd1f2d3b5a
nir: Add and use algebraic property "is selection"
...
There are several places that should have supported the various sized
versions of bcsel and the various nir_op_[fi]csel_* opcodes. Rather
than enumerate the whole list, add a property.
v2: Make the comment for NIR_OP_IS_SELECTION more descriptive.
Suggested by Jason.
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org >
Reviewed-by: Jason Ekstrand <jason.ekstrand@collabora.com >
Reviewed-by: Alyssa Rosenzweig <alyssa@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17048 >
2022-06-22 19:26:59 +00:00
Ian Romanick
a2a2fbc510
nir/algebraic: Fix NaN-unsafe fcsel patterns
...
For example, the proof for this pattern
(('bcsel', ('flt', 'a@32', 0), 'b@32', 'c@32'), ('fcsel_ge', a, c, b)),
would be
bcsel(a < 0, b, c)
bcsel(!(a < 0), c, b)
bcsel(a >= 0, c, b)
fcsel_ge(a, c, b)
However, !(a < 0) => (a >= 0) is well known to produce different
results if `a` is NaN.
Instead of that replacement, use this replacement:
bcsel(a < 0, b, c)
bcsel(-0 < -a, b, c)
bcsel(0 < -a, b, c)
fcsel_gt(-a, b, c)
This is NaN-safe and exact.
Reviewed-by: Alyssa Rosenzweig <alyssa@collabora.com >
Reviewed-by: Jason Ekstrand <jason.ekstrand@collabora.com >
Fixes: 0f5b3c37c5
("nir: Add opcodes for fused comp + csel and optimizations")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17048 >
2022-06-22 19:26:59 +00:00
Ian Romanick
ccd18ec4f3
nir: i32csel opcodes should compare with integer zero
...
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org >
Reviewed-by: Alyssa Rosenzweig <alyssa@collabora.com >
Reviewed-by: Jason Ekstrand <jason.ekstrand@collabora.com >
Noticed-by: Georg Lehmann <dadschoorse@gmail.com >
Fixes: 0f5b3c37c5
("nir: Add opcodes for fused comp + csel and optimizations")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17048 >
2022-06-22 19:26:59 +00:00
Connor Abbott
d455838081
tu: Fix linemode for tessellation with isolines
...
Fixes: 542211676c
("turnip: enable VK_EXT_line_rasterization")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17190 >
2022-06-22 17:57:53 +00:00
Alyssa Rosenzweig
e812e8892a
v3d: Drop workaround for u_blitter bug
...
This doesn't seem to be necessary.
Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com >
Reviewed-by: Iago Toral Quiroga <itoral@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17113 >
2022-06-22 17:07:10 +00:00
Danylo Piliaiev
f1c1b9687e
tu: Do not expose storage image/buffer features for PACK16 formats
...
We don't support storing into them.
Fixes GL CTS tests running through ZINK:
KHR-GL46.packed_pixels.pbo_rectangle.*
Signed-off-by: Danylo Piliaiev <dpiliaiev@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17168 >
2022-06-22 14:39:47 +00:00
Emma Anholt
4309e09d6f
vc4: Propagate txf_ms's dest_type to the lowered txf.
...
This was missing, and the added validation caught it.
Fixes: 708c47e663
("nir: Validate nir_tex_instr::dest_type bitsize")
Reviewed-by: Juan A. Suarez <jasuarez@igalia.com >
Reviewed-by: Iago Toral Quiroga <itoral@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17172 >
2022-06-22 07:10:18 -07:00
Emma Anholt
1de87497ba
ci/vc4: Turn on deqp-egl testing by default.
...
Now that we have one less job, let's flip this on.
Reviewed-by: Juan A. Suarez <jasuarez@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17172 >
2022-06-22 07:10:14 -07:00
Emma Anholt
e9fad0b9aa
ci/vc4: Merge quick_shader in with deqp-gles
...
All 4 jobs had a total of about 26 minutes of runner time, so squish them
onto 3 runners and use gbm for the .shader_tests to avoid X overhead and
hopefully succeed with full concurrency.
Reviewed-by: Juan A. Suarez <jasuarez@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17172 >
2022-06-22 07:09:53 -07:00
Mike Blumenkrantz
872a1ae69e
zink: ci updates
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17145 >
2022-06-22 13:27:29 +00:00
Mike Blumenkrantz
90586f812c
mesa: explicitly disallow multiple pointsize exports from generating
...
for the fixedfunc vertex case this is important since the fixedfunc shader
may have already added an (attenuated) pointsize
Acked-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17145 >
2022-06-22 13:27:29 +00:00
Mike Blumenkrantz
096c5aa34a
mesa: enforce pointsize exports if pointsize is being clamped
...
min/max pointsize clamping affects the value that must be used,
meaning that it may not be 1.0
in the case where clamping changes the value from 1.0, ensure the shader
export path is used if attenuation isn't enabled
Acked-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17145 >
2022-06-22 13:27:29 +00:00
Mike Blumenkrantz
3e2c132eb8
mesa: skip pointsize exports if pointsize attenuation is enabled
...
attenuation has its own method of exporting pointsize in fixedfunc shaders,
so ensure the attenuated size isn't overwritten
Acked-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17145 >
2022-06-22 13:27:29 +00:00
Mike Blumenkrantz
de732cf61b
mesa: rename PointSizeIsOne -> PointSizeIsSet
...
this will better convey the meaning of the value
Acked-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17145 >
2022-06-22 13:27:29 +00:00
Mike Blumenkrantz
b2155a044d
mesa: break out PointSizeIsOne setting to util function
...
Acked-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17145 >
2022-06-22 13:27:29 +00:00
Mike Blumenkrantz
4830cc77cb
nir/lower_point_size: apply point size clamping
...
point size min/max values are provided through the state vars, so ensure
these are always applied in order to respect ARB_point_parameters
cc: mesa-stable
Acked-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17145 >
2022-06-22 13:27:29 +00:00
Italo Nicola
42a1264951
virgl: overpropagate precise flags
...
As it turns out, MOVs weren't the only instructions that blocked precise
flags propagation in the transition to nir-to-tgsi.
This commit fixes some rendering regressions caused by a4a34cd3
.
Fixes: a4a34cd3
Signed-off-by: Italo Nicola <italonicola@collabora.com >
Reviewed-by: Gert Wollny <gert.wollny@collanora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17144 >
2022-06-22 12:58:58 +00:00
Jason Volk
e1488d9374
radeon: Support shared memory user pointers.
...
The RADEON_GEM_USERPTR_ANONONLY flag is hardcoded here which excludes
shared memory pages. DRM is actually capable of supporting shared file-
backed memory, but only if it's read-only. This mutability intent has to
be conveyed through the stack, so a flags argument is added to the winsys
regime to pass RADEON_FLAG_READ_ONLY.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16115 >
2022-06-22 12:23:02 +00:00
Marcin Ślusarz
f871aa10a1
intel/compiler: assert that base is 0 for [load|store]_shared intrins
...
Acked-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17143 >
2022-06-22 10:32:13 +00:00
Timur Kristóf
e5970fe22a
nir/lower_task_shader: don't use base index for shared memory intrinsics
...
Intel backend doesn't handle them very well.
Fixes: 8aff8d3dd4
("nir: Add common task shader lowering to make the backend's job easier.")
Reviewed-by: Marcin Ślusarz <marcin.slusarz@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17143 >
2022-06-22 10:32:13 +00:00
Marcin Ślusarz
49b8fffeed
nir/lower_task_shader: insert barrier before/after shared memory read/write
...
Fixes: 8aff8d3dd4
("nir: Add common task shader lowering to make the backend's job easier.")
Reviewed-by: Timur Kristóf <timur.kristof@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17143 >
2022-06-22 10:32:13 +00:00
Connor Abbott
c601ba332b
ir3/sched: Fix could_sched() determination
...
This needs to be accurate so that when we split and then schedule a new
a0.x/a1.x/p0.x write we will eventually make progress. It wasn't taking
the kill_path into account which could create an infinite loop as we
keep scheduling writes whose uses are blocked because they are memory
instructions not on the kill_path.
Closes : #6413
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16635 >
2022-06-22 10:09:13 +00:00
Danylo Piliaiev
a8671b2182
meson/tu: Don't compile libdrm paths if KGSL is selected
...
Even if there is libdrm we shouldn't use it if KGSL is selected.
Signed-off-by: Danylo Piliaiev <dpiliaiev@igalia.com >
Reviewed-by: Emma Anholt <emma@anholt.net >
Reviewed-by: Hyunjun Ko <zzoon@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17173 >
2022-06-22 11:52:36 +03:00
Danylo Piliaiev
6ad7be1b36
meson/pps: Check if libdrm exists to compile pps
...
For Turnip with KGSL we may have perffeto enabled but we don't
have libdrm.
Signed-off-by: Danylo Piliaiev <dpiliaiev@igalia.com >
Reviewed-by: Emma Anholt <emma@anholt.net >
Reviewed-by: Hyunjun Ko <zzoon@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17173 >
2022-06-22 11:52:36 +03:00
Danylo Piliaiev
ee6a0c675b
meson: Define _GNU_SOURCE for android host system
...
Otherwise sched_getaffinity isn't be defined and util_cpu_detect_once
fails to compile.
Signed-off-by: Danylo Piliaiev <dpiliaiev@igalia.com >
Reviewed-by: Emma Anholt <emma@anholt.net >
Reviewed-by: Hyunjun Ko <zzoon@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17173 >
2022-06-22 11:52:36 +03:00
Samuel Pitoiset
ad3d6d9c6e
radv/llvm: always emit a null export even if the FS doesn't discard
...
Even with a noop FS, the color blend state can still be non-zero, and
then SPI color related registers won't be 0 and this would hang.
Fixes: bdf3797aeb
("ac,radeonsi: don't export null from PS if it has no effect on gfx10+")
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Timur Kristóf <timur.kristof@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17169 >
2022-06-22 08:31:30 +02:00
Pavel Asyutchenko
17645cb29c
llvmpipe: enable PIPE_CAP_FBFETCH_ZS
...
Support for it was added in previous commits.
Signed-off-by: Pavel Asyutchenko <sventeam@yandex.ru >
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13979 >
2022-06-22 04:32:44 +00:00
Pavel Asyutchenko
ccaa7920ef
llvmpipe: implement FB fetch for depth/stencil
...
Signed-off-by: Pavel Asyutchenko <sventeam@yandex.ru >
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13979 >
2022-06-22 04:32:44 +00:00
Pavel Asyutchenko
0ba3e797ee
llvmpipe: simplify early/late zs tests selection
...
This does not change selection logic.
Signed-off-by: Pavel Asyutchenko <sventeam@yandex.ru >
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13979 >
2022-06-22 04:32:44 +00:00
Pavel Asyutchenko
443ef18f0c
llvmpipe: enable per-sample shading when FB fetch is used
...
This matches specifications of both color and ZS fetch extensions.
Cc: mesa-stable
Signed-off-by: Pavel Asyutchenko <sventeam@yandex.ru >
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13979 >
2022-06-22 04:32:44 +00:00
Pavel Asyutchenko
8788b17596
nir_to_tgsi: Don't count ZS fbfetch vars as outputs
...
Signed-off-by: Pavel Asyutchenko <sventeam@yandex.ru >
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13979 >
2022-06-22 04:32:44 +00:00
Pavel Asyutchenko
959b748038
glsl: add language support for GL_ARM_shader_framebuffer_fetch_depth_stencil
...
This extension adds built-in variables gl_LastFragDepthARM and gl_LastFragStencilARM
which can be implemented almost the same as gl_LastFragData from color fetch extension.
Signed-off-by: Pavel Asyutchenko <sventeam@yandex.ru >
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13979 >
2022-06-22 04:32:44 +00:00
Pavel Asyutchenko
41f22a1823
gallium: add PIPE_CAP_FBFETCH_ZS and expose extension
...
st/mesa will expose GL_ARM_shader_framebuffer_fetch_depth_stencil
if this new capability is supported by the driver.
Signed-off-by: Pavel Asyutchenko <sventeam@yandex.ru >
Reviewed-by: Alyssa Rosenzweig <alyssa@collabora.com >
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13979 >
2022-06-22 04:32:44 +00:00
Dave Airlie
68e8940114
glx/drisw: use xcb instead of X to query connection
...
Reviewed-by: Adam Jackson <ajax@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17155 >
2022-06-22 03:28:21 +00:00
Dave Airlie
d3e723fb77
wsi/x11: add xcb_put_image support for larger transfers.
...
This was noticed as a problem in the EGL code, just fixup wsi.
Cc: mesa-stable
Reviewed-by: Adam Jackson <ajax@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17155 >
2022-06-22 03:28:21 +00:00
Dave Airlie
c5dbb1139c
egl/x11: add missing put_image cookie cleanups
...
These might not be required but be consistent with the wsi code.
Cc: mesa-stable
Reviewed-by: Adam Jackson <ajax@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17155 >
2022-06-22 03:28:21 +00:00
Dave Airlie
e6082ac62e
egl/x11: split large put image requests to avoid server destroy
...
wezterm in fullscreen 4k was exceeding the xcb max request size
on the put image with llvmpipe. This fixes it to send sub-images,
the Xlib put image used in glx does this internally, but not
the xcb one, so just do it in sections here.
Cc: mesa-stable
Reviewed-by: Adam Jackson <ajax@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17155 >
2022-06-22 03:28:21 +00:00
Mike Blumenkrantz
e8fc5cca90
zink: fix dual_src_blend driconf workaround
...
not sure when this broke but it broke
cc: mesa-stable
Reviewed-by: Dave Airlie <airlied@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17156 >
2022-06-22 03:14:18 +00:00
Mike Blumenkrantz
ea005c9e04
glx/drisw: invalidate drawables upon binding context if flush extension exists
...
this forces surface resize as expected
cc: mesa-stable
fixes #6706
Reviewed-by: Adam Jackson <ajax@redhat.com >
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17147 >
2022-06-22 02:18:37 +00:00
Mike Blumenkrantz
23b63e536e
glx/drisw: store the flush extension to the screen
...
cc: mesa-stable
Reviewed-by: Adam Jackson <ajax@redhat.com >
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17147 >
2022-06-22 02:18:37 +00:00
Guilherme Gallo
cee1c4fc7f
ci/lava: Filter out undesired messages
...
Some LAVA jobs emit lots of messages "Listened to connection for
namespace 'common' for up to 1s" in a row at the end of the logs, making
difficult to see the result of the test script.
This commit removes those lines until a proper solution is deployed on
the LAVA side.
Closes : #6116
Signed-off-by: Guilherme Gallo <guilherme.gallo@collabora.com >
Acked-by: Emma Anholt <emma@anholt.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17151 >
2022-06-22 01:48:16 +00:00
Jason Ekstrand
64d074879b
vulkan/wsi: Use HAVE_LIBDRM to detect DRM instead of !_WIN32
...
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com >
Acked-by: Danylo Piliaiev <dpiliaiev@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17170 >
2022-06-22 01:15:20 +00:00