OpenHarmony/third_party_mesa3d
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

i965: check tcs for NULL dereference

Browse Source 
Coverity issue 1361544 found an instance where the tcs variable is
checked for NULL, but unconditionally dereferenced later in the same
function.

Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
This commit is contained in:
Mark Janes
2016-05-13 13:04:56 -07:00
parent bf91034d44
commit fd854c1add
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/mesa/drivers/dri/i965/brw_tcs.c
View File

@@ -278,14 +278,16 @@ brw_codegen_tcs_prog(struct brw_context *brw,
if (unlikely(brw->perf_debug)) { if (unlikely(brw->perf_debug)) {
struct brw_shader *btcs = (struct brw_shader *) tcs; struct brw_shader *btcs = (struct brw_shader *) tcs;
if (btcs) {
if (btcs->compiled_once) { if (btcs->compiled_once) {
brw_tcs_debug_recompile(brw, shader_prog, key); brw_tcs_debug_recompile(brw, shader_prog, key);
} }
btcs->compiled_once = true;
}
if (start_busy && !drm_intel_bo_busy(brw->batch.last_bo)) { if (start_busy && !drm_intel_bo_busy(brw->batch.last_bo)) {
perf_debug("TCS compile took %.03f ms and stalled the GPU\n", perf_debug("TCS compile took %.03f ms and stalled the GPU\n",
(get_time() - start_time) * 1000); (get_time() - start_time) * 1000);
} }
btcs->compiled_once = true;
} }
/* Scratch space is used for register spilling */ /* Scratch space is used for register spilling */