st/mesa: Set gl_config.floatMode based on color_format
Sets the float color component type in st_visual_to_context_mode() ensuring float color values are not clamped. Fixes dEQP-EGL.functional.wide_color.window_fp16_default_colorspace on asahi, iris and most likely every other driver having it marked as fail or flake. Closes: mesa/mesa#9276 Signed-off-by: Janne Grunau <j@jannau.net> Reviewed-by: Adam Jackson <ajax@redhat.com> Acked-by: David Heidelberg <david.heidelberg@collabora.com> Cc: mesa-stable Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23914>
This commit is contained in:
@@ -511,7 +511,6 @@ spec@!opengl 2.0@max-samplers,Fail
|
||||
spec@!opengl 2.0@max-samplers border,Fail
|
||||
|
||||
wayland-dEQP-EGL.functional.wide_color.window_888_colorspace_default,Fail
|
||||
wayland-dEQP-EGL.functional.wide_color.window_fp16_default_colorspace,Fail
|
||||
|
||||
spec@!opengl 1.1@line-smooth-stipple,Fail
|
||||
|
||||
|
@@ -354,7 +354,6 @@ spill-dEQP-VK.subgroups.ballot_broadcast.compute.subgroupbroadcast_bool_required
|
||||
|
||||
# Failing (Color test failed) since wayland platform was enabled in arm builds
|
||||
wayland-dEQP-EGL.functional.wide_color.window_888_colorspace_default,Fail
|
||||
wayland-dEQP-EGL.functional.wide_color.window_fp16_default_colorspace,Fail
|
||||
|
||||
# skqp failure:
|
||||
# SRGBReadWritePixels FAILED (7 errors)
|
||||
|
@@ -361,7 +361,6 @@ wayland-dEQP-EGL.functional.wide_color.pbuffer_888_colorspace_default,Fail
|
||||
|
||||
# Failing (Color test failed) since wayland platform was enabled in arm builds
|
||||
wayland-dEQP-EGL.functional.wide_color.window_888_colorspace_default,Fail
|
||||
wayland-dEQP-EGL.functional.wide_color.window_fp16_default_colorspace,Fail
|
||||
|
||||
# skqp failure:
|
||||
# SRGBReadWritePixels FAILED (7 errors)
|
||||
|
@@ -53,7 +53,6 @@ wayland-dEQP-EGL.functional.render.multi_thread.gles2.rgb888_window,Fail
|
||||
wayland-dEQP-EGL.functional.render.multi_thread.gles2.rgba8888_pbuffer,Fail
|
||||
wayland-dEQP-EGL.functional.wide_color.pbuffer_8888_colorspace_srgb,Fail
|
||||
wayland-dEQP-EGL.functional.wide_color.window_8888_colorspace_srgb,Fail
|
||||
wayland-dEQP-EGL.functional.wide_color.window_fp16_default_colorspace,Fail
|
||||
|
||||
x11-dEQP-EGL.functional.create_context.no_config,Fail
|
||||
x11-dEQP-EGL.functional.image.modify.renderbuffer_depth16_renderbuffer_clear_depth,Fail
|
||||
|
@@ -5,5 +5,3 @@
|
||||
# [...]
|
||||
wayland-dEQP-EGL.functional.wide_color.pbuffer_888_colorspace_default,Fail
|
||||
wayland-dEQP-EGL.functional.wide_color.window_888_colorspace_default,Fail
|
||||
|
||||
wayland-dEQP-EGL.functional.wide_color.window_fp16_default_colorspace,Fail
|
||||
|
@@ -7,4 +7,3 @@ wayland-dEQP-EGL.functional.wide_color.pbuffer_888_colorspace_default,Fail
|
||||
|
||||
# after enabling wayland in x86_64 mesa build
|
||||
wayland-dEQP-EGL.functional.wide_color.window_888_colorspace_default,Fail
|
||||
wayland-dEQP-EGL.functional.wide_color.window_fp16_default_colorspace,Fail
|
||||
|
@@ -21,6 +21,3 @@ dEQP-EGL.functional.sharing.gles2.multithread.simple.buffers.buffersubdata_rende
|
||||
# 2022-05-05 18:40:38.338548: [ 830.144153] i915 0000:00:02.0: [drm] GPU HANG: ecode 9:1:87d79ffe, in deqp-gles31 [2571]
|
||||
dEQP-GLES31.functional.primitive_bounding_box.clear.scissored_clear_with_triangles
|
||||
dEQP-GLES31.functional.primitive_bounding_box.clear.scissored_clear_with_triangles_per_primitive_bbox
|
||||
|
||||
# Since Wayland was enabled on x86-64, this test flakes occasionally.
|
||||
wayland-dEQP-EGL.functional.wide_color.window_fp16_default_colorspace
|
||||
|
@@ -559,6 +559,7 @@ st_visual_to_context_mode(const struct st_visual *visual,
|
||||
mode->rgbBits = mode->redBits +
|
||||
mode->greenBits + mode->blueBits + mode->alphaBits;
|
||||
mode->sRGBCapable = util_format_is_srgb(visual->color_format);
|
||||
mode->floatMode = util_format_is_float(visual->color_format);
|
||||
}
|
||||
|
||||
if (visual->depth_stencil_format != PIPE_FORMAT_NONE) {
|
||||
|
@@ -57,4 +57,3 @@ dEQP-GLES31.functional.texture.gather.basic.cube.rgba8ui.no_corners.size_pot.mir
|
||||
dEQP-GLES31.functional.texture.gather.basic.cube.rgba8ui.no_corners.size_pot.repeat_mirrored_repeat,Fail
|
||||
|
||||
wayland-dEQP-EGL.functional.wide_color.window_888_colorspace_default,Fail
|
||||
wayland-dEQP-EGL.functional.wide_color.window_fp16_default_colorspace,Fail
|
||||
|
Reference in New Issue
Block a user