OpenHarmony/third_party_mesa3d
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

lavapipe: Fix struct initialization

Browse Source 
Fix defect reported by Coverity Scan.

Evaluation order violation (EVALUATION_ORDER)
write_write_typo: In box.x = box.x = copy->imageOffset.x, box.x is written twice with the same value.

Fixes: 9e9d90c6c3 ("lavapipe: VK_EXT_host_image_copy")
Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-by: Konstantin Seurer <konstantin.seurer@gmail.com>
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24531>
This commit is contained in:
Vinson Lee
2023-08-06 22:26:57 -07:00
parent 81cae3d8d2
commit f9cd8446ef
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/gallium/frontends/lavapipe/lvp_image.c
View File

@@ -672,10 +672,10 @@ lvp_CopyImageToMemoryEXT(VkDevice _device, const VkCopyImageToMemoryInfoEXT *pCo
for (unsigned i = 0; i < pCopyImageToMemoryInfo->regionCount; i++) { for (unsigned i = 0; i < pCopyImageToMemoryInfo->regionCount; i++) {
const VkImageToMemoryCopyEXT *copy = &pCopyImageToMemoryInfo->pRegions[i]; const VkImageToMemoryCopyEXT *copy = &pCopyImageToMemoryInfo->pRegions[i];
struct pipe_box box = { struct pipe_box box = {
box.x = copy->imageOffset.x, .x = copy->imageOffset.x,
box.y = copy->imageOffset.y, .y = copy->imageOffset.y,
box.width = copy->imageExtent.width, .width = copy->imageExtent.width,
box.height = copy->imageExtent.height, .height = copy->imageExtent.height,
.depth = 1, .depth = 1,
}; };
switch (image->bo->target) { switch (image->bo->target) {