OpenHarmony/third_party_mesa3d
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

nv50: Remove unused value

Browse Source 
Fix defect reported by Coverity Scan.

Unused value (UNUSED_VALUE)
assigned_pointer: Assigning value from &nv50->vtxbuf[b] to vb here, but
that stored value is overwritten before it can be used.

Fixes: 7672545223 ("gallium: move vertex stride to CSO")
Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Reviewed-by: Karol Herbst <kherbst@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24801>
This commit is contained in:
Vinson Lee
2023-08-20 17:31:06 -07:00
parent 3e66eba59e
commit f816578e4e
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/gallium/drivers/nouveau/nv50/nv50_vbo.c
View File

@@ -294,7 +294,6 @@ nv50_vertex_arrays_validate(struct nv50_context *nv50)
uint32_t limits[PIPE_MAX_ATTRIBS];
struct nouveau_pushbuf *push = nv50->base.pushbuf;
struct nv50_vertex_stateobj *vertex = nv50->vertex;
struct pipe_vertex_buffer *vb;
struct nv50_vertex_element *ve;
uint32_t mask;
uint32_t refd = 0;
@@ -341,7 +340,6 @@ nv50_vertex_arrays_validate(struct nv50_context *nv50)
assert(b < PIPE_MAX_ATTRIBS);
ve = &vertex->element[i];
vb = &nv50->vtxbuf[b];
if (likely(vertex->strides[b]) || !(nv50->vbo_user & (1 << b)))
PUSH_DATA(push, ve->state);
@@ -368,6 +366,7 @@ nv50_vertex_arrays_validate(struct nv50_context *nv50)
for (i = 0; i < vertex->num_elements; ++i) {
uint64_t address, limit;
const unsigned b = vertex->element[i].pipe.vertex_buffer_index;
struct pipe_vertex_buffer *vb;
assert(b < PIPE_MAX_ATTRIBS);
ve = &vertex->element[i];