OpenHarmony/third_party_mesa3d
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

radv: improve a comment in si_emit_set_predication_state()

Browse Source 
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
This commit is contained in:
Samuel Pitoiset
2018-09-12 23:20:39 +02:00
parent abdf396cbe
commit f398595dca
1 changed files with 6 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/amd/vulkan/si_cmd_buffer.c
View File

@@ -1004,21 +1004,19 @@ si_emit_cache_flush(struct radv_cmd_buffer *cmd_buffer)
/* sets the CP predication state using a boolean stored at va */ /* sets the CP predication state using a boolean stored at va */
void void
si_emit_set_predication_state(struct radv_cmd_buffer *cmd_buffer, si_emit_set_predication_state(struct radv_cmd_buffer *cmd_buffer,
bool inverted, uint64_t va) bool draw_visible, uint64_t va)
{ {
uint32_t op = 0; uint32_t op = 0;
if (va) { if (va) {
op = PRED_OP(PREDICATION_OP_BOOL64); op = PRED_OP(PREDICATION_OP_BOOL64);
/* By default, our internal rendering commands are discarded /* PREDICATION_DRAW_VISIBLE means that if the 32-bit value is
* only if the predicate is non-zero (ie. DRAW_VISIBLE). But * zero, all rendering commands are discarded. Otherwise, they
* VK_EXT_conditional_rendering also allows to discard commands * are discarded if the value is non zero.
* when the predicate is zero, which means we have to use a
* different flag.
*/ */
op |= inverted ? PREDICATION_DRAW_VISIBLE : op |= draw_visible ? PREDICATION_DRAW_VISIBLE :
PREDICATION_DRAW_NOT_VISIBLE; PREDICATION_DRAW_NOT_VISIBLE;
} }
if (cmd_buffer->device->physical_device->rad_info.chip_class >= GFX9) { if (cmd_buffer->device->physical_device->rad_info.chip_class >= GFX9) {
radeon_emit(cmd_buffer->cs, PKT3(PKT3_SET_PREDICATION, 2, 0)); radeon_emit(cmd_buffer->cs, PKT3(PKT3_SET_PREDICATION, 2, 0));