OpenHarmony/third_party_mesa3d
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

aco: fix subdword copies on GFX6-GFX7

Browse Source 
SDWA is only GFX8+. Use v_mov_b32 since the upper 16 bits don't matter.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5227>
This commit is contained in:
Samuel Pitoiset
2020-05-26 09:38:27 +02:00
parent a521c67d22
commit f31c9b4edf
1 changed files with 11 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/amd/compiler/aco_builder_h.py
View File

@@ -382,13 +382,17 @@ public:
} else if (op.bytes() > 2) {
return pseudo(aco_opcode::p_create_vector, dst, op);
} else if (dst.regClass().is_subdword()) {
aco_ptr<SDWA_instruction> sdwa{create_instruction<SDWA_instruction>(aco_opcode::v_mov_b32, asSDWA(Format::VOP1), 1, 1)};
sdwa->operands[0] = op;
sdwa->definitions[0] = dst;
sdwa->sel[0] = op.bytes() == 1 ? sdwa_ubyte : sdwa_uword;
sdwa->dst_sel = dst.bytes() == 1 ? sdwa_ubyte : sdwa_uword;
sdwa->dst_preserve = true;
return insert(std::move(sdwa));
if (program->chip_class >= GFX8) {
aco_ptr<SDWA_instruction> sdwa{create_instruction<SDWA_instruction>(aco_opcode::v_mov_b32, asSDWA(Format::VOP1), 1, 1)};
sdwa->operands[0] = op;
sdwa->definitions[0] = dst;
sdwa->sel[0] = op.bytes() == 1 ? sdwa_ubyte : sdwa_uword;
sdwa->dst_sel = dst.bytes() == 1 ? sdwa_ubyte : sdwa_uword;
sdwa->dst_preserve = true;
return insert(std::move(sdwa));
} else {
return vop1(aco_opcode::v_mov_b32, dst, op);
}
} else {
unreachable("Unhandled case in bld.copy()");
}