From f27d3a08c6d6cac8f3cb007001e89e7d45be6d54 Mon Sep 17 00:00:00 2001 From: Iago Toral Quiroga Date: Mon, 5 Sep 2022 11:21:53 +0200 Subject: [PATCH] v3dv: expose VK_EXT_attachment_feeback_loop_layout MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit We don't have any special requirements for this, so we can just expose the extension. The tests in CTS have an issue where they only check if a format is supported for sampling but don't check if an image with that format can be created for sampling. In our case, since we can't sample 1D depth/stencil images, this causes affected tests to crash in the simulator (they pass on the device though). There is an issue with a fix here: https://gitlab.khronos.org/Tracker/vk-gl-cts/-/issues/3923 Reviewed-by: Alejandro Piñeiro Part-of: --- docs/features.txt | 2 +- src/broadcom/vulkan/v3dv_device.c | 8 ++++++++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/docs/features.txt b/docs/features.txt index c8a5b9b7560..0c1bdf2edb1 100644 --- a/docs/features.txt +++ b/docs/features.txt @@ -535,7 +535,7 @@ Khronos extensions that are not part of any Vulkan version: VK_KHR_win32_surface DONE (dzn, lvp) VK_KHR_xcb_surface DONE (anv, dzn, lvp, radv, tu, v3dv, vn) VK_KHR_xlib_surface DONE (anv, dzn, lvp, radv, tu, v3dv, vn) - VK_EXT_attachment_feedback_loop_layout DONE (radv, tu) + VK_EXT_attachment_feedback_loop_layout DONE (radv, tu, v3dv) VK_EXT_border_color_swizzle DONE (anv, lvp, tu, radv/gfx10+, v3dv) VK_EXT_buffer_device_address DONE (anv/gen8+, radv) VK_EXT_calibrated_timestamps DONE (anv, lvp, radv, vn) diff --git a/src/broadcom/vulkan/v3dv_device.c b/src/broadcom/vulkan/v3dv_device.c index 741c8d47e4c..e3437af544f 100644 --- a/src/broadcom/vulkan/v3dv_device.c +++ b/src/broadcom/vulkan/v3dv_device.c @@ -166,6 +166,7 @@ get_device_extensions(const struct v3dv_physical_device *device, .KHR_vulkan_memory_model = true, .KHR_zero_initialize_workgroup_memory = true, .EXT_4444_formats = true, + .EXT_attachment_feedback_loop_layout = true, .EXT_border_color_swizzle = true, .EXT_color_write_enable = true, .EXT_custom_border_color = true, @@ -1322,6 +1323,13 @@ v3dv_GetPhysicalDeviceFeatures2(VkPhysicalDevice physicalDevice, break; } + case VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_ATTACHMENT_FEEDBACK_LOOP_LAYOUT_FEATURES_EXT: { + VkPhysicalDeviceAttachmentFeedbackLoopLayoutFeaturesEXT *features = + (void *) ext; + features->attachmentFeedbackLoopLayout = true; + break; + } + default: v3dv_debug_ignored_stype(ext->sType); break;