OpenHarmony/third_party_mesa3d
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

venus: drop some redundant comment

Browse Source 
The render pass (legacy or dynamic) can be ignored only in a pipeline
library with just Vertex Input State. For other cases, even when raster
has been discarded, it is still needed at the api level to avoid
violating a bunch of VUs which validate against attachments. The legacy
pass byitself is also necessary to tell whether it's legacy or dynamic.
So venus implemented at the VK api level should not drop render pass in
those cases.

The layout to be ref'ed is the one to be used, so we don't care about
those being ignored, which has already been removed in the pipeline info
fix.

Signed-off-by: Yiwei Zhang <zzyiwei@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27054>
This commit is contained in:
Yiwei Zhang
2024-01-12 14:38:59 -08:00
committed by Marge Bot
parent b551b6e48a
commit f256e8171c
1 changed files with 0 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/virtio/vulkan/vn_pipeline.c
View File

@@ -848,10 +848,6 @@ vn_render_pass_state_update(
* we don't read it, the host driver may read it. * we don't read it, the host driver may read it.
*/ */
/* XXX: Should this ignore the render pass for some state subsets when
* rasterization is statically disabled? The spec suggests "yes" and "no".
*/
/* VUID-VkGraphicsPipelineCreateInfo-flags-06643 /* VUID-VkGraphicsPipelineCreateInfo-flags-06643
* *
* If VkGraphicsPipelineLibraryCreateInfoEXT::flags includes * If VkGraphicsPipelineLibraryCreateInfoEXT::flags includes
@@ -1524,10 +1520,6 @@ vn_CreateGraphicsPipelines(VkDevice device,
for (uint32_t i = 0; i < createInfoCount; i++) { for (uint32_t i = 0; i < createInfoCount; i++) {
struct vn_pipeline *pipeline = vn_pipeline_from_handle(pPipelines[i]); struct vn_pipeline *pipeline = vn_pipeline_from_handle(pPipelines[i]);
/* Grab a refcount on the pipeline layout when needed. Take care; the
* pipeline layout may be omitted or ignored in incomplete pipelines.
*/
struct vn_pipeline_layout *layout = struct vn_pipeline_layout *layout =
vn_pipeline_layout_from_handle(pCreateInfos[i].layout); vn_pipeline_layout_from_handle(pCreateInfos[i].layout);
if (layout && (layout->push_descriptor_set_layout || if (layout && (layout->push_descriptor_set_layout ||