From ee3f17ca7909412fc9ce1288324edea3bc2e312a Mon Sep 17 00:00:00 2001 From: Yiwei Zhang Date: Tue, 4 Jul 2023 14:44:49 -0700 Subject: [PATCH] venus: fix a cmd tmp storage leak When the pool is destroyed, cmds are implicitly freed. Cmd level allocs have to be cleaned up to avoid leak. Cc: mesa-stable Signed-off-by: Yiwei Zhang Part-of: --- src/virtio/vulkan/vn_command_buffer.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/virtio/vulkan/vn_command_buffer.c b/src/virtio/vulkan/vn_command_buffer.c index b2ad0b37e71..b1ee4334264 100644 --- a/src/virtio/vulkan/vn_command_buffer.c +++ b/src/virtio/vulkan/vn_command_buffer.c @@ -701,6 +701,9 @@ vn_DestroyCommandPool(VkDevice device, vn_cs_encoder_fini(&cmd->cs); vn_object_base_fini(&cmd->base); + if (cmd->builder.tmp.data) + vk_free(&cmd->allocator, cmd->builder.tmp.data); + list_for_each_entry_safe(struct vn_command_buffer_query_batch, batch, &cmd->query_batches, head) { list_del(&batch->head);