glsl: Remove UBO reference lowering.

All UBO-supporting drivers now go through the NIR path, which does a
better job of it.

Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Reviewed-by: Timothy Arceri <tarceri@itsqueeze.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8044>

src/compiler/glsl/ir_optimization.h

@@ -145,8 +145,6 @@ bool lower_packing_builtins(exec_list *instructions, int op_mask);
 void lower_shared_reference(const struct gl_constants *consts,
                             struct gl_shader_program *prog,
                             struct gl_linked_shader *shader);
-void lower_ubo_reference(struct gl_linked_shader *shader,
-                         bool clamp_block_indices, bool use_std430_as_default);
 void lower_packed_varyings(void *mem_ctx,
                            unsigned locations_used,
                            const uint8_t *components,

src/compiler/glsl/linker.cpp

@@ -4576,14 +4576,6 @@ link_varyings_and_uniforms(unsigned first, unsigned last,
       if (prog->_LinkedShaders[i] == NULL)
          continue;
 
-      const struct gl_shader_compiler_options *options =
-         &consts->ShaderCompilerOptions[i];
-
-      if (options->LowerBufferInterfaceBlocks)
-         lower_ubo_reference(prog->_LinkedShaders[i],
-                             options->ClampBlockIndicesToArrayBounds,
-                             consts->UseSTD430AsDefaultPacking);
-
       if (i == MESA_SHADER_COMPUTE)
          lower_shared_reference(consts, prog, prog->_LinkedShaders[i]);
 

src/compiler/glsl/meson.build

@@ -184,7 +184,6 @@ files_libglsl = files(
   'lower_vertex_id.cpp',
   'lower_output_reads.cpp',
   'lower_shared_reference.cpp',
-  'lower_ubo_reference.cpp',
   'lower_xfb_varying.cpp',
   'opt_algebraic.cpp',
   'opt_array_splitting.cpp',

src/mesa/main/consts_exts.h

@@ -360,9 +360,6 @@ struct gl_shader_compiler_options
     */
    GLboolean OptimizeForAOS;
 
-   /** Lower UBO and SSBO access to intrinsics. */
-   GLboolean LowerBufferInterfaceBlocks;
-
    /** Clamp UBO and SSBO block indices so they don't go out-of-bounds. */
    GLboolean ClampBlockIndicesToArrayBounds;