i965/rbc: Clarify rational given for shader image resolves
Original commit added documentation explaining lossless compression
case:
commit 56f29911ec
Author: Topi Pohjolainen <topi.pohjolainen@intel.com>
Date: Tue Feb 2 10:00:41 2016 +0200
i965: Add a flag telling color resolve pass to ignore CCS_E
It, however, easily gives the impression that the sole purpose
of the intel_miptree_resolve_color() is to address lossless
compression. Original intention is to document the lack of
INTEL_MIPTREE_IGNORE_CCS_E flag given for the resolve call.
This patch fixes this along with a typo found spotted further
down.
Signed-off-by: Topi Pohjolainen <topi.pohjolainen@intel.com>
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net>
This commit is contained in:
@@ -283,8 +283,9 @@ intel_update_state(struct gl_context * ctx, GLuint new_state)
|
||||
/* Access to images is implemented using indirect messages
|
||||
* against data port. Normal render target write understands
|
||||
* lossless compression but unfortunately the typed/untyped
|
||||
* read/write interface doesn't. Therefore the compressed
|
||||
* surfaces need to be resolved prior to accessing them.
|
||||
* read/write interface doesn't. Therefore even lossless
|
||||
* compressed surfaces need to be resolved prior to accessing
|
||||
* them. Hence skip setting INTEL_MIPTREE_IGNORE_CCS_E.
|
||||
*/
|
||||
intel_miptree_resolve_color(brw, tex_obj->mt, 0);
|
||||
|
||||
@@ -300,7 +301,7 @@ intel_update_state(struct gl_context * ctx, GLuint new_state)
|
||||
}
|
||||
}
|
||||
|
||||
/* Resolve color buffers for non-coherent framebufer fetch. */
|
||||
/* Resolve color buffers for non-coherent framebuffer fetch. */
|
||||
if (!ctx->Extensions.MESA_shader_framebuffer_fetch &&
|
||||
ctx->FragmentProgram._Current &&
|
||||
ctx->FragmentProgram._Current->Base.OutputsRead) {
|
||||
|
Reference in New Issue
Block a user