From e178bca5cc194ecb3e6b447620045a72f9cc465d Mon Sep 17 00:00:00 2001 From: Eric Anholt Date: Tue, 10 Mar 2020 13:36:51 -0700 Subject: [PATCH] glsl/tests: Catch mkdir errors to help explain when they happen. A recent pipeline (https://gitlab.freedesktop.org/Venemo/mesa/-/jobs/1893357) failed with what looks like an intermittent error related to making files for the cache test inside of the core of the cache. Given some of the errors, it looks like maybe a mkdir failed, so log those errors earlier so we can debug what's going on next time. Reviewed-by: Timothy Arceri Part-of: --- src/compiler/glsl/tests/cache_test.c | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/src/compiler/glsl/tests/cache_test.c b/src/compiler/glsl/tests/cache_test.c index 9d7bde2834c..cf654e5b01d 100644 --- a/src/compiler/glsl/tests/cache_test.c +++ b/src/compiler/glsl/tests/cache_test.c @@ -230,7 +230,13 @@ test_disk_cache_create(void) expect_null(cache_exists(cache), "disk_cache_create with XDG_CACHE_HOME set " "with a non-existing parent directory"); - mkdir(CACHE_TEST_TMP, 0755); + err = mkdir(CACHE_TEST_TMP, 0755); + if (err != 0) { + fprintf(stderr, "Error creating %s: %s\n", CACHE_TEST_TMP, strerror(errno)); + error = true; + return; + } + cache = disk_cache_create("test", "make_check", 0); expect_non_null(cache_exists(cache), "disk_cache_create with XDG_CACHE_HOME " "set"); @@ -249,7 +255,13 @@ test_disk_cache_create(void) expect_null(cache_exists(cache), "disk_cache_create with MESA_GLSL_CACHE_DIR" " set with a non-existing parent directory"); - mkdir(CACHE_TEST_TMP, 0755); + err = mkdir(CACHE_TEST_TMP, 0755); + if (err != 0) { + fprintf(stderr, "Error creating %s: %s\n", CACHE_TEST_TMP, strerror(errno)); + error = true; + return; + } + cache = disk_cache_create("test", "make_check", 0); expect_non_null(cache_exists(cache), "disk_cache_create with " "MESA_GLSL_CACHE_DIR set");