OpenHarmony/third_party_mesa3d
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

anv: Disable compression on legacy modifiers (xe2)

Browse Source 
On pre-Xe2 platforms, the compression on these modifiers that
don't support compression are enabled. The compressed will be
resolved when needed. On Xe2+ we haven't support explicit
resolve, so all the paths to resolves are prohibited now. But
the code is still doing it, causing an assertion failure:

Fixes: vkcube
src/intel/vulkan/anv_private.h:5467:
anv_image_get_fast_clear_type_addr: Assertion
`device->info->ver < 20' failed.

Backport-to: 24.2
Signed-off-by: Jianxun Zhang <jianxun.zhang@intel.com>
Reviewed-by: Nanley Chery <nanley.g.chery@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30111>
This commit is contained in:
Jianxun Zhang
2024-07-26 09:45:27 -07:00
committed by Marge Bot
parent 6b4def143c
commit e054068787
1 changed files with 13 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/intel/vulkan/anv_image.c
View File

@@ -1584,6 +1584,19 @@ anv_image_init(struct anv_device *device, struct anv_image *image,
if (isl_drm_modifier_needs_display_layout(image->vk.drm_format_mod))
isl_extra_usage_flags |= ISL_SURF_USAGE_DISPLAY_BIT;
if (device->info->ver >= 20 &&
!isl_drm_modifier_has_aux(image->vk.drm_format_mod)) {
/* TODO: On Xe2+, we cannot support modifiers that don't support
* compression because such support requires an explicit resolve
* that hasn't been implemented.
*
* We disable this in anv_AllocateMemory() as well.
*
* https://gitlab.freedesktop.org/mesa/mesa/-/issues/11537
*/
isl_extra_usage_flags |= ISL_SURF_USAGE_DISABLE_AUX_BIT;
}
}
for (int i = 0; i < ANV_IMAGE_MEMORY_BINDING_END; ++i) {