radv: determine and store the next graphics stage to radv_shader_info

This will be useful in many cases.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22128>
This commit is contained in:
Samuel Pitoiset
2023-03-27 18:50:51 +02:00
committed by Marge Bot
parent d109362a3d
commit dd855c7772
5 changed files with 42 additions and 4 deletions

View File

@@ -2484,6 +2484,38 @@ radv_consider_force_vrs(const struct radv_device *device,
return true; return true;
} }
static gl_shader_stage
radv_get_next_stage(gl_shader_stage stage, VkShaderStageFlagBits active_nir_stages)
{
switch (stage) {
case MESA_SHADER_VERTEX:
if (active_nir_stages & VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) {
return MESA_SHADER_TESS_CTRL;
} else if (active_nir_stages & VK_SHADER_STAGE_GEOMETRY_BIT) {
return MESA_SHADER_GEOMETRY;
} else {
return MESA_SHADER_FRAGMENT;
}
case MESA_SHADER_TESS_CTRL:
return MESA_SHADER_TESS_EVAL;
case MESA_SHADER_TESS_EVAL:
if (active_nir_stages & VK_SHADER_STAGE_GEOMETRY_BIT) {
return MESA_SHADER_GEOMETRY;
} else {
return MESA_SHADER_FRAGMENT;
}
case MESA_SHADER_GEOMETRY:
case MESA_SHADER_MESH:
return MESA_SHADER_FRAGMENT;
case MESA_SHADER_TASK:
return MESA_SHADER_MESH;
case MESA_SHADER_FRAGMENT:
return MESA_SHADER_NONE;
default:
unreachable("invalid graphics shader stage");
}
}
static void static void
radv_fill_shader_info(struct radv_device *device, radv_fill_shader_info(struct radv_device *device,
struct radv_graphics_pipeline *pipeline, struct radv_graphics_pipeline *pipeline,
@@ -2496,7 +2528,9 @@ radv_fill_shader_info(struct radv_device *device,
bool consider_force_vrs = radv_consider_force_vrs(device, pipeline, noop_fs, stages); bool consider_force_vrs = radv_consider_force_vrs(device, pipeline, noop_fs, stages);
radv_foreach_stage(i, active_nir_stages) { radv_foreach_stage(i, active_nir_stages) {
radv_nir_shader_info_pass(device, stages[i].nir, pipeline_layout, pipeline_key, gl_shader_stage next_stage = radv_get_next_stage(i, active_nir_stages);
radv_nir_shader_info_pass(device, stages[i].nir, next_stage, pipeline_layout, pipeline_key,
pipeline->base.type, pipeline->base.type,
i == pipeline->last_vgt_api_stage && consider_force_vrs, i == pipeline->last_vgt_api_stage && consider_force_vrs,
&stages[i].info); &stages[i].info);
@@ -2810,7 +2844,7 @@ radv_pipeline_create_gs_copy_shader(struct radv_device *device, struct radv_pipe
.shader_sha1 = {0}, .shader_sha1 = {0},
}; };
radv_nir_shader_info_init(&gs_copy_stage.info); radv_nir_shader_info_init(&gs_copy_stage.info);
radv_nir_shader_info_pass(device, nir, pipeline_layout, pipeline_key, pipeline->type, false, radv_nir_shader_info_pass(device, nir, MESA_SHADER_FRAGMENT, pipeline_layout, pipeline_key, pipeline->type, false,
&gs_copy_stage.info); &gs_copy_stage.info);
gs_copy_stage.info.wave_size = 64; /* Wave32 not supported. */ gs_copy_stage.info.wave_size = 64; /* Wave32 not supported. */
gs_copy_stage.info.workgroup_size = 64; /* HW VS: separate waves, no workgroups */ gs_copy_stage.info.workgroup_size = 64; /* HW VS: separate waves, no workgroups */
@@ -5310,7 +5344,7 @@ radv_compute_pipeline_compile(struct radv_compute_pipeline *pipeline,
/* Run the shader info pass. */ /* Run the shader info pass. */
radv_nir_shader_info_init(&cs_stage.info); radv_nir_shader_info_init(&cs_stage.info);
radv_nir_shader_info_pass(device, cs_stage.nir, pipeline_layout, pipeline_key, radv_nir_shader_info_pass(device, cs_stage.nir, MESA_SHADER_NONE, pipeline_layout, pipeline_key,
pipeline->base.type, false, &cs_stage.info); pipeline->base.type, false, &cs_stage.info);
/* Declare shader arguments. */ /* Declare shader arguments. */

View File

@@ -267,7 +267,7 @@ radv_rt_pipeline_compile(struct radv_ray_tracing_pipeline *pipeline,
/* Run the shader info pass. */ /* Run the shader info pass. */
radv_nir_shader_info_init(&rt_stage.info); radv_nir_shader_info_init(&rt_stage.info);
radv_nir_shader_info_pass(device, rt_stage.nir, pipeline_layout, pipeline_key, radv_nir_shader_info_pass(device, rt_stage.nir, MESA_SHADER_NONE, pipeline_layout, pipeline_key,
pipeline->base.base.type, false, &rt_stage.info); pipeline->base.base.type, false, &rt_stage.info);
/* Declare shader arguments. */ /* Declare shader arguments. */

View File

@@ -3019,6 +3019,7 @@ void llvm_compile_shader(const struct radv_nir_compiler_options *options,
struct radv_shader_info; struct radv_shader_info;
void radv_nir_shader_info_pass(struct radv_device *device, const struct nir_shader *nir, void radv_nir_shader_info_pass(struct radv_device *device, const struct nir_shader *nir,
gl_shader_stage next_stage,
const struct radv_pipeline_layout *layout, const struct radv_pipeline_layout *layout,
const struct radv_pipeline_key *pipeline_key, const struct radv_pipeline_key *pipeline_key,
const enum radv_pipeline_type pipeline_type, const enum radv_pipeline_type pipeline_type,

View File

@@ -265,6 +265,7 @@ struct radv_shader_info {
unsigned workgroup_size; unsigned workgroup_size;
bool force_vrs_per_vertex; bool force_vrs_per_vertex;
gl_shader_stage stage; gl_shader_stage stage;
gl_shader_stage next_stage;
struct { struct {
uint8_t input_usage_mask[RADV_VERT_ATTRIB_MAX]; uint8_t input_usage_mask[RADV_VERT_ATTRIB_MAX];

View File

@@ -736,6 +736,7 @@ radv_nir_shader_info_init(struct radv_shader_info *info)
void void
radv_nir_shader_info_pass(struct radv_device *device, const struct nir_shader *nir, radv_nir_shader_info_pass(struct radv_device *device, const struct nir_shader *nir,
gl_shader_stage next_stage,
const struct radv_pipeline_layout *layout, const struct radv_pipeline_layout *layout,
const struct radv_pipeline_key *pipeline_key, const struct radv_pipeline_key *pipeline_key,
const enum radv_pipeline_type pipeline_type, const enum radv_pipeline_type pipeline_type,
@@ -743,6 +744,7 @@ radv_nir_shader_info_pass(struct radv_device *device, const struct nir_shader *n
struct radv_shader_info *info) struct radv_shader_info *info)
{ {
info->stage = nir->info.stage; info->stage = nir->info.stage;
info->next_stage = next_stage;
struct nir_function *func = (struct nir_function *)exec_list_get_head_const(&nir->functions); struct nir_function *func = (struct nir_function *)exec_list_get_head_const(&nir->functions);