OpenHarmony/third_party_mesa3d
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

zink: correct inaccurate comment

Browse Source 
PIPE_SHADER_CAP_MAX_CONST_BUFFER_SIZE translate into
GL_MAX_*_UNIFORM_COMPONENTS, all of which are allowed to be as
low as 1024 by the GL 4.6 spec.

PIPE_CAP_MAX_SHADER_BUFFER_SIZE translate into
GL_MAX_SHADER_STORAGE_BLOCK_SIZE, which has different minimum values in
different versions of the GL spec. In the GL 4.6 spec for instance, it
is required to be 2^27, the same as what Vulkan requires.

But what these limits are in GL is irrelevant at this level of
abstraction. The OpenGL state-tracker cares, but the Gallium driver
shouldn't have to. So let's just delete those parts of the comments.

Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9216>
This commit is contained in:
Erik Faye-Lund
2021-02-23 14:23:37 +01:00
committed by Marge Bot
parent 71a985d80b
commit dd055f6017
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/gallium/drivers/zink/zink_screen.c
View File

@@ -433,7 +433,7 @@ zink_get_param(struct pipe_screen *pscreen, enum pipe_cap param)
return 0;
case PIPE_CAP_MAX_SHADER_BUFFER_SIZE:
/* 16777216 (1<<24) is required by GL spec, 1<<27 is required by VK spec */
/* 1<<27 is required by VK spec */
assert(screen->info.props.limits.maxStorageBufferRange >= 1 << 27);
/* but Gallium can't handle values that are too big, so clamp to VK spec minimum */
return 1 << 27;
@@ -602,7 +602,7 @@ zink_get_shader_param(struct pipe_screen *pscreen,
}
case PIPE_SHADER_CAP_MAX_CONST_BUFFER_SIZE:
/* 16384 required by GL spec, this is the minimum required by VK spec */
/* At least 16384 is guaranteed by VK spec */
assert(screen->info.props.limits.maxUniformBufferRange >= 16384);
/* but Gallium can't handle values that are too big */
return MIN2(screen->info.props.limits.maxUniformBufferRange, 1 << 31);