OpenHarmony/third_party_mesa3d
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ac: fix incorrect bindless atomic code in visit_image_atomic

Browse Source 
Coverity: CID 1444664

Fixes: d62d434fe9 ("ac/nir_to_llvm: add image bindless support")

Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Timothy Arceri <tarceri@itsqueeze.com>
This commit is contained in:
Marek Olšák
2019-04-12 11:39:02 -04:00
parent 8671cfe2a2
commit dbab755ecf
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/amd/common/ac_nir_to_llvm.c
View File

@@ -2553,11 +2553,11 @@ static LLVMValueRef visit_image_atomic(struct ac_nir_context *ctx,
MAYBE_UNUSED int length; MAYBE_UNUSED int length;
enum glsl_sampler_dim dim; enum glsl_sampler_dim dim;
bool is_unsigned; bool is_unsigned = false;
bool is_array; bool is_array;
if (bindless) { if (bindless) {
if (instr->intrinsic == nir_intrinsic_image_atomic_min || if (instr->intrinsic == nir_intrinsic_bindless_image_atomic_min ||
instr->intrinsic == nir_intrinsic_image_atomic_max) { instr->intrinsic == nir_intrinsic_bindless_image_atomic_max) {
const GLenum format = nir_intrinsic_format(instr); const GLenum format = nir_intrinsic_format(instr);
assert(format == GL_R32UI || format == GL_R32I); assert(format == GL_R32UI || format == GL_R32I);
is_unsigned = format == GL_R32UI; is_unsigned = format == GL_R32UI;