From d91d2c275ef916e79e1e211cb1a86562d0e76f13 Mon Sep 17 00:00:00 2001 From: "Eric R. Smith" Date: Wed, 29 May 2024 10:45:23 -0300 Subject: [PATCH] panfrost: change default rounding mode for samplers The SamplerDescriptor structure has a field which describes how floating point coordinates should be converted to fixed point. Setting this to "true" (which causes round to nearest even) fixes a failing CTS test. The CTS test in question is: dEQP-GLES31.functional.texture.border_clamp.range_clamp.linear_float_color The OpenGL spec is somewhat vague about how rounding is to be performed, so it appears both settings should be legal; this may indicate a problem with the CTS. Nevertheless "round to nearest even" is probably a better default and since it fixes the failing test we may as well use it. Cc: mesa-stable Reviewed-by: Erik Faye-Lund Reviewed-by: Boris Brezillon Part-of: --- src/panfrost/lib/genxml/v10.xml | 2 +- src/panfrost/lib/genxml/v6.xml | 2 +- src/panfrost/lib/genxml/v7.xml | 2 +- src/panfrost/lib/genxml/v9.xml | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/panfrost/lib/genxml/v10.xml b/src/panfrost/lib/genxml/v10.xml index 43bb33227f9..1b253561b49 100644 --- a/src/panfrost/lib/genxml/v10.xml +++ b/src/panfrost/lib/genxml/v10.xml @@ -1018,7 +1018,7 @@ - + diff --git a/src/panfrost/lib/genxml/v6.xml b/src/panfrost/lib/genxml/v6.xml index 9d042c4db93..86622677991 100644 --- a/src/panfrost/lib/genxml/v6.xml +++ b/src/panfrost/lib/genxml/v6.xml @@ -632,7 +632,7 @@ - + diff --git a/src/panfrost/lib/genxml/v7.xml b/src/panfrost/lib/genxml/v7.xml index 7e0b794ec85..da560d2733a 100644 --- a/src/panfrost/lib/genxml/v7.xml +++ b/src/panfrost/lib/genxml/v7.xml @@ -696,7 +696,7 @@ - + diff --git a/src/panfrost/lib/genxml/v9.xml b/src/panfrost/lib/genxml/v9.xml index c08d49e2025..961f38badfa 100644 --- a/src/panfrost/lib/genxml/v9.xml +++ b/src/panfrost/lib/genxml/v9.xml @@ -623,7 +623,7 @@ - +