OpenHarmony/third_party_mesa3d
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

panfrost: change default rounding mode for samplers

Browse Source 
The SamplerDescriptor structure has a field which describes how
floating point coordinates should be converted to fixed point.
Setting this to "true" (which causes round to nearest even) fixes
a failing CTS test.

The CTS test in question is:
dEQP-GLES31.functional.texture.border_clamp.range_clamp.linear_float_color

The OpenGL spec is somewhat vague about how rounding is to be
performed, so it appears both settings should be legal; this may
indicate a problem with the CTS. Nevertheless "round to nearest even"
is probably a better default and since it fixes the failing test we
may as well use it.

Cc: mesa-stable
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29464>
This commit is contained in:
Eric R. Smith
2024-05-29 10:45:23 -03:00
committed by Marge Bot
parent ad033506aa
commit d91d2c275e
4 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/panfrost/lib/genxml/v10.xml
View File

@@ -1018,7 +1018,7 @@
<field name="Wrap Mode R" size="4" start="0:8" type="Wrap Mode" default="Clamp to Edge"/>
<field name="Wrap Mode T" size="4" start="0:12" type="Wrap Mode" default="Clamp to Edge"/>
<field name="Wrap Mode S" size="4" start="0:16" type="Wrap Mode" default="Clamp to Edge"/>
<field name="Round to nearest even" size="1" start="0:21" type="bool" default="false"/>
<field name="Round to nearest even" size="1" start="0:21" type="bool" default="true"/>
<!--- Disable sRGB-to-linear conversion (assume linear) -->
<field name="sRGB override" size="1" start="0:22" type="bool" default="false"/>
<field name="Seamless Cube Map" size="1" start="0:23" type="bool" default="true"/>

2
src/panfrost/lib/genxml/v6.xml
View File

@@ -632,7 +632,7 @@
<field name="Wrap Mode R" size="4" start="0:8" type="Wrap Mode" default="Clamp to Edge"/>
<field name="Wrap Mode T" size="4" start="0:12" type="Wrap Mode" default="Clamp to Edge"/>
<field name="Wrap Mode S" size="4" start="0:16" type="Wrap Mode" default="Clamp to Edge"/>
<field name="Round to nearest even" size="1" start="0:21" type="bool" default="false"/>
<field name="Round to nearest even" size="1" start="0:21" type="bool" default="true"/>
<!--- Disable sRGB-to-linear conversion (assume linear) -->
<field name="sRGB override" size="1" start="0:22" type="bool" default="false"/>
<field name="Seamless Cube Map" size="1" start="0:23" type="bool" default="true"/>

2
src/panfrost/lib/genxml/v7.xml
View File

@@ -696,7 +696,7 @@
<field name="Wrap Mode R" size="4" start="0:8" type="Wrap Mode" default="Clamp to Edge"/>
<field name="Wrap Mode T" size="4" start="0:12" type="Wrap Mode" default="Clamp to Edge"/>
<field name="Wrap Mode S" size="4" start="0:16" type="Wrap Mode" default="Clamp to Edge"/>
<field name="Round to nearest even" size="1" start="0:21" type="bool" default="false"/>
<field name="Round to nearest even" size="1" start="0:21" type="bool" default="true"/>
<!--- Disable sRGB-to-linear conversion (assume linear) -->
<field name="sRGB override" size="1" start="0:22" type="bool" default="false"/>
<field name="Seamless Cube Map" size="1" start="0:23" type="bool" default="true"/>

2
src/panfrost/lib/genxml/v9.xml
View File

@@ -623,7 +623,7 @@
<field name="Wrap Mode R" size="4" start="0:8" type="Wrap Mode" default="Clamp to Edge"/>
<field name="Wrap Mode T" size="4" start="0:12" type="Wrap Mode" default="Clamp to Edge"/>
<field name="Wrap Mode S" size="4" start="0:16" type="Wrap Mode" default="Clamp to Edge"/>
<field name="Round to nearest even" size="1" start="0:21" type="bool" default="false"/>
<field name="Round to nearest even" size="1" start="0:21" type="bool" default="true"/>
<!--- Disable sRGB-to-linear conversion (assume linear) -->
<field name="sRGB override" size="1" start="0:22" type="bool" default="false"/>
<field name="Seamless Cube Map" size="1" start="0:23" type="bool" default="true"/>