OpenHarmony/third_party_mesa3d
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

mesa: Remove cmd_size < 0 check.

Browse Source 
cmd_size was changed to size_t in commit 4b2445916e ("glthread:
change sizes to unsigned or size_t where needed").

Fix defect reported by Coverity Scan.

Macro compares unsigned to 0 (NO_EFFECT)
unsigned_compare: This less-than-zero comparison of an unsigned
value is never true. cmd_size < 0UL

Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8024>
This commit is contained in:
Vinson Lee
2020-12-09 18:51:16 -08:00
committed by Marge Bot
parent 56cb5cf34e
commit d7911f9c6b
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/mesa/main/glthread_bufferobj.c
View File

@@ -280,8 +280,7 @@ _mesa_marshal_BufferData_merged(GLuint target_or_name, GLsizeiptr size,
bool copy_data = data && !external_mem;
size_t cmd_size = sizeof(struct marshal_cmd_BufferData) + (copy_data ? size : 0);
if (unlikely(size < 0 || size > INT_MAX || cmd_size < 0 ||
cmd_size > MARSHAL_MAX_CMD_SIZE ||
if (unlikely(size < 0 || size > INT_MAX || cmd_size > MARSHAL_MAX_CMD_SIZE ||
(named && target_or_name == 0))) {
_mesa_glthread_finish_before(ctx, func);
if (named) {