From d0f4333fcad81ee2f5849ab9e9f45f5d99fe38b5 Mon Sep 17 00:00:00 2001
From: Vinson Lee <vlee@freedesktop.org>
Date: Sat, 12 Aug 2023 20:42:52 -0700
Subject: [PATCH] intel/decoder: Fix memory leak on error path

Fix defect reported by Coverity Scan.

Resource leak (RESOURCE_LEAK)
leaked_storage: Variable text_data going out of scope leaks the storage it points to.

Fixes: b4c8d2dc455 ("intel/decoder: Add intel_spec_load_common()")
Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24659>
---
 src/intel/common/intel_decoder.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/intel/common/intel_decoder.c b/src/intel/common/intel_decoder.c
index e639c0684bc..f63afbdee3c 100644
--- a/src/intel/common/intel_decoder.c
+++ b/src/intel/common/intel_decoder.c
@@ -638,8 +638,10 @@ get_embedded_xml_data(int verx10, void **data, size_t *data_len)
    assert(text_offset + text_length <= total_length);
 
    *data = malloc(text_length);
-   if (*data == NULL)
+   if (*data == NULL) {
+      free(text_data);
       return false;
+   }
 
    memcpy(*data, &text_data[text_offset], text_length);
    free(text_data);