OpenHarmony/third_party_mesa3d
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

st/mesa: fix texture memory allocation bug

Browse Source 
The following example caused an incorrect GL_OUT_OF_MEMORY error to be
raised in glTexSubImage2D:

   glTexImage2D(level=0, width=32, height=32, pixels=NULL);
   glTexImage2D(level=0, width=64, height=64, pixels=NULL);
   glTexSubImage2D(level=0, pixels!=NULL);

The second glTexImage2D() call needs to cause the first image to be
deallocated then reallocated at the new size.  This was not happening
because we were testing for pixels==NULL too early.
This commit is contained in:
Brian Paul
2009-09-16 12:57:26 -06:00
parent 2921a2555d
commit cfa1a0a609
1 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/mesa/state_tracker/st_cb_texture.c
View File

@@ -661,8 +661,10 @@ st_TexImage(GLcontext * ctx,
format, type, format, type,
pixels, unpack, "glTexImage"); pixels, unpack, "glTexImage");
} }
if (!pixels)
return; /* Note: we can't check for pixels==NULL until after we've allocated
* memory for the texture.
*/
/* See if we can do texture compression with a blit/render. /* See if we can do texture compression with a blit/render.
*/ */
@@ -673,6 +675,9 @@ st_TexImage(GLcontext * ctx,
stImage->pt->format, stImage->pt->format,
stImage->pt->target, stImage->pt->target,
PIPE_TEXTURE_USAGE_RENDER_TARGET, 0)) { PIPE_TEXTURE_USAGE_RENDER_TARGET, 0)) {
if (!pixels)
goto done;
if (compress_with_blit(ctx, target, level, 0, 0, 0, width, height, depth, if (compress_with_blit(ctx, target, level, 0, 0, 0, width, height, depth,
format, type, pixels, unpack, texImage)) { format, type, pixels, unpack, texImage)) {
goto done; goto done;
@@ -714,6 +719,9 @@ st_TexImage(GLcontext * ctx,
return; return;
} }
if (!pixels)
goto done;
DBG("Upload image %dx%dx%d row_len %x pitch %x\n", DBG("Upload image %dx%dx%d row_len %x pitch %x\n",
width, height, depth, width * texelBytes, dstRowStride); width, height, depth, width * texelBytes, dstRowStride);