OpenHarmony/third_party_mesa3d
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "i965: Disable guardband clipping in the smaller-than-viewport case."

Browse Source 
This reverts commit 0bac2551e4.

Now that we position the guardband correctly (applying translations
in addition to scaling) and made it as large (or larger) than the
render target, this shouldn't be necessary.

Now we leave guardband clipping enabled 100% of the time, like the
Windows driver does.

Fixes GL45-CTS.gtf21.GL2FixedTests.clip.clip.  It tries to draw a
16384x64 rectangle, and it appears that some kind of numerical
imprecisions in the clipper result in some edge pixels going missing.
The Windows driver passes this test because of guardband clipping.

Cc: "17.0" <mesa-stable@lists.freedesktop.org>
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net>
This commit is contained in:
Kenneth Graunke
2017-01-21 03:54:46 -08:00
parent ece0e535a4
commit ce8a63de6d
1 changed files with 0 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
src/mesa/drivers/dri/i965/gen6_clip_state.c
View File

@@ -172,37 +172,6 @@ upload_clip_state(struct brw_context *brw)
/* BRW_NEW_VIEWPORT_COUNT */
const unsigned viewport_count = brw->clip.viewport_count;
/* We need to disable guardband clipping if the guardband (which we always
* program to the maximum screen-space bounding box of 8K x 8K) will be
* smaller than the viewport.
*
* Closely examining the clip determination formulas in the documentation
* reveals that objects will be discarded entirely if they're outside the
* (small) guardband, even if they're within the (large) viewport:
*
* TR = TR_GB || TR_VPXY || TR_VPZ || TR_UC || TR_NEGW
* TA = !TR && TA_GB && TA_VPZ && TA_NEGW
* MC = !(TA || TR)
*
* (TA is "Trivial Accept", TR is "Trivial Reject", MC is "Must Clip".)
*
* Disabling guardband clipping removes the TR_GB condition, which means
* they'll be considered MC ("Must Clip") unless they're rejected for
* some other reason.
*
* Note that there is no TA_VPXY condition. If there were, objects entirely
* inside a 16384x16384 viewport would be trivially accepted, breaking the
* "objects must have a screenspace bounding box not exceeding 8K in the X
* or Y direction" restriction. Instead, they're clipped.
*/
for (unsigned i = 0; i < viewport_count; i++) {
if (ctx->ViewportArray[i].Width > 8192 ||
ctx->ViewportArray[i].Height > 8192) {
dw2 &= ~GEN6_CLIP_GB_TEST;
break;
}
}
/* BRW_NEW_RASTERIZER_DISCARD */
if (ctx->RasterDiscard) {
dw2 |= GEN6_CLIP_MODE_REJECT_ALL;