OpenHarmony/third_party_mesa3d
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

linker: Remove unnecessary overload of program_resource_visitor::visit_field

Browse Source 
It looks like I added this version as a short-hand for users that didn't
need the fuller version.  I don't think there's any real utility in
that.  I'm not sure what my thinking was there.  Maybe if those users
overloaded the recursion function could just call the compact version to
avoid passing some parameters?  None of the users do that.

Either way, having this extra overload is not useful.  Delete it.

Signed-off-by: Ian Romanick <ian.d.romanick@intel.com>
Reviewed-by: Tapani Pälli <tapani.palli@intel.com>
This commit is contained in:
Ian Romanick
2016-11-09 12:45:39 -08:00
parent b359f62456
commit cbba5e13ac
5 changed files with 22 additions and 51 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/compiler/glsl/link_uniform_blocks.cpp
View File

@@ -60,15 +60,6 @@ public:
struct gl_shader_program *prog;
private:
virtual void visit_field(const glsl_type *type, const char *name,
bool row_major)
{
(void) type;
(void) name;
(void) row_major;
assert(!"Should not get here.");
}
virtual void enter_record(const glsl_type *type, const char *,
bool row_major, const enum glsl_interface_packing packing) {
assert(type->is_record());
@@ -191,12 +182,13 @@ public:
unsigned num_active_uniforms;
private:
virtual void visit_field(const glsl_type *type, const char *name,
bool row_major)
virtual void visit_field(const glsl_type * /* type */,
const char * /* name */,
bool /* row_major */,
const glsl_type * /* record_type */,
const enum glsl_interface_packing,
bool /* last_field */)
{
(void) type;
(void) name;
(void) row_major;
this->num_active_uniforms++;
}
};