OpenHarmony/third_party_mesa3d
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

radv: lower 64-bit drcp/dsqrt/drsq for fixing precision issues

Browse Source 
The hardware precision of v_rcp_f64, v_sqrt_f64 and v_rsq_f64
is less than what Vulkan requires.

This lowers using the Goldschmidt's algorithm to improve precision.

Fixes dEQP-VK.glsl.builtin.precision_double.* on both compiler
backends.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Daniel Schürmann <daniel@schuermann.dev>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5609>
This commit is contained in:
Samuel Pitoiset
2020-06-23 18:29:22 +02:00
committed by Marge Bot
parent 82b4666783
commit c84f11e7b6
8 changed files with 16 additions and 162 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/amd/vulkan/radv_shader.c
View File

@@ -86,6 +86,10 @@ static const struct nir_shader_compiler_options nir_options_llvm = {
nir_lower_divmod64 |
nir_lower_minmax64 |
nir_lower_iabs64,
.lower_doubles_options = nir_lower_drcp |
nir_lower_dsqrt |
nir_lower_drsq |
nir_lower_ddiv,
};
static const struct nir_shader_compiler_options nir_options_aco = {
@@ -122,6 +126,10 @@ static const struct nir_shader_compiler_options nir_options_aco = {
nir_lower_divmod64 |
nir_lower_minmax64 |
nir_lower_iabs64,
.lower_doubles_options = nir_lower_drcp |
nir_lower_dsqrt |
nir_lower_drsq |
nir_lower_ddiv,
};
bool
@@ -466,6 +474,11 @@ radv_shader_compile_to_nir(struct radv_device *device,
NIR_PASS_V(nir, radv_nir_lower_ycbcr_textures, layout);
if (device->instance->debug_flags & RADV_DEBUG_DISCARD_TO_DEMOTE)
NIR_PASS_V(nir, nir_lower_discard_to_demote);
nir_lower_doubles_options lower_doubles =
nir->options->lower_doubles_options;
NIR_PASS_V(nir, nir_lower_doubles, NULL, lower_doubles);
}
/* Vulkan uses the separate-shader linking model */