From c68f96878ce208f2c1cbd32aa143c8cbf68b3a36 Mon Sep 17 00:00:00 2001 From: Samuel Pitoiset Date: Fri, 26 Jan 2024 14:13:10 +0100 Subject: [PATCH] radv: fix segfault when getting device vm fault info pFaultInfo can be NULL. Fixes: 8097becc7f1 ("radv: add initial VK_EXT_device_fault support") Signed-off-by: Samuel Pitoiset Part-of: --- src/amd/vulkan/radv_debug.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_debug.c b/src/amd/vulkan/radv_debug.c index 9fb67a6011e..34433384062 100644 --- a/src/amd/vulkan/radv_debug.c +++ b/src/amd/vulkan/radv_debug.c @@ -1085,7 +1085,8 @@ radv_GetDeviceFaultInfoEXT(VkDevice _device, VkDeviceFaultCountsEXT *pFaultCount .addressPrecision = 4096, /* 4K page granularity */ }; - strncpy(pFaultInfo->description, "A GPUVM fault has been detected", sizeof(pFaultInfo->description)); + if (pFaultInfo) + strncpy(pFaultInfo->description, "A GPUVM fault has been detected", sizeof(pFaultInfo->description)); if (device->physical_device->rad_info.gfx_level >= GFX10) { addr_fault_info.addressType = G_00A130_RW(fault_info.status) ? VK_DEVICE_FAULT_ADDRESS_TYPE_WRITE_INVALID_EXT