OpenHarmony/third_party_mesa3d
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

mesa: Skip 3-byte array formats in _mesa_array_format_flip_channels

Browse Source 
Byte swapping makes no sense for 3-byte formats: Swapping the order of 2
or 4 bytes at a time would inevitably result in bytes getting mixed up
between neighbouring pixels.

Fixes crash with a debugging build on a big endian machine due hitting
the unreachable() at the end of the function.

Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/2665
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4735>
This commit is contained in:
Michel Dänzer
2020-04-24 11:40:14 +02:00
committed by Marge Bot
parent ad5da3e63e
commit c50bbfa0ab
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/mesa/main/formats.c
View File

@@ -404,7 +404,7 @@ _mesa_array_format_flip_channels(mesa_array_format format)
num_channels = _mesa_array_format_get_num_channels(format);
_mesa_array_format_get_swizzle(format, swizzle);
if (num_channels == 1)
if (num_channels == 1 || num_channels == 3)
return format;
if (num_channels == 2) {