i965: Correct check for re-bound buffer in intel_update_image_buffer
The buffer-object is the persistent thing passed through the loader, so when updating an image buffer, check to see if it is already bound to the provided bo. The region, on the other hand, is allocated separately for the miptree, and so will never be the same as that passed back from the loader. Signed-off-by: Keith Packard <keithp@keithp.com> Reviewed-by: Eric Anholt <eric@anholt.net> Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
This commit is contained in:

committed by
Kenneth Graunke

parent
ca2012a912
commit
c426fb08cf
@@ -1303,10 +1303,21 @@ intel_update_image_buffer(struct brw_context *intel,
|
||||
|
||||
unsigned num_samples = rb->Base.Base.NumSamples;
|
||||
|
||||
if (rb->mt &&
|
||||
rb->mt->region &&
|
||||
rb->mt->region == region)
|
||||
return;
|
||||
/* Check and see if we're already bound to the right
|
||||
* buffer object
|
||||
*/
|
||||
if (num_samples == 0) {
|
||||
if (rb->mt &&
|
||||
rb->mt->region &&
|
||||
rb->mt->region->bo == region->bo)
|
||||
return;
|
||||
} else {
|
||||
if (rb->mt &&
|
||||
rb->mt->singlesample_mt &&
|
||||
rb->mt->singlesample_mt->region &&
|
||||
rb->mt->singlesample_mt->region->bo == region->bo)
|
||||
return;
|
||||
}
|
||||
|
||||
intel_miptree_release(&rb->mt);
|
||||
rb->mt = intel_miptree_create_for_image_buffer(intel,
|
||||
|
Reference in New Issue
Block a user