From c21e184cc5cc818285c5590f36b170362defaf27 Mon Sep 17 00:00:00 2001 From: Qiang Yu Date: Mon, 14 Nov 2022 15:28:44 +0800 Subject: [PATCH] ac/nir/ngg: remove nuw for negative value add MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Add negative value is possible to wrap around. I haven't seen this "nuw" causes any problem yet, but let's remove it for safe. Fixes: 60ac5dda82e ("ac: Add NIR lowering for NGG GS.") Reviewed-by: Timur Kristóf Signed-off-by: Qiang Yu Part-of: --- src/amd/common/ac_nir_lower_ngg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/common/ac_nir_lower_ngg.c b/src/amd/common/ac_nir_lower_ngg.c index d14596767ac..9e44b4a435a 100644 --- a/src/amd/common/ac_nir_lower_ngg.c +++ b/src/amd/common/ac_nir_lower_ngg.c @@ -2427,7 +2427,7 @@ ngg_gs_shader_query(nir_builder *b, nir_intrinsic_instr *intrin, lower_ngg_gs_st nir_ssa_def *gs_vtx_cnt = intrin->src[0].ssa; nir_ssa_def *prm_cnt = intrin->src[1].ssa; if (s->num_vertices_per_primitive > 1) - prm_cnt = nir_iadd_nuw(b, nir_imul_imm(b, prm_cnt, -1u * (s->num_vertices_per_primitive - 1)), gs_vtx_cnt); + prm_cnt = nir_iadd(b, nir_imul_imm(b, prm_cnt, -1u * (s->num_vertices_per_primitive - 1)), gs_vtx_cnt); num_prims_in_wave = nir_reduce(b, prm_cnt, .reduction_op = nir_op_iadd); }