bin/get-pick-list.sh: use test instead of [ ]
Latter is rather picky wrt surrounding white space. The explicit `test` doesn't have that problem, plus the statements read a bit easier. Cc: mesa-stable@lists.freedesktop.org Reviewed-by: Juan A. Suarez <jasuarez@igalia.com> Signed-off-by: Emil Velikov <emil.velikov@collabora.com>
This commit is contained in:

committed by
Emil Velikov

parent
77ff0bfb5f
commit
c0012a0708
@@ -30,10 +30,10 @@ is_sha_nomination()
|
|||||||
grep -Eo 'fixes:[a-f0-9]{8,40}'`
|
grep -Eo 'fixes:[a-f0-9]{8,40}'`
|
||||||
|
|
||||||
fixes_count=`echo "$fixes" | wc -l`
|
fixes_count=`echo "$fixes" | wc -l`
|
||||||
if [ $fixes_count -eq 0 ] ; then
|
if test $fixes_count -eq 0; then
|
||||||
return 0
|
return 0
|
||||||
fi
|
fi
|
||||||
while [ $fixes_count -gt 0 ] ; do
|
while test $fixes_count -gt 0; do
|
||||||
# Treat only the current line
|
# Treat only the current line
|
||||||
id=`echo "$fixes" | tail -n $fixes_count | head -n 1 | cut -d : -f 2`
|
id=`echo "$fixes" | tail -n $fixes_count | head -n 1 | cut -d : -f 2`
|
||||||
fixes_count=$(($fixes_count-1))
|
fixes_count=$(($fixes_count-1))
|
||||||
@@ -41,7 +41,7 @@ is_sha_nomination()
|
|||||||
# Bail out if we cannot find suitable id.
|
# Bail out if we cannot find suitable id.
|
||||||
# Any specific validation the $id is valid and not some junk, is
|
# Any specific validation the $id is valid and not some junk, is
|
||||||
# implied with the follow up code
|
# implied with the follow up code
|
||||||
if [ "x$id" = x ] ; then
|
if test "x$id" = x; then
|
||||||
continue
|
continue
|
||||||
fi
|
fi
|
||||||
|
|
||||||
@@ -87,7 +87,7 @@ git log --reverse --pretty=%H -i --grep='^CC:.*mesa-stable\|^CC:.*mesa-dev\|\<fi
|
|||||||
while read sha
|
while read sha
|
||||||
do
|
do
|
||||||
# Check to see whether the patch is on the ignore list.
|
# Check to see whether the patch is on the ignore list.
|
||||||
if [ -f bin/.cherry-ignore ] ; then
|
if test -f bin/.cherry-ignore; then
|
||||||
if grep -q ^$sha bin/.cherry-ignore ; then
|
if grep -q ^$sha bin/.cherry-ignore ; then
|
||||||
continue
|
continue
|
||||||
fi
|
fi
|
||||||
|
Reference in New Issue
Block a user